Page MenuHomePhabricator
Create Task
Maniphest T8653

xhpast generation does not work properly under MinGW if the repo has CRLF line endings
Open, Needs TriagePublic
Actions

Description

Building XHPAST on Windows doesn't work if the repository has CRLF line endings. This is because the code that pulls out the node names leaves CR on various constants.

Instead, either:

  • The make file should error if it detects a CR in any of the source files, so the user knows what the error is (because right now it spits out hundreds of unrelated C++ errors).
  • The make file / generate nodes script should strip CR after reading input files.

Event Timeline

hach-que created this task.Jun 24 2015, 7:21 AM
hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: XHPAST.
hach-que added a subscriber: hach-que.
hach-que added a comment.Jun 24 2015, 7:30 AM

Another option is to add the following to .gitattributes:

*.php text eol=lf
*.cpp text eol=lf
*.hpp text eol=lf
*.y text eol=lf
*.l text eol=lf

to force the repository to always checkout those files with LF line endings, even on Windows.

joshuaspence added a subscriber: joshuaspence.Jun 24 2015, 7:52 AM
richardvanvelzen added a subscriber: richardvanvelzen.Jun 24 2015, 12:40 PM
epriestley moved this task from Backlog to Windows on the XHPAST board.Apr 7 2020, 1:33 PM
Herald added a subscriber: amckinley. · View Herald TranscriptApr 7 2020, 1:33 PM
Phabricator · Built by Phacility