Allow XHPAST to be built without flex and bison
ClosedPublic
Actions

Authored by joshuaspence on Nov 1 2015, 8:59 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9289: Unable to build XHPAST

Commits

rPHU7f4daf71c480: Allow XHPAST to be built without flex and bison

Summary

Fixes T9289. This is a bit hacky, but feels like a reasonable workaround. Basically, add SKIP_PARSER and SKIP_SCANNER flags to the Makefile. If these flags are present then the Makefile effectively behaves like this:

%.lex.hpp %.lex.cpp: %.l
    touch $*.lex.hpp $*.lex.cpp
        
%.yacc.hpp %.yacc.cpp: %.y
    touch $*.yacc.hpp $*.yacc.cpp

If users are compiling XHPAST with libphutil/scripts/build_xhpast.php (which is the recommendation method) then there should be no difference here because this script will pass SKIP_PARSER=1 SKIP_LEXER=1.

Test Plan

Played around with make and confirmed that the flags behaved as expected.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 34708.Nov 1 2015, 8:59 PM

joshuaspence retitled this revision from to Allow XHPAST to be built without flex and bison.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T9289: Unable to build XHPAST.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 1 2015, 8:59 PM

Herald added a subscriber: Korvin. · View Herald Transcript

tycho.tatitscheff added a subscriber: tycho.tatitscheff.Nov 1 2015, 9:38 PM

tycho.tatitscheff added inline comments.

support/xhpast/Makefile
6	Is that lint intended for Makefile by the way.

joshuaspence added inline comments.Nov 1 2015, 9:40 PM

support/xhpast/Makefile
6	I have a diff floating around which modifies `ArcanistTextLinter` to support reading from `.editorconfig`. If I ever finish that diff off, an error wouldn't be raised here.