Page MenuHomePhabricator
Feed Advanced Search

Feb 9 2018

epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

(I've muted this task so I shouldn't get mail about it.)

Feb 9 2018, 2:16 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

"Quack, quack" said the duck.

Feb 9 2018, 2:13 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

We now have Postmark configured as a primary mailer for this domain with inbound (via MX record) and outbound (via cluster.mailers) failover to Mailgun. 📫

Feb 9 2018, 2:13 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

"Moo", said the cow.

Feb 9 2018, 2:12 AM · Phacility, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19043: Don't run older mail setup checks if "cluster.mailers" is configured.
Feb 9 2018, 1:50 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.
  • PhabricatorMailSetupCheck should be removed, but some of the SES stuff should stick around.
Feb 9 2018, 1:48 AM · Phacility, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19042: Fix transposed name/email in Mailgun adapter.
Feb 9 2018, 1:27 AM · Phacility, Mail

Feb 8 2018

epriestley added a project to T9031: When I ignore subscription changes, I'm not notified of being cc'ed: Mail.
Feb 8 2018, 8:49 PM · Mail, Notifications
epriestley added a comment to T13068: Refinements for "Mute Notifications".

I largely agree. This is getting leeway because it's backed by support mana (PHI126 basically just asks for this feature, verbatim). I think the actual change in D19033 is small enough that I don't feel too bad about giving this a shot, but I'd like this feature to see significant use and not generate a lot of confusion/support load if it's going to stay in the upstream. I'm also more comfortable trying this because it's very easy to revert.

Feb 8 2018, 8:10 PM · Notifications, Mail
avivey added a comment to T13068: Refinements for "Mute Notifications".

For what it's worth, I think the Mute feature adds a lot of complexities to the system, in excess to the norms of the last few years:

  • Code to handle it in the sending mechanism
  • Prioritizing this feature against any other notify feature (like T9031)
  • UI to show the to the muting user (on the object and in /mail/?)
  • UI to show to other users that this user will not be notified (What if all members of a project are muting a thread?)
  • Can a mailing list/project mute a topic?
  • "why did I not receive this notification?" - there's still some issues about this - novice users don't know/understand /mail/, and admins can't see this for them. I suspect this question will require a written checklist somewhere.
Feb 8 2018, 7:37 PM · Notifications, Mail
epriestley closed T13053: Plans: Mail Tags and Failover as Resolved.

See T13069 for followups on mail stamps.

Feb 8 2018, 7:35 PM · Plans, Must Encrypt Mail, Mail
epriestley closed T11363: Differential "revision updated" mail preference is pretty useless, a subtask of T10448: Modularize mail tags, as Resolved.
Feb 8 2018, 7:29 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T11363: Differential "revision updated" mail preference is pretty useless as Resolved.

See T13069 for this and other similar use cases.

Feb 8 2018, 7:29 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley closed T10448: Modularize mail tags as Resolved.

I'm going to roll this forward into T13069, which discusses remaining work for "mail stamps".

Feb 8 2018, 7:29 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc, a subtask of T10448: Modularize mail tags, as Resolved.
Feb 8 2018, 7:28 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc as Resolved.

I'm going to roll this forward into T13069.

Feb 8 2018, 7:28 PM · Customer Impact, Restricted Project, Mail
epriestley triaged T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags as Normal priority.
Feb 8 2018, 7:24 PM · Mail
epriestley added a comment to T13068: Refinements for "Mute Notifications".

If this feature doesn't see much use, I'd like to remove or deemphasize it (for example, by moving it to a keystroke or removing the UI and just providing access via !mute) at some point since I think UI space in the curtain is premium real estate. This doesn't need to be 200 mutes per user per day, but I could imagine this seeing essentially zero use.

Feb 8 2018, 6:59 PM · Notifications, Mail
epriestley triaged T13068: Refinements for "Mute Notifications" as Low priority.
Feb 8 2018, 6:55 PM · Notifications, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19033: Add "Mute/Unmute" for subscribable objects.
Feb 8 2018, 6:48 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

If we make "Must Encrypt" stateful, that flag should also probably live in this table.

Feb 8 2018, 6:02 PM · Mail
epriestley moved T7477: Handle inbound email with phabricator address in the CC from Stamps/Failover to Future on the Mail board.
Feb 8 2018, 6:02 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

The scope on T13053 didn't end up making it very far in this direction so I think this missed the boat for now.

Feb 8 2018, 6:02 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T8363: Include reply action ("!action") hints in outbound email.

T11934 plans to add these commands everywhere. If they're available all over the place, it might be less necessary to add reminders.

Feb 8 2018, 6:00 PM · llvm, Restricted Project, Mail
epriestley moved T8363: Include reply action ("!action") hints in outbound email from Backlog to Future on the Mail board.
Feb 8 2018, 5:58 PM · llvm, Restricted Project, Mail
epriestley closed T11389: Object links merged in plain text email as Resolved by committing rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:52 PM · Remarkup, Bug Report, Mail
epriestley closed T7804: Implement an "Acting User" Herald condition as Resolved by committing rPbca9c08953bd: Add an "Acting user" field to Herald.
Feb 8 2018, 5:52 PM · Restricted Project, Herald, Mail
epriestley added a comment to T11389: Object links merged in plain text email.

D19032 now renders D123 in text contexts (plaintext email) as D123 <https://dev.tyrellcorp.com/D123> instead of https://dev.tyrellcorp.com/D123.

Feb 8 2018, 5:51 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T11389: Object links merged in plain text email: D19032: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley moved T11389: Object links merged in plain text email from Backlog to Stamps/Failover on the Mail board.
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19031: Add an "Acting user" field to Herald.
Feb 8 2018, 5:41 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T7804: Implement an "Acting User" Herald condition: D19031: Add an "Acting user" field to Herald.
Feb 8 2018, 5:41 PM · Restricted Project, Herald, Mail
epriestley moved T7804: Implement an "Acting User" Herald condition from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:40 PM · Restricted Project, Herald, Mail
epriestley closed T10189: Differential email headers seem to be missing as Resolved by committing rP6186f0aa91b6: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:31 PM · Differential, Mail, Bug Report
epriestley closed T7463: after changed mailbox to office 365, mail format is strange as Invalid.

I'm not sure how to reproduce whatever remaining issues are described here so I don't see how to move this forward.

Feb 8 2018, 5:26 PM · Mail
epriestley added a comment to T10189: Differential email headers seem to be missing.

D19030 marks this as fixed: it removes this documentation.

Feb 8 2018, 5:23 PM · Differential, Mail, Bug Report
epriestley moved T10189: Differential email headers seem to be missing from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19030: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:21 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T10189: Differential email headers seem to be missing: D19030: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley moved T10874: Add repository or project to email subject from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:14 PM · Restricted Project, Mail, Feature Request
epriestley merged T10874: Add repository or project to email subject into T10448: Modularize mail tags.
Feb 8 2018, 5:13 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T10874: Add repository or project to email subject into T10448: Modularize mail tags.
Feb 8 2018, 5:13 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T10874: Add repository or project to email subject.

I'm going to merge this into T10448, which exposes this information in an X-Header and optionally in mail bodies.

Feb 8 2018, 5:13 PM · Restricted Project, Mail, Feature Request
epriestley closed T6576: HTML bodies are not passed to all emails, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
Feb 8 2018, 5:12 PM · Mail, Differential
epriestley closed T6576: HTML bodies are not passed to all emails as Resolved by committing rPbae9f459ab7f: Pass HTML bodies to push email.
Feb 8 2018, 5:12 PM · llvm, Mail
epriestley moved T10283: improve differential emails, optimizing for efficiency from Backlog to Stamps/Failover on the Mail board.
Feb 8 2018, 5:11 PM · Mail, Restricted Project, Feature Request
epriestley added a project to T10283: improve differential emails, optimizing for efficiency: Mail.
Feb 8 2018, 5:11 PM · Mail, Restricted Project, Feature Request
epriestley added a comment to T6576: HTML bodies are not passed to all emails.

I've marked D19029 as resolving this since it fixes the last one of these that I'm aware of. HTML mail has been the default for a long time now so this presumably isn't really causing problems even if there are other cases.

Feb 8 2018, 5:08 PM · llvm, Mail
epriestley added a revision to T6576: HTML bodies are not passed to all emails: D19029: Pass HTML bodies to push email.
Feb 8 2018, 5:08 PM · llvm, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19029: Pass HTML bodies to push email.
Feb 8 2018, 5:08 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19028: Only add the Mail "STAMPS" body section if there are stamps.
Feb 8 2018, 5:05 PM · Plans, Must Encrypt Mail, Mail
epriestley moved T6576: HTML bodies are not passed to all emails from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:04 PM · llvm, Mail
epriestley moved T13065: Move storage for `mailKey` to the Mail application from Backlog to Far Future on the Mail board.
Feb 8 2018, 5:00 PM · Mail
epriestley moved T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender from Backlog to Far Future on the Mail board.
Feb 8 2018, 5:00 PM · Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19027: Improve correctness of email address escaping in Mailgun/Postmark.
Feb 8 2018, 5:00 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19026: Let PhutilEmailAddress encode addresses with complex display names somewhat properly.
Feb 8 2018, 4:52 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19025: Configure a whitelist of remote addresses for Postmark inbound webhooks.
Feb 8 2018, 3:03 PM · Plans, Must Encrypt Mail, Mail
epriestley closed T12689: Mail is still received after resigning from a revision as Resolved by committing rP1cd3a593784a: When users resign from revisions, stop expanding projects/packages to include….
Feb 8 2018, 2:29 PM · Mail, Differential, Bug Report
epriestley closed T4776: Notify users when someone takes an action that takes them off an object's recipient list as Resolved by committing rPf214abb63f9d: When a change removes recipients from an object, send them one last email.
Feb 8 2018, 2:28 PM · Mail, Restricted Project, Transactions
epriestley closed T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place as Resolved by committing rPdbe479f0d9de: Don't send error/exception mail to unverified addresses.
Feb 8 2018, 2:26 PM · Mail, Bug Report
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 8 2018, 2:01 PM · Plans, Must Encrypt Mail, Mail
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 8 2018, 1:48 PM · Plans, Must Encrypt Mail, Mail

Feb 7 2018

epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19022: Fix an issue where some Differential edit pathways may not have reviewers attached.
Feb 7 2018, 5:42 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12689: Mail is still received after resigning from a revision: D19021: When users resign from revisions, stop expanding projects/packages to include them.
Feb 7 2018, 4:08 PM · Mail, Differential, Bug Report
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19021: When users resign from revisions, stop expanding projects/packages to include them.
Feb 7 2018, 4:08 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

See PHI178 and PHI126. See T12689. When users resign from a revision, they should not receive mail about it even if they're a member of a non-resigned package or project. This requires propagating mail recipients deeper into the stack, and retaining richer recipient information. Subscriptions should be upgraded to support a stronger "unsubscribe" which can get you out of indirect subscriptions via projects/packages/etc. These probably mostly go down the same pathway.

Feb 7 2018, 2:31 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T4776: Notify users when someone takes an action that takes them off an object's recipient list: D19019: When a change removes recipients from an object, send them one last email.
Feb 7 2018, 2:11 PM · Mail, Restricted Project, Transactions
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19019: When a change removes recipients from an object, send them one last email.
Feb 7 2018, 2:11 PM · Plans, Must Encrypt Mail, Mail
epriestley triaged T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender as Wishlist priority.
Feb 7 2018, 1:35 PM · Mail
epriestley added a revision to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place: D19018: Don't send error/exception mail to unverified addresses.
Feb 7 2018, 1:18 PM · Mail, Bug Report
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19018: Don't send error/exception mail to unverified addresses.
Feb 7 2018, 1:18 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19017: Support Postmark inbound mail via webhook.
Feb 7 2018, 1:02 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19016: Add a "View Object" button on the web mail view page.
Feb 7 2018, 12:09 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19015: In HTML mail, make the text for mail stamps in mail bodies smaller and lighter.
Feb 7 2018, 12:00 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19014: Document that disabling "metamta.one-mail-per-recipient" leaks recipients for "Must Encrypt".
Feb 7 2018, 11:52 AM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

If D19012/D19013 turn out badly this table should be <objectPHID, mailKey, firstSubjectWeSentMailWith> so there's some vague argument for waiting until those are in the wild for a little bit or naming the table in a more generic way (MailObjectMetadata instead of MailObjectKey).

Feb 7 2018, 11:47 AM · Mail
epriestley triaged T13065: Move storage for `mailKey` to the Mail application as Low priority.
Feb 7 2018, 11:42 AM · Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19013: Remove all "originalTitle"/"originalName" fields from objects.
Feb 7 2018, 11:35 AM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19012: Use object PHIDs for "Thread-Topic" headers in mail.
Feb 7 2018, 11:17 AM · Plans, Must Encrypt Mail, Mail
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 7 2018, 11:00 AM · Plans, Must Encrypt Mail, Mail

Feb 6 2018

epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19009: Add a Postmark mail adapter so it can be configured as an outbound mailer.
Feb 6 2018, 5:44 PM · Phacility, Mail
epriestley updated the task description for T12677: Support multiple mail delivery services for automatic failover.
Feb 6 2018, 5:21 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19008: Add a Postmark API client.
Feb 6 2018, 5:17 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19007: Add unit tests for mail failover behaviors when multiple mailers are configured.
Feb 6 2018, 4:43 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19007: Add unit tests for mail failover behaviors when multiple mailers are configured.
Feb 6 2018, 4:43 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19006: Add some test coverage for mailers configuration.
Feb 6 2018, 4:16 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19006: Add some test coverage for mailers configuration.
Feb 6 2018, 4:16 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19005: Use "cluster.mailers" if it is configured.
Feb 6 2018, 2:52 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19005: Use "cluster.mailers" if it is configured.
Feb 6 2018, 2:52 PM · Phacility, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19004: Add a `bin/config set <key> --stdin < value.json` flag to make CLI configuration of complex values easier.
Feb 6 2018, 2:23 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19004: Add a `bin/config set <key> --stdin < value.json` flag to make CLI configuration of complex values easier.
Feb 6 2018, 2:23 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19003: Introduce and document a new `cluster.mailers` option for configuring multiple mailers.
Feb 6 2018, 2:06 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19003: Introduce and document a new `cluster.mailers` option for configuring multiple mailers.
Feb 6 2018, 2:06 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19002: Prepare for multiple mailers of the same type.
Feb 6 2018, 1:09 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: D19002: Prepare for multiple mailers of the same type.
Feb 6 2018, 1:09 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D19000: Mask the sender for "Must Encrypt" mail.
Feb 6 2018, 12:34 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: D18999: Try running Herald when performing inverse edge edits.
Feb 6 2018, 12:19 PM · Plans, Must Encrypt Mail, Mail

Feb 5 2018

epriestley added a comment to T13053: Plans: Mail Tags and Failover.

The "From" address should also probably be anonymized for flagged mail.

Feb 5 2018, 11:59 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Who knows what the Bad People would have one if they'd intercepted it!

Feb 5 2018, 11:39 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

When an object is updated via an "inverse edge" change (normally: when it is mentioned, or when another object is linked to it) we currently do not fire Herald rules. The corresponding block in the code has this comment:

Feb 5 2018, 11:38 PM · Plans, Must Encrypt Mail, Mail