Page MenuHomePhabricator

Mask the sender for "Must Encrypt" mail
ClosedPublic

Authored by epriestley on Feb 6 2018, 12:34 PM.

Details

Summary

Depends on D18998. Ref T13053. When we send "Must Encrypt" mail, we currently send it with a normal "From" address.

This discloses a little information about the object (for example, if the Director of Silly Walks is interacting with a "must encrypt" object, the vulnerability is probably related to Silly Walks), so anonymize who is interacting with the object.

Test Plan

Processed some mail. (The actual final "From" is ephemeral and a little tricky to examine and I didn't actually transmit mail over the network, but it should be obvious if this works or not on secure.)

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 6 2018, 12:34 PM
Harbormaster completed remote builds in B19358: Diff 45565.
epriestley requested review of this revision.Feb 6 2018, 12:36 PM
amckinley accepted this revision.Feb 6 2018, 7:27 PM
This revision is now accepted and ready to land.Feb 6 2018, 7:27 PM
This revision was automatically updated to reflect the committed changes.