Differential D19028

Only add the Mail "STAMPS" body section if there are stamps
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 5:05 PM.

Tags

None

Referenced Files

	F15463732: D19028.id.diff
	Wed, Apr 2, 2:34 AM

	F15436652: D19028.diff
	Tue, Mar 25, 3:42 PM

	F15398674: D19028.diff
	Mon, Mar 17, 1:12 AM

	F15394096: D19028.id45626.diff
	Sat, Mar 15, 11:20 PM

	F15394090: D19028.id.diff
	Sat, Mar 15, 11:20 PM

	F15394084: D19028.diff
	Sat, Mar 15, 11:20 PM

	Unknown Object (File)
	Feb 23 2025, 4:18 PM

	Unknown Object (File)
	Feb 23 2025, 5:09 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13053: Plans: Mail Tags and Failover
Commits: rPa8f937d3138a: Only add the Mail "STAMPS" body section if there are stamps

Summary

Ref T13053. Some mail (like push notification mail) doesn't currently generate any stamps. Drop this section if there aren't any stamps on the mail.

Test Plan

Will check push mail in production.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 8 2018, 5:05 PM

Harbormaster completed remote builds in B19421: Diff 45626.Feb 8 2018, 5:06 PM

epriestley requested review of this revision.Feb 8 2018, 5:06 PM

epriestley added a child revision: D19029: Pass HTML bodies to push email.Feb 8 2018, 5:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:09 PM

Closed by commit rPa8f937d3138a: Only add the Mail "STAMPS" body section if there are stamps (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

replyhandler/

PhabricatorMailTarget.php

43 lines

Diff 45628

View Options

src/applications/metamta/replyhandler/PhabricatorMailTarget.php

Only add the Mail "STAMPS" body section if there are stampsClosedPublicActions