Page MenuHomePhabricator

Use "cluster.mailers" if it is configured
ClosedPublic

Authored by epriestley on Feb 6 2018, 2:52 PM.

Details

Summary

Depends on D19004. Ref T13053. Ref T12677. If the new cluster.mailers is configured, make use of it. Also use it in the Sengrid/Mailgun inbound stuff.

Also fix a bug where "Must Encrypt" mail to no recipients could fatal because no $mail was returned.

Test Plan

Processed some mail locally. The testing on this is still pretty flimsy, but I plan to solidify it in an upcoming change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
485

This works because we don't invoke validateOptions() before invoking setOptions(), right?

This revision is now accepted and ready to land.Feb 7 2018, 8:43 PM
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
485

The top-level shared stuff (key, type, priority) is a level above options. setOptions() will validate options, but "options" only has mailer-specifc stuff (api key, domain, username, etc.), not shared stuff.

This revision was automatically updated to reflect the committed changes.