Use "cluster.mailers" if it is configured
ClosedPublic
Actions

Authored by epriestley on Feb 6 2018, 2:52 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12677: Support multiple mail delivery services for automatic failover
T13053: Plans: Mail Tags and Failover

Commits

rP994d2e8e1563: Use "cluster.mailers" if it is configured

Summary

Depends on D19004. Ref T13053. Ref T12677. If the new cluster.mailers is configured, make use of it. Also use it in the Sengrid/Mailgun inbound stuff.

Also fix a bug where "Must Encrypt" mail to no recipients could fatal because no $mail was returned.

Test Plan

Processed some mail locally. The testing on this is still pretty flimsy, but I plan to solidify it in an upcoming change.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 6 2018, 2:52 PM

Harbormaster completed remote builds in B19363: Diff 45570.Feb 6 2018, 2:53 PM

epriestley requested review of this revision.Feb 6 2018, 2:53 PM

epriestley added a child revision: D19006: Add some test coverage for mailers configuration.Feb 6 2018, 4:16 PM

amckinley accepted this revision.Feb 7 2018, 8:43 PM

amckinley added inline comments.

src/applications/metamta/storage/PhabricatorMetaMTAMail.php
485	This works because we don't invoke `validateOptions()` before invoking `setOptions()`, right?

This revision is now accepted and ready to land.Feb 7 2018, 8:43 PM

epriestley added inline comments.Feb 8 2018, 2:12 PM

src/applications/metamta/storage/PhabricatorMetaMTAMail.php
485	The top-level shared stuff (key, type, priority) is a level above options. `setOptions()` will validate options, but "options" only has mailer-specifc stuff (api key, domain, username, etc.), not shared stuff.