Page MenuHomePhabricator

Remove all "originalTitle"/"originalName" fields from objects
ClosedPublic

Authored by epriestley on Feb 7 2018, 11:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 23, 5:50 PM
Unknown Object (File)
Sun, Feb 23, 12:09 PM
Unknown Object (File)
Sat, Feb 22, 1:48 PM
Unknown Object (File)
Fri, Feb 21, 3:17 PM
Unknown Object (File)
Wed, Feb 19, 6:17 AM
Unknown Object (File)
Jan 31 2025, 7:54 PM
Unknown Object (File)
Jan 28 2025, 3:14 AM
Unknown Object (File)
Jan 28 2025, 3:14 AM
Subscribers
None

Details

Summary

Depends on D19012. Ref T13053. In D19012, I've changed "Thread-Topic" to always use PHIDs.

This change drops the selective on-object storage we have to track the original, human-readable title for objects.

Even if we end up backing out the "Thread-Topic" change, we'd be better off storing this in a table in the Mail app which just has <objectPHID, first subject we used when sending mail for that object>, since then we get the right behavior without needing every object to have this separate field.

Test Plan

Grepped for original, originalName, originalTitle, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable