Page MenuHomePhabricator

Remove all "originalTitle"/"originalName" fields from objects
ClosedPublic

Authored by epriestley on Feb 7 2018, 11:35 AM.
Tags
None
Referenced Files
F14015044: D19013.diff
Sun, Nov 3, 12:34 PM
F14015043: D19013.diff
Sun, Nov 3, 12:32 PM
F14008769: D19013.diff
Wed, Oct 30, 6:37 AM
F13997843: D19013.id45609.diff
Thu, Oct 24, 6:27 AM
Unknown Object (File)
Oct 9 2024, 8:42 AM
Unknown Object (File)
Sep 21 2024, 10:03 PM
Unknown Object (File)
Sep 17 2024, 5:55 PM
Unknown Object (File)
Sep 13 2024, 5:58 AM
Subscribers
None

Details

Summary

Depends on D19012. Ref T13053. In D19012, I've changed "Thread-Topic" to always use PHIDs.

This change drops the selective on-object storage we have to track the original, human-readable title for objects.

Even if we end up backing out the "Thread-Topic" change, we'd be better off storing this in a table in the Mail app which just has <objectPHID, first subject we used when sending mail for that object>, since then we get the right behavior without needing every object to have this separate field.

Test Plan

Grepped for original, originalName, originalTitle, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable