Page MenuHomePhabricator

Remove all "originalTitle"/"originalName" fields from objects
ClosedPublic

Authored by epriestley on Feb 7 2018, 11:35 AM.
Tags
None
Referenced Files
F13345960: D19013.id45582.diff
Fri, Jun 21, 12:28 PM
F13342480: D19013.id.diff
Thu, Jun 20, 2:08 PM
F13332408: D19013.diff
Mon, Jun 17, 11:14 AM
F13325803: D19013.diff
Sat, Jun 15, 2:16 AM
F13313408: D19013.diff
Tue, Jun 11, 7:51 AM
F13300314: D19013.diff
Fri, Jun 7, 9:04 AM
F13266245: D19013.id45582.diff
Tue, May 28, 11:11 AM
F13256753: D19013.id45582.diff
Sat, May 25, 4:55 PM
Subscribers
None

Details

Summary

Depends on D19012. Ref T13053. In D19012, I've changed "Thread-Topic" to always use PHIDs.

This change drops the selective on-object storage we have to track the original, human-readable title for objects.

Even if we end up backing out the "Thread-Topic" change, we'd be better off storing this in a table in the Mail app which just has <objectPHID, first subject we used when sending mail for that object>, since then we get the right behavior without needing every object to have this separate field.

Test Plan

Grepped for original, originalName, originalTitle, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable