Page MenuHomePhabricator

Remove all "originalTitle"/"originalName" fields from objects
ClosedPublic

Authored by epriestley on Feb 7 2018, 11:35 AM.
Tags
None
Referenced Files
F13522744: D19013.diff
Fri, Jul 26, 7:25 AM
Unknown Object (File)
Sun, Jul 21, 8:59 AM
Unknown Object (File)
Wed, Jul 17, 10:01 AM
Unknown Object (File)
Tue, Jul 16, 12:03 AM
Unknown Object (File)
Sun, Jul 14, 12:10 PM
Unknown Object (File)
Sun, Jul 14, 3:33 AM
Unknown Object (File)
Sat, Jul 13, 8:06 AM
Unknown Object (File)
Mon, Jul 8, 6:44 PM
Subscribers
None

Details

Summary

Depends on D19012. Ref T13053. In D19012, I've changed "Thread-Topic" to always use PHIDs.

This change drops the selective on-object storage we have to track the original, human-readable title for objects.

Even if we end up backing out the "Thread-Topic" change, we'd be better off storing this in a table in the Mail app which just has <objectPHID, first subject we used when sending mail for that object>, since then we get the right behavior without needing every object to have this separate field.

Test Plan

Grepped for original, originalName, originalTitle, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable