Page MenuHomePhabricator

Don't send error/exception mail to unverified addresses
ClosedPublic

Authored by epriestley on Feb 7 2018, 1:18 PM.

Details

Summary

Depends on D19017. Fixes T12491. Ref T13053. After SES threw us in the dungeon for sending mail to a spamtrap we changed outbound mail rules to stop sending to unverified addresses, except a small amount of registration mail which we can't avoid.

However, we'll still reply to random inbound messages with a helpful error, even if the sender is unverified.

Instead, only send exception mail back if we know who the sender is.

Test Plan

Processed inbound mail with scripts/mail/mail_handler.php. No more outbound mail for "bad address", etc. Still got outbound mail for "unknown command !quack".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 7 2018, 1:18 PM
epriestley requested review of this revision.Feb 7 2018, 1:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 2:26 PM
This revision was automatically updated to reflect the committed changes.