Page MenuHomePhabricator

When users resign from revisions, stop expanding projects/packages to include them

Authored by epriestley on Feb 7 2018, 4:08 PM.



Depends on D19019. Ref T13053. Fixes T12689. See PHI178.

Currently, if @alice resigns from a revision but #alice-fan-club is still a subscriber or reviewer, she'll continue to get mail. This is undesirable.

When users are associated with an object but have explicitly disengaged in an individal role (currently, only resign in audit/differential) mark them "unexpandable", so that they can no longer be included through implicit membership in a group (a project or package).

@alice can still get mail if she's a explicit recipient: as an author, owner, or if she adds herself back as a subscriber.

Test Plan
  • Added @ducker and #users-named-ducker as reviewers. Ducker got mail.
  • Resigned as ducker, stopped getting future mail.
  • Subscribed explicitly, got mail again.
  • (Plus some var_dump() sanity checking in the internals.)

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 7 2018, 4:08 PM
epriestley requested review of this revision.Feb 7 2018, 4:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 2:29 PM
This revision was automatically updated to reflect the committed changes.