Page MenuHomePhabricator

When users resign from revisions, stop expanding projects/packages to include them
ClosedPublic

Authored by epriestley on Feb 7 2018, 4:08 PM.
Tags
None
Referenced Files
F14040523: D19021.diff
Mon, Nov 11, 10:51 AM
F13994297: D19021.id45616.diff
Wed, Oct 23, 5:12 AM
Unknown Object (File)
Oct 9 2024, 8:44 AM
Unknown Object (File)
Sep 27 2024, 3:12 AM
Unknown Object (File)
Sep 27 2024, 2:07 AM
Unknown Object (File)
Sep 13 2024, 6:29 AM
Unknown Object (File)
Sep 13 2024, 6:28 AM
Unknown Object (File)
Sep 13 2024, 6:27 AM
Subscribers
None

Details

Summary

Depends on D19019. Ref T13053. Fixes T12689. See PHI178.

Currently, if @alice resigns from a revision but #alice-fan-club is still a subscriber or reviewer, she'll continue to get mail. This is undesirable.

When users are associated with an object but have explicitly disengaged in an individal role (currently, only resign in audit/differential) mark them "unexpandable", so that they can no longer be included through implicit membership in a group (a project or package).

@alice can still get mail if she's a explicit recipient: as an author, owner, or if she adds herself back as a subscriber.

Test Plan
  • Added @ducker and #users-named-ducker as reviewers. Ducker got mail.
  • Resigned as ducker, stopped getting future mail.
  • Subscribed explicitly, got mail again.
  • (Plus some var_dump() sanity checking in the internals.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable