Page MenuHomePhabricator

Add an "Acting user" field to Herald
ClosedPublic

Authored by epriestley on Feb 8 2018, 5:41 PM.

Details

Summary

Ref T13053. Fixes T7804. Adds "Acting user" so you can have "always email me" stuff skip things you did or keep an eye on suspicious interns.

For the test console, the current user is the acting user.

For pushes, the pusher is the acting user.

Test Plan

Wrote acting user rules, triggered them via test console and via multiple actors on real objects.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 8 2018, 5:41 PM
epriestley requested review of this revision.Feb 8 2018, 5:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:52 PM
This revision was automatically updated to reflect the committed changes.