Page MenuHomePhabricator
Create Task
Maniphest T4776

Notify users when someone takes an action that takes them off an object's recipient list
Closed, ResolvedPublic
Actions

Description

Currently, you may not receive mail when someone, e.g., removes you as a task owner or removes you as a reviewer. We should make sure this mail is delivered.

A simple, general approach is probably:

  • Get a list of all recipients before applying changes.
  • Apply changes.
  • Get a list of all mail recipients after applying changes.
  • Send mail to the union of the two lists.

A possibly exceptional case here is users who unsubscribe themselves. We could wait for complaints or special case that.

Revisions and Commits

rP Phabricator
D19019rPf214abb63f9d When a change removes recipients from an object, send them one last email

Related Objects

Event Timeline

epriestley created this task.Apr 9 2014, 2:47 AM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added subscribers: epriestley, sophiebits.
chad added a project: Transactions.Dec 30 2014, 5:32 PM
epriestley merged a task: T7758: Send one last email to removed subscribers.Apr 4 2015, 5:46 PM
cburroughs added a subscriber: cburroughs.Apr 6 2015, 12:23 PM
johnny-bit added a subscriber: johnny-bit.Apr 6 2015, 12:58 PM
joshuaspence added a subscriber: joshuaspence.May 29 2015, 9:51 AM
epriestley mentioned this in T9031: When I ignore subscription changes, I'm not notified of being cc'ed.Aug 18 2015, 7:03 PM
aklapper added a subscriber: aklapper.Feb 13 2016, 1:20 PM
greggrossmeier added a subscriber: greggrossmeier.Feb 23 2016, 11:03 PM
eadler added a project: Restricted Project.Aug 5 2016, 5:23 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 5 2016, 5:23 PM
epriestley mentioned this in D16733: Make notification default for Conpherence.Oct 22 2016, 5:01 PM
epriestley added a project: Mail.
epriestley mentioned this in D16830: Require several advanced postgraduate degrees to understand object policies.Nov 9 2016, 9:41 PM
Twilight added a subscriber: Twilight.Jul 27 2017, 8:18 AM
Twilight added a comment.Jul 27 2017, 8:21 AM

A possibly exceptional case here is users who unsubscribe themselves. We could wait for complaints or special case that.

Wouldn't that fall under "Self Actions" in the Email Delivery preferences?

epriestley mentioned this in T13053: Plans: Mail Tags and Failover.Jan 27 2018, 9:52 PM
epriestley moved this task from Backlog to Stamps/Failover on the Mail board.Jan 27 2018, 9:56 PM
epriestley added a revision: D19019: When a change removes recipients from an object, send them one last email.Feb 7 2018, 2:11 PM
epriestley closed this task as Resolved by committing rPf214abb63f9d: When a change removes recipients from an object, send them one last email.Feb 8 2018, 2:28 PM
epriestley added a commit: rPf214abb63f9d: When a change removes recipients from an object, send them one last email.
epriestley mentioned this in T4926: When emails are sent to new people (or lists) they should contain the change description and patch.Jan 2 2019, 6:23 PM
Phabricator · Built by Phacility