Paths

Table of Contentst

Differential D19032

Render object remarkup references in a text context as "Dxxx <uri>"
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 5:50 PM.

Tags

None

Referenced Files

	F19931470: D19032.id45635.diff
	Thu, Apr 9, 10:56 PM

	F19897240: D19032.id.diff
	Sun, Mar 29, 7:04 AM

	F19895845: D19032.diff
	Sun, Mar 29, 12:09 AM

	F19842636: D19032.id45633.diff
	Mar 11 2026, 10:33 PM

	F19821586: D19032.id45635.diff
	Mar 6 2026, 11:11 PM

	F19815488: D19032.diff
	Mar 4 2026, 9:27 PM

	F19704795: D19032.diff
	Feb 11 2026, 5:30 AM

	F19704793: D19032.diff
	Feb 11 2026, 5:25 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11389: Object links merged in plain text email
Commits: rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>"

Summary

Depends on D19031. Fixes T11389. Currently, we render Dxxx in a text context (plain text email) as just a URI.

Instead, render it like Dxxx <uri>. This is more faithful to the original intent and preserves T123/T456 as two separate, usable links.

Test Plan

Wrote T123/T234 in a task, pulled mail for it with bin/mail show-outbound, saw separate clickable links.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 8 2018, 5:50 PM

Harbormaster completed remote builds in B19428: Diff 45633.Feb 8 2018, 5:51 PM

epriestley requested review of this revision.Feb 8 2018, 5:51 PM

epriestley mentioned this in T11389: Object links merged in plain text email.Feb 8 2018, 5:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:52 PM

Closed by commit rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

rule/

PhabricatorObjectRemarkupRule.php

2 lines

Diff 45635

View Options

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Render object remarkup references in a text context as "Dxxx <uri>"ClosedPublicActions