Page MenuHomePhabricator
Feed Advanced Search

May 16 2017

epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Restricted Differential Revision.
May 16 2017, 1:54 PM · Differential, Inline Comments
epriestley added a revision to T12632: Resizing a diff does not resize the keyboard focus reticle: Restricted Differential Revision.
May 16 2017, 1:54 PM · Inline Comments
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: Restricted Differential Revision.
May 16 2017, 1:47 PM · Inline Comments, Quicksand
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Restricted Differential Revision.
May 16 2017, 1:47 PM · Differential, Inline Comments
epriestley created T12717: KeyboardShortcutManager is not Quicksand-aware.
May 16 2017, 1:45 PM · Inline Comments, Quicksand
epriestley added a revision to T12634: Keyboard focus reticle is generally oblivious to the world around it: Restricted Differential Revision.
May 16 2017, 1:39 PM · Differential, Inline Comments
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Glitches to Reticle on the Inline Comments board.
May 16 2017, 1:28 PM · Inline Comments, Quicksand
epriestley closed T11093: DifferentialInlineCommentEditor retains state across Quicksand requests as Resolved.

I believe this is now resolved by the series of changes attached to T12616. In particular, D17840 introduced Quicksand-aware state to changeset lists.

May 16 2017, 1:26 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley closed T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000 as Resolved by committing Restricted Diffusion Commit.
May 16 2017, 1:20 PM · Inline Comments, Differential, Bug Report
cspeckmim added a comment to T12616: Modernize display code for inline comments.

missionstatus.jpg (500×500 px, 48 KB)

May 16 2017, 12:50 AM · Inline Comments
epriestley added a comment to T12616: Modernize display code for inline comments.

I think we're mostly in the clear, now. This stuff likely introduces some bugs beyond the (mostly minor) ones I'm aware of, but I think it's all correct enough in the substantial ways. I'm going to take a break for a bit; I may get back to it tonight and land everything or may wait until tomorrow.

May 16 2017, 12:45 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:36 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:35 AM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 16 2017, 12:35 AM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 16 2017, 12:33 AM · Inline Comments

May 15 2017

epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 15 2017, 11:49 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 15 2017, 11:30 PM · Inline Comments
epriestley changed the point value for T12715: Availability of inline "Reply" action is inconsistent from 2 to 1.
May 15 2017, 11:27 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 15 2017, 10:10 PM · Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

All of the inline comment icons got mis-aligned slightly a while ago. This is particularly visible with "Reply", I think. Note that the tooltip is centered, but the icon is too low (I think?) and too far to the right.

May 15 2017, 9:12 PM · Design, Differential, Inline Comments
chad added a comment to T12715: Availability of inline "Reply" action is inconsistent.

Really need an icon for points.

May 15 2017, 9:07 PM · Inline Comments
chad set the point value for T12715: Availability of inline "Reply" action is inconsistent to 2.
May 15 2017, 9:07 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 15 2017, 8:15 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 15 2017, 7:53 PM · Inline Comments
epriestley moved T12715: Availability of inline "Reply" action is inconsistent from Backlog to Glitches on the Inline Comments board.
May 15 2017, 7:43 PM · Inline Comments
epriestley created T12715: Availability of inline "Reply" action is inconsistent.
May 15 2017, 7:43 PM · Inline Comments

May 9 2017

epriestley added a revision to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000: Restricted Differential Revision.
May 9 2017, 9:01 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 9 2017, 9:01 PM · Inline Comments
epriestley added a comment to T12616: Modernize display code for inline comments.

I'm having a tough time picking pieces apart here so that the transition is gradual -- many of the remaining behaviors are highly connected to one another and hard to tease apart. Things feel fine up to D17846, but even D17859 breaks enough stuff that I don't feel great about it, and doesn't seem to have pushed me through things enough to emerge on the other side.

May 9 2017, 6:15 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 9 2017, 5:07 PM · Inline Comments

May 8 2017

epriestley updated the task description for T12616: Modernize display code for inline comments.
May 8 2017, 8:36 PM · Inline Comments
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 8 2017, 8:31 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 8 2017, 6:28 PM · Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

Just noting that this cat is perfect and DOES NOT need any design improvement:

May 8 2017, 6:14 PM · Design, Differential, Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 8 2017, 5:56 PM · Inline Comments
chad added a comment to T12688: Inline Comment Design Opportunities for Improvement.

hqdefault.jpg (360×480 px, 11 KB)

May 8 2017, 5:33 PM · Design, Differential, Inline Comments
chad added a comment to T12688: Inline Comment Design Opportunities for Improvement.

catroomguardian.jpg (564×600 px, 35 KB)

May 8 2017, 5:33 PM · Design, Differential, Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

Everyone loves Opportunities For Improvement!

May 8 2017, 5:33 PM · Design, Differential, Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

This stuff is probably going to churn for a bit but I'm pretty sure I'll forget about that thing if I don't write it down somewhere.

May 8 2017, 5:32 PM · Design, Differential, Inline Comments
chad added a comment to T12688: Inline Comment Design Opportunities for Improvement.

esyh8.jpg (360×480 px, 12 KB)

May 8 2017, 5:32 PM · Design, Differential, Inline Comments
epriestley added projects to T12688: Inline Comment Design Opportunities for Improvement: Differential, Design.
May 8 2017, 5:32 PM · Design, Differential, Inline Comments
epriestley triaged T12688: Inline Comment Design Opportunities for Improvement as Wishlist priority.

In View Options → Collapse File, we get into this sort of oldschool state:

May 8 2017, 5:32 PM · Design, Differential, Inline Comments
epriestley created T12688: Inline Comment Design Opportunities for Improvement.
May 8 2017, 5:30 PM · Design, Differential, Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 8 2017, 5:06 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 8 2017, 4:53 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 8 2017, 4:41 PM · Inline Comments
epriestley added a revision to T11093: DifferentialInlineCommentEditor retains state across Quicksand requests: Restricted Differential Revision.
May 8 2017, 4:01 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: Restricted Differential Revision.
May 8 2017, 4:01 PM · Inline Comments, Quicksand
epriestley added a revision to T12616: Modernize display code for inline comments: Restricted Differential Revision.
May 8 2017, 4:01 PM · Inline Comments

May 4 2017

epriestley added a comment to T12616: Modernize display code for inline comments.

Just some notes for myself:

May 4 2017, 2:25 PM · Inline Comments

May 2 2017

chad added a comment to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000.

56174329.jpg (508×914 px, 46 KB)

May 2 2017, 8:11 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000.

I'm thinking about resolving this by having three states instead:

May 2 2017, 6:48 PM · Inline Comments, Differential, Bug Report
epriestley added a project to T1591: Differential "buoyant" header has been temporarily disabled: Inline Comments.
May 2 2017, 3:03 PM · Inline Comments, Differential

Apr 24 2017

epriestley closed T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) as Resolved by committing Restricted Diffusion Commit.
Apr 24 2017, 5:24 PM · Inline Comments, Differential, Feature Request
epriestley moved T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Customer Impact, Differential
epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Differential
epriestley moved T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Differential
epriestley moved T11093: DifferentialInlineCommentEditor retains state across Quicksand requests from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley moved T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Restricted Project, Differential
epriestley moved T9269: Undoing multiple inline comments on the same line will restore the comment out of position. from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:32 AM · Inline Comments, Differential
epriestley moved T10563: Inline comments displayed on the same line are shown in creation order without regard for threading from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:32 AM · Inline Comments, Differential, Restricted Project
epriestley added a comment to T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff.

This reproduces for me at HEAD:

Apr 24 2017, 10:32 AM · Inline Comments, Differential
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Backlog to Glitches on the Inline Comments board.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

The keyboard reticle probably has the same issue but we can figure that out later.

Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley removed a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley removed a subtask for T12634: Keyboard focus reticle is generally oblivious to the world around it: T8047: Differential inline reticle can persist across Quicksand navigations.
Apr 24 2017, 10:30 AM · Differential, Inline Comments
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

Oh, this actually is the inline reticle, not the keyboard reticle.

Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a subtask for T12634: Keyboard focus reticle is generally oblivious to the world around it: T8047: Differential inline reticle can persist across Quicksand navigations.
Apr 24 2017, 10:29 AM · Differential, Inline Comments
epriestley added a project to T8047: Differential inline reticle can persist across Quicksand navigations: Inline Comments.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a parent task for T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential
epriestley added a parent task for T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments
epriestley added a parent task for T12632: Resizing a diff does not resize the keyboard focus reticle: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments
epriestley added a parent task for T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential, Bug Report
epriestley added a parent task for T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential
epriestley added subtasks for T12634: Keyboard focus reticle is generally oblivious to the world around it: T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle, T12632: Resizing a diff does not resize the keyboard focus reticle, T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset, T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it, T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.
Apr 24 2017, 10:27 AM · Differential, Inline Comments
epriestley created T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:26 AM · Differential, Inline Comments
epriestley moved T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley renamed T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Toggling File Browser on Differential while creating inline comment causes line highlight to offset to Toggling File Browser on Differential while creating inline comment causes keyboard focus reticle to offset.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley moved T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley added a revision to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?): Restricted Differential Revision.
Apr 24 2017, 10:21 AM · Inline Comments, Differential, Feature Request
epriestley created T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle.
Apr 24 2017, 10:18 AM · Inline Comments
epriestley created T12632: Resizing a diff does not resize the keyboard focus reticle.
Apr 24 2017, 10:17 AM · Inline Comments
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

Oh, the highlight itself actually is a little off if the reply is threaded. We move the comment up a little bit to make it visually thread a little more cleanly, but the highlight doesn't get a corresponding offset.

Apr 24 2017, 10:13 AM · Inline Comments, Differential, Bug Report
epriestley added a comment to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).

I'm going to try putting this on top of everything and using pointer-events: none to fix all the attendant click/hover/select issues.

Apr 24 2017, 10:09 AM · Inline Comments, Differential, Feature Request
epriestley moved T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:05 AM · Inline Comments, Differential, Feature Request
epriestley moved T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:05 AM · Inline Comments, Differential, Bug Report
epriestley renamed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Inline comment highlight is slightly misaligned to Jumping to an inline comment via URL anchor should highlight it with the keyboard focus reticle.
Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report
epriestley triaged T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Low priority.
Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

There are three different highlights at play here, visible in this screenshot:

Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report

Apr 21 2017

epriestley added a comment to T12616: Modernize display code for inline comments.

On mobile, I'd probably just keep this element in a fixed position on the page

Apr 21 2017, 12:47 PM · Inline Comments
epriestley updated subscribers of T12616: Modernize display code for inline comments.

@chad, some design stuff I'm thinking for later on, about in case you have feedback/ideas/objections:

Apr 21 2017, 12:45 PM · Inline Comments
epriestley added a project to T8250: Would like to see all comments and their status in a list: Inline Comments.
Apr 21 2017, 12:31 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley created T12616: Modernize display code for inline comments.
Apr 21 2017, 12:30 PM · Inline Comments
epriestley moved T802: "43 ↗" etc comments should link to the comment on the left side of the screen. from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T1026: Request: ability to select line range for comment via touchscreen from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T5030: Improve behavior when jumping to inline comments from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Restricted Project, Differential
epriestley moved T7682: JS Errors when mousing over image diff comments, right side only from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential