Page MenuHomePhabricator
Feed Advanced Search

Mar 31 2019

epriestley archived Dashboards (v2).
Mar 31 2019, 9:56 PM

Mar 27 2019

epriestley added a comment to T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel.

I believe D20336 fixes the primary practical issue here, by adding a "View All Results" button to the bottom of query panels (including query panels inside tab panels), when there are more results:

Mar 27 2019, 5:47 PM · Dashboards
epriestley renamed T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel from Link to full query from tabbed dashboard panels to Header buttons on dashboard panels are lost when panels are embedded in a tab panel.
Mar 27 2019, 5:45 PM · Dashboards
epriestley added a revision to T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel: D20336: When query panels have more results, show a "View All Results" button at the bottom.
Mar 27 2019, 5:43 PM · Dashboards

Apr 21 2017

chad closed T10390: Dashboards v2 (UX) as Resolved.
Apr 21 2017, 4:33 AM · Dashboards (v2)

Apr 7 2017

epriestley merged T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...' into T8033: Inform editor when panels have more restrictive policy than dashboard.
Apr 7 2017, 12:47 PM · Dashboards

Mar 23 2017

chad closed T9363: improve handling of panels that do not always return results as Resolved by committing rP2707681b48a2: Restrict Audit buckets to just ApplicationSearch views.
Mar 23 2017, 7:46 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
chad added a revision to T9363: improve handling of panels that do not always return results: D17545: Restrict Audit buckets to just ApplicationSearch views.
Mar 23 2017, 7:19 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
chad added a comment to T9363: improve handling of panels that do not always return results.

👍🏼

Mar 23 2017, 7:07 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
chad added a project to T9363: improve handling of panels that do not always return results: Dashboards (v2).
Mar 23 2017, 7:07 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project

Mar 22 2017

chad added a revision to T10390: Dashboards v2 (UX): D17529: Remove "Add Existing Panel" from dashboard arrange view.
Mar 22 2017, 2:08 AM · Dashboards (v2)
chad closed T12174: Home Menu Errata as Resolved.

I think most everything here is complete and will file individual follow up tasks if needed.

Mar 22 2017, 12:48 AM · Dashboards (v2), Profile Menu Item

Mar 21 2017

epriestley added a comment to T10390: Dashboards v2 (UX).

extra-thinking.jpg (512×512 px, 6 KB)

Mar 21 2017, 10:47 PM · Dashboards (v2)
chad added a comment to T10390: Dashboards v2 (UX).

thinking-face.png (256×256 px, 53 KB)

Mar 21 2017, 9:17 PM · Dashboards (v2)
epriestley added a comment to T10390: Dashboards v2 (UX).

(And it's easier to build query panels.)

Mar 21 2017, 7:17 PM · Dashboards (v2)
epriestley added a comment to T10390: Dashboards v2 (UX).

I'm fine with getting rid of the template, I think it's much less relevant now that home is no longer a single dashboard.

Mar 21 2017, 7:17 PM · Dashboards (v2)
chad added a revision to T10390: Dashboards v2 (UX): D17528: Provide a 'no dashboards' fallback state if you can't add any.
Mar 21 2017, 6:28 PM · Dashboards (v2)
chad added a revision to T10390: Dashboards v2 (UX): D17527: Add Dashboards as a default pinned application.
Mar 21 2017, 5:41 PM · Dashboards (v2)
chad added a comment to T10390: Dashboards v2 (UX).

Wondering if we should get rid of "template dashboard".

Mar 21 2017, 5:40 PM · Dashboards (v2)
chad added a revision to T10390: Dashboards v2 (UX): D17526: Add some new Dashboard icons.
Mar 21 2017, 5:13 PM · Dashboards (v2)
chad added a revision to T10390: Dashboards v2 (UX): D17524: Allow searching Dashboards by Editable.
Mar 21 2017, 2:51 AM · Dashboards (v2)
chad closed T5307: UX for taking actions with search results as Resolved.
Mar 21 2017, 2:13 AM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
chad added a revision to T5307: UX for taking actions with search results: D17523: Try to guess a name for the 'Add to Dashboard' workflow.
Mar 21 2017, 12:31 AM · Restricted Project, Dashboards (v2), ApplicationEditor, Design

Mar 20 2017

epriestley added a comment to T5307: UX for taking actions with search results.

Mine's fine here, too:

Mar 20 2017, 10:11 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
chad added a comment to T5307: UX for taking actions with search results.

Only 5? I expected more.

Mar 20 2017, 10:11 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
chad added a comment to T5307: UX for taking actions with search results.

pasted_file (526×1 px, 92 KB)

Mar 20 2017, 10:10 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
chad added a revision to T5307: UX for taking actions with search results: D17521: Fix 'Add to Dashboard' issue with builtins.
Mar 20 2017, 10:05 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
chad added a revision to T5307: UX for taking actions with search results: D17520: Add better error checking to 'Add to Dashboard'.
Mar 20 2017, 9:47 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
chad added a revision to T5307: UX for taking actions with search results: D17516: Add an action to adding Panels from ApplicationSearch.
Mar 20 2017, 7:39 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design

Mar 17 2017

chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

I imagine Facts will have similar workflows. The easier we can make it, the less worried I am about re-using panels.

Mar 17 2017, 10:04 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Yep, that's what I'm thinking too.

Mar 17 2017, 10:04 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Yeah, and the sane version (add to dashboard, not to tab panel) is probably not too awful and won't really make fixing T8033 any harder.

Mar 17 2017, 10:04 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

I want it to work like like installing to home does basically, see query, click add, confirm, get take to arrange with the panel built and added.

Mar 17 2017, 10:04 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Yeah maybe I should optimize that workflow first, seems higher leveredged. T5307

Mar 17 2017, 10:03 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Getting rid of all "Select Existing Panel" flows also makes simplifying the "Run a query -> turn it into a panel -> put it on a dashboard" workflow a bit more of a mess, especially if we want to try to do "run a query -> turn it into a panel -> add it to a tab panel". But I think in the long term making the T8033 problem impossible and then trying to do our best with the "query -> panel -> dashboard" flow is the best bet.

Mar 17 2017, 10:00 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

frickin' tab panels make everything 10x harder.

Mar 17 2017, 9:53 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

As long as you're selecting existing panels in any interface, we're stuck with the problem in T8033. I think we can only fix that elegantly by removing all interfaces where you select panels, and replacing them with interfaces where you create panels.

Mar 17 2017, 9:52 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Or maybe icons... everyone loves icons.

Mar 17 2017, 9:49 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

If I add "short name" as an optional Panel field, I could get rid of naming tabs. Then you just have to select a bunch of panels.

Mar 17 2017, 9:48 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

The change I imagined there was:

Mar 17 2017, 9:44 PM · Dashboards
epriestley added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

If we make the permission changes discussed elsewhere (T8033, I think?), this might just become something like a containerPHID which points at a Dashboard for panels created from dashboards, another Panel for panels embedded in panels, and null for standalone panels.

Mar 17 2017, 9:41 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

Oh I see above you mention using edges too.

Mar 17 2017, 7:47 PM · Dashboards
chad added a comment to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".

I don't think there is much value here in having "appears on", since panels work on dashboards, other panels, or any remarkup, anywhere. Does anyone have a good reason to keep this function? I could create an edge for panel -> panel if we want to keep something like this. But I'm concerned if the point is to "prune" panels, then we'd need to maybe build out mentions as well.

Mar 17 2017, 7:46 PM · Dashboards

Mar 15 2017

chad closed T12264: Install Dashboard to Home / Favorites / Project as Resolved.

Resolved enough, unclear any benefit to installing to Favorites and Projects needs additional work to make it truly useful.

Mar 15 2017, 6:17 PM · Profile Menu Item, Dashboards (v2)

Mar 14 2017

chad added a revision to T10390: Dashboards v2 (UX): D17492: Basic "Install Dashboard" workflow.
Mar 14 2017, 11:36 PM · Dashboards (v2)
chad merged T12396: Define custom sort order for panel results. into T5307: UX for taking actions with search results.
Mar 14 2017, 1:49 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
mpadourek added a comment to T4883: Customizing the default homepage for all users.

Ahh that did the trick - thanks.

Mar 14 2017, 9:14 AM · Dashboards (v2)

Mar 13 2017

chad added a comment to T4883: Customizing the default homepage for all users.

For now, "Edit Menu" on your home, click "Global" and add the Dashboard. "Default" is the topmost dashboard. You can disable "Home" then. This will be easier after D17492 lands.

Mar 13 2017, 6:48 PM · Dashboards (v2)
mpadourek added a comment to T4883: Customizing the default homepage for all users.

How exactly is this currently possible? I am trying to change the default homepage for all users but not managing to do that. Have tried creating a Dashboard, but not sure how I can use that to 'replace' the homepage for everyone.

Mar 13 2017, 6:12 PM · Dashboards (v2)

Mar 12 2017

chad added a revision to T12264: Install Dashboard to Home / Favorites / Project: D17492: Basic "Install Dashboard" workflow.
Mar 12 2017, 5:13 AM · Profile Menu Item, Dashboards (v2)

Mar 2 2017

urzds added a comment to T12174: Home Menu Errata.
In T12174#213854, @chad wrote:

It's not hard to add, just curious what the use case is. Most requests have been to "rename" the applications (Differential -> Code Review"), so pulling in built-in tooltips didn't make sense. Maybe we should add tooltip to the "Link" menu type for best flexibility.

Mar 2 2017, 12:44 PM · Dashboards (v2), Profile Menu Item

Mar 1 2017

rphl added a comment to T12174: Home Menu Errata.

thanks for the hint

Mar 1 2017, 10:50 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

Though I guess we need the icon typeahead there.

Mar 1 2017, 10:48 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

Alternatively, use "Link" and make whatever you want.

Mar 1 2017, 10:48 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

That's the default behavior, and you can achieve it by deleting "Name":

Mar 1 2017, 10:47 PM · Dashboards (v2), Profile Menu Item
rphl added a comment to T12174: Home Menu Errata.

It would be nice if we could have tooltips for Apps, etc. too

Mar 1 2017, 10:45 PM · Dashboards (v2), Profile Menu Item
chad merged T12339: Dashboard show odd header at the bottom of the screen into T12174: Home Menu Errata.
Mar 1 2017, 10:32 PM · Dashboards (v2), Profile Menu Item
chad updated the task description for T12174: Home Menu Errata.
Mar 1 2017, 10:32 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

You can now add tooltips adhoc to "Link" menu items.

Mar 1 2017, 7:58 PM · Dashboards (v2), Profile Menu Item
chad added a revision to T12174: Home Menu Errata: D17437: Add a tooltip option to Link menu items.
Mar 1 2017, 7:07 PM · Dashboards (v2), Profile Menu Item
cspeckmim added a comment to T12174: Home Menu Errata.

Add catfacts tooltip to each application?

Mar 1 2017, 3:38 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

It's not hard to add, just curious what the use case is. Most requests have been to "rename" the applications (Differential -> Code Review"), so pulling in built-in tooltips didn't make sense. Maybe we should add tooltip to the "Link" menu type for best flexibility.

Mar 1 2017, 3:37 PM · Dashboards (v2), Profile Menu Item
urzds added a comment to T12174: Home Menu Errata.
In T12174#213852, @chad wrote:

That's expected. When you customize the name, the built-in data (name, tooltip) goes away.

Mar 1 2017, 3:35 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

That's expected. When you customize the name, the built-in data (name, tooltip) goes away.

Mar 1 2017, 3:21 PM · Dashboards (v2), Profile Menu Item
urzds added a comment to T12174: Home Menu Errata.

I just noticed that that tooltips behave unexpectedly for application entries in the menu: When the application has no "Name", the default name is displayed as well as a tooltip on mouse-over. When I set a custom "Name", only that name is displayed and the tooltip is no longer displayed.

Mar 1 2017, 3:19 PM · Dashboards (v2), Profile Menu Item

Feb 23 2017

chad updated the task description for T10390: Dashboards v2 (UX).
Feb 23 2017, 3:21 AM · Dashboards (v2)

Feb 22 2017

chad added a revision to T10390: Dashboards v2 (UX): D17393: Simplify dashboard panel creation.
Feb 22 2017, 12:34 AM · Dashboards (v2)

Feb 19 2017

cspeckmim added a comment to T12174: Home Menu Errata.

Just tested this out with having global menu items of Create Task forms and Projects, each which are only visible based on some policy - looks to not have any issues hiding/showing based on those policies. Thanks for all this, when I get these changes into production install I'll check for feedback but I'm anticipating it will be a smoother experience for everyone.

Feb 19 2017, 5:18 PM · Dashboards (v2), Profile Menu Item

Feb 15 2017

chad closed T10473: Dashboard panel tab transactions are illegible as Resolved by committing rP2f69cb5fe75a: Add more transation data to panel tab changes.
Feb 15 2017, 7:05 PM · Dashboards (v2), Bug Report
chad added a revision to T10473: Dashboard panel tab transactions are illegible: D17359: Add more transation data to panel tab changes.
Feb 15 2017, 6:46 PM · Dashboards (v2), Bug Report
chad triaged T8033: Inform editor when panels have more restrictive policy than dashboard as Normal priority.
Feb 15 2017, 2:14 AM · Dashboards
chad closed T12207: Sort out the great Dashboard column editing mess as Resolved.
Feb 15 2017, 2:14 AM · Dashboards (v2)
chad added a comment to T12207: Sort out the great Dashboard column editing mess.

Gonna just close this since I don't think the issues were really that great and I got most of the major bugs this week. I'll pick away at some of the others.

Feb 15 2017, 2:14 AM · Dashboards (v2)

Feb 14 2017

chad created T12264: Install Dashboard to Home / Favorites / Project.
Feb 14 2017, 10:28 PM · Profile Menu Item, Dashboards (v2)
chad closed T12248: You can drag out a tab panel for some reason in dashboard arrange, a subtask of T12207: Sort out the great Dashboard column editing mess, as Resolved.
Feb 14 2017, 10:16 PM · Dashboards (v2)
chad closed T12248: You can drag out a tab panel for some reason in dashboard arrange as Resolved by committing rP37ac0ada178c: Restrict movable panels to non-tab panels.
Feb 14 2017, 10:16 PM · Dashboards (v2)
chad added a revision to T12248: You can drag out a tab panel for some reason in dashboard arrange: D17356: Restrict movable panels to non-tab panels.
Feb 14 2017, 10:11 PM · Dashboards (v2)
chad closed T11449: Selecting tabs for a Dashboard tab panel uses a plain <select /> which is a big mess as Resolved by committing rPb28b2b8ab87c: Use typeahead for tab panel selection.
Feb 14 2017, 9:43 PM · Dashboards (v2), Feature Request
chad added a revision to T11449: Selecting tabs for a Dashboard tab panel uses a plain <select /> which is a big mess: D17355: Use typeahead for tab panel selection.
Feb 14 2017, 9:34 PM · Dashboards (v2), Feature Request
chad claimed T11449: Selecting tabs for a Dashboard tab panel uses a plain <select /> which is a big mess.
Feb 14 2017, 7:02 PM · Dashboards (v2), Feature Request
chad closed T10145: Adding a panel to a dashboard multiple times, a subtask of T12207: Sort out the great Dashboard column editing mess, as Resolved.
Feb 14 2017, 3:24 PM · Dashboards (v2)
chad closed T10145: Adding a panel to a dashboard multiple times as Resolved by committing rP5556f0e45a52: Don't allow duplicate panels on dashboards.
Feb 14 2017, 3:24 PM · Dashboards (v2), Bug Report
chad added a revision to T10145: Adding a panel to a dashboard multiple times: D17351: Don't allow duplicate panels on dashboards.
Feb 14 2017, 4:34 AM · Dashboards (v2), Bug Report
chad claimed T10145: Adding a panel to a dashboard multiple times.
Feb 14 2017, 3:46 AM · Dashboards (v2), Bug Report
chad added a comment to T10145: Adding a panel to a dashboard multiple times.

I presume there is no logical need to add the same panel twice to a dashboard.

Feb 14 2017, 3:45 AM · Dashboards (v2), Bug Report
chad closed T10612: Editing a panel causes it to duplicate in dashboard as Resolved by committing rP1cb924ce68ba: Fix duplicating panel when editing in column 2.
Feb 14 2017, 2:52 AM · Dashboards (v2), Bug Report
chad closed T10612: Editing a panel causes it to duplicate in dashboard, a subtask of T12207: Sort out the great Dashboard column editing mess, as Resolved.
Feb 14 2017, 2:52 AM · Dashboards (v2)
chad added a revision to T10612: Editing a panel causes it to duplicate in dashboard: D17349: Fix duplicating panel when editing in column 2.
Feb 14 2017, 2:34 AM · Dashboards (v2), Bug Report
chad added a revision to T10390: Dashboards v2 (UX): D17348: Make Panels slightly easier to find and use.
Feb 14 2017, 12:33 AM · Dashboards (v2)
chad claimed T10390: Dashboards v2 (UX).
Feb 14 2017, 12:30 AM · Dashboards (v2)
chad triaged T10390: Dashboards v2 (UX) as High priority.
Feb 14 2017, 12:29 AM · Dashboards (v2)

Feb 13 2017

chad closed T4984: Improve design of dashboard browse list? as Resolved by committing rP5a850ab23525: Add more information to Dashboard ApplicationSearch list.
Feb 13 2017, 3:24 PM · Dashboards (v2), Design

Feb 12 2017

chad added a revision to T10390: Dashboards v2 (UX): D17341: Reduce application search engine results list for Dashboards.
Feb 12 2017, 6:11 AM · Dashboards (v2)
chad created T12248: You can drag out a tab panel for some reason in dashboard arrange.
Feb 12 2017, 4:42 AM · Dashboards (v2)
chad added a revision to T4984: Improve design of dashboard browse list?: D17340: Add more information to Dashboard ApplicationSearch list.
Feb 12 2017, 3:49 AM · Dashboards (v2), Design

Feb 11 2017

chad renamed T10390: Dashboards v2 (UX) from Dashboards v2 (Home + Usability) to Dashboards v2 (UX).
Feb 11 2017, 6:45 PM · Dashboards (v2)
chad updated the task description for T10390: Dashboards v2 (UX).
Feb 11 2017, 6:45 PM · Dashboards (v2)
chad added a revision to T10390: Dashboards v2 (UX): D17338: Remove Copy Dashboard.
Feb 11 2017, 6:14 PM · Dashboards (v2)
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

hiding policy controls when creating panels in context of the Arrange Panels page seems like a good way to minimize this

Feb 11 2017, 3:15 PM · Dashboards
chad added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

I'm hoping to make panel creation dramatically simpler, so building a new dashboard from scratch is maybe a 1-2 minute task. Getting rid of copy and maybe also hiding policy controls when creating panels in context of the Arrange Panels page seems like a good way to minimize this.

Feb 11 2017, 3:02 PM · Dashboards