Page MenuHomePhabricator
Differential D17349

Fix duplicating panel when editing in column 2
ClosedPublic
Actions

Authored by chad on Feb 14 2017, 2:34 AM.
Tags
None
Referenced Files
F14753617: D17349.id41722.diff
Tue, Jan 21, 3:15 PM
F14749281: D17349.diff
Tue, Jan 21, 11:13 AM
Unknown Object (File)
Mon, Jan 20, 10:06 AM
Unknown Object (File)
Sun, Jan 12, 8:53 PM
Unknown Object (File)
Thu, Jan 9, 12:15 PM
Unknown Object (File)
Tue, Jan 7, 2:20 PM
Unknown Object (File)
Fri, Jan 3, 7:12 PM
Unknown Object (File)
Thu, Jan 2, 4:35 PM
View All Files
Subscribers
Korvin
Tokens
"Mountain of Wealth" token, awarded by allixsenos."Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T10612: Editing a panel causes it to duplicate in dashboard
Commits
rP1cb924ce68ba: Fix duplicating panel when editing in column 2
Summary

Fixes T10612. We're writing a new panel to any dashboard even if it already exists. No need when just updating a panel title.

Test Plan

Add "welcome" panel to column 2 of a clean dashboard. Edit title, save. See correct panel in correct place.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
controller/
2 lines

Diff 41723

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
Phabricator · Built by Phacility