Fix duplicating panel when editing in column 2
ClosedPublic
Actions

Authored by chad on Feb 14 2017, 2:34 AM.

Tags

None

Referenced Files

	F18084697: D17349.id41722.diff
	Tue, Aug 5, 4:58 PM

	F18081217: D17349.id41723.diff
	Mon, Aug 4, 11:03 PM

	F17944436: D17349.diff
	Thu, Jul 31, 10:05 AM

	F17905165: D17349.id.diff
	Tue, Jul 29, 11:52 AM

	F17702943: D17349.diff
	Wed, Jul 16, 12:07 AM

	Unknown Object (File)
	May 29 2025, 9:03 AM

	Unknown Object (File)
	May 25 2025, 10:19 PM

	Unknown Object (File)
	May 24 2025, 4:17 PM

View All Files

Subscribers

Korvin

Tokens

"Mountain of Wealth" token, awarded by allixsenos."Haypence" token, awarded by epriestley.

Details

Reviewers

epriestley

Maniphest Tasks

T10612: Editing a panel causes it to duplicate in dashboard

Commits

rP1cb924ce68ba: Fix duplicating panel when editing in column 2

Summary

Fixes T10612. We're writing a new panel to any dashboard even if it already exists. No need when just updating a panel title.

Test Plan

Add "welcome" panel to column 2 of a clean dashboard. Edit title, save. See correct panel in correct place.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 14 2017, 2:34 AM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 14 2017, 2:34 AM

Harbormaster completed remote builds in B15621: Diff 41722.Feb 14 2017, 2:35 AM

Nice find! 🌵

This revision is now accepted and ready to land.Feb 14 2017, 2:38 AM

epriestley awarded a token.Feb 14 2017, 2:38 AM

Closed by commit rP1cb924ce68ba: Fix duplicating panel when editing in column 2 (authored by chad, committed by chad). · Explain WhyFeb 14 2017, 2:52 AM

This revision was automatically updated to reflect the committed changes.

allixsenos awarded a token.Feb 14 2017, 10:27 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardPanelEditController.php

2 lines

Diff 41723

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Fix duplicating panel when editing in column 2ClosedPublicActions