Don't allow duplicate panels on dashboards
ClosedPublic

Authored by chad on Tue, Feb 14, 4:34 AM.

Details

Summary

Fixes T10145. I went with "don't add two panels", since panels are easy to create, I expect this to be a reasonable limit until we have better use cases.

Test Plan

Try to add the same panel twice, get error. Add panel normally fine, move panels fine, edit panels fine.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chad created this revision.Tue, Feb 14, 4:34 AM
epriestley accepted this revision.Tue, Feb 14, 12:02 PM

Cool. I think this is a good approach, at least for the foreseeable future: the use cases right now definitely feel pretty weak to me too.

This revision is now accepted and ready to land.Tue, Feb 14, 12:02 PM
This revision was automatically updated to reflect the committed changes.