Add more transation data to panel tab changes
ClosedPublic

Authored by chad on Wed, Feb 15, 6:46 PM.

Details

Summary

Fixes T10473. Clever, didn't know we could do this, but works well. Renders out the tab names by ', '.

Test Plan

Add a tab panel, change some names, review transactions.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chad created this revision.Wed, Feb 15, 6:46 PM
chad updated this revision to Diff 41746.Wed, Feb 15, 6:49 PM
  • more clarity
chad edited the test plan for this revision. (Show Details)Wed, Feb 15, 6:51 PM
epriestley accepted this revision.Wed, Feb 15, 6:56 PM

Probably ambiguous when tab names have quotes and commas in them, but clearly better than what we do now.

This revision is now accepted and ready to land.Wed, Feb 15, 6:56 PM
chad added a comment.Wed, Feb 15, 7:00 PM

I think I'd have to query panel names from the DB to make this more better, unsure if I can do that in transactions?

chad added a comment.Wed, Feb 15, 7:01 PM

Maybe build monograms.

It's correct to use the values on the transaction because the tabs may have changed name again after the transaction happened. If you rename "A" to "B", the old transactions should still say "Added panel A; Renamed A to B." (except that the rename is on some other object, I guess).

When this swaps to ModularTransactions there's some new rendering stuff that applies the italic style like in Differential, but not worth trying to tweak until then.

This revision was automatically updated to reflect the committed changes.