Fixes T10473. Clever, didn't know we could do this, but works well. Renders out the tab names by ', '.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T10473: Dashboard panel tab transactions are illegible
- Commits
- rP2f69cb5fe75a: Add more transation data to panel tab changes
Add a tab panel, change some names, review transactions.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Probably ambiguous when tab names have quotes and commas in them, but clearly better than what we do now.
Comment Actions
I think I'd have to query panel names from the DB to make this more better, unsure if I can do that in transactions?
Comment Actions
It's correct to use the values on the transaction because the tabs may have changed name again after the transaction happened. If you rename "A" to "B", the old transactions should still say "Added panel A; Renamed A to B." (except that the rename is on some other object, I guess).
When this swaps to ModularTransactions there's some new rendering stuff that applies the italic style like in Differential, but not worth trying to tweak until then.