Page MenuHomePhabricator

Reduce application search engine results list for Dashboards
ClosedPublic

Authored by chad on Feb 12 2017, 6:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 3, 5:45 PM
Unknown Object (File)
Sun, Jul 3, 5:45 PM
Unknown Object (File)
Sun, Jul 3, 5:45 PM
Unknown Object (File)
Sun, Jul 3, 5:45 PM
Unknown Object (File)
Sat, Jul 2, 12:02 AM
Unknown Object (File)
Thu, Jun 30, 10:49 PM
Unknown Object (File)
Fri, Jun 24, 10:14 AM
Unknown Object (File)
Thu, Jun 23, 9:27 PM
Subscribers

Details

Summary

Ref T10390. Simplifies dropdown by rolling out canUseInPanel in useless panels

Test Plan

Add a query panel, see less options.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley edited reviewers, added: chad; removed: epriestley.
epriestley edited edge metadata.

Generally seems sane, I'll write some javascript. 😿

It's probably possible to build this into one mega-typeahead too. I just was unsure how that would feel.

chad removed a reviewer: chad.

I think I'm just going to build this into a single typeahead and remove the javascript. That should make tab panel creation simple also.

chad retitled this revision from Build a Typeahead for panel-ready application search engines to Reduce application search engine results list for Dashboards.Feb 22 2017, 5:19 PM
chad edited the summary of this revision. (Show Details)
chad edited the test plan for this revision. (Show Details)
  • filter out a few more useless ones

I reduced this diff down to just canUseInPanelContext changes -- along with better descriptions.

This revision is now accepted and ready to land.Feb 22 2017, 8:23 PM
This revision was automatically updated to reflect the committed changes.