Page MenuHomePhabricator
Differential D17341

Reduce application search engine results list for Dashboards
ClosedPublic
Actions

Authored by chad on Feb 12 2017, 6:11 AM.
Tags
None
Referenced Files
F18869145: D17341.id.diff
Tue, Nov 4, 10:04 AM
F18868921: D17341.id41701.diff
Tue, Nov 4, 9:16 AM
F18866304: D17341.diff
Mon, Nov 3, 4:31 PM
F18854898: D17341.diff
Sat, Nov 1, 12:48 AM
F18818943: D17341.id.diff
Wed, Oct 22, 3:27 AM
F18815685: D17341.diff
Tue, Oct 21, 3:12 AM
F18813904: D17341.id41828.diff
Mon, Oct 20, 7:47 PM
F18773285: D17341.id.diff
Thu, Oct 9, 8:44 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10390: Dashboards v2 (UX)
Commits
rPbf44210dc8f1: Reduce application search engine results list for Dashboards
Summary

Ref T10390. Simplifies dropdown by rolling out canUseInPanel in useless panels

Test Plan

Add a query panel, see less options.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Feb 12 2017, 6:11 AM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 12 2017, 6:11 AM
Harbormaster completed remote builds in B15598: Diff 41701.Feb 12 2017, 6:12 AM
chad edited the test plan for this revision. (Show Details)Feb 12 2017, 6:13 AM
epriestley commandeered this revision.Feb 13 2017, 2:31 PM
epriestley edited reviewers, added: chad; removed: epriestley.
epriestley edited edge metadata.

Generally seems sane, I'll write some javascript. 😿

Harbormaster completed remote builds in B15598: Diff 41701.Feb 13 2017, 2:32 PM
chad edited edge metadata.Feb 13 2017, 2:39 PM

It's probably possible to build this into one mega-typeahead too. I just was unsure how that would feel.

chad commandeered this revision.Feb 22 2017, 1:39 AM
chad removed a reviewer: chad.

I think I'm just going to build this into a single typeahead and remove the javascript. That should make tab panel creation simple also.

Harbormaster completed remote builds in B15598: Diff 41701.Feb 22 2017, 1:40 AM
chad retitled this revision from Build a Typeahead for panel-ready application search engines to Reduce application search engine results list for Dashboards.Feb 22 2017, 5:19 PM
chad edited the summary of this revision. (Show Details)
chad edited the test plan for this revision. (Show Details)
chad updated this revision to Diff 41824.Feb 22 2017, 5:27 PM
  • filter out a few more useless ones
chad added a comment.Feb 22 2017, 5:28 PM

I reduced this diff down to just canUseInPanelContext changes -- along with better descriptions.

Harbormaster completed remote builds in B15721: Diff 41824.Feb 22 2017, 5:28 PM
epriestley accepted this revision.Feb 22 2017, 8:23 PM
This revision is now accepted and ready to land.Feb 22 2017, 8:23 PM
Closed by commit rPbf44210dc8f1: Reduce application search engine results list for Dashboards (authored by chad, committed by chad). · Explain WhyFeb 22 2017, 8:42 PM
This revision was automatically updated to reflect the committed changes.
ivo mentioned this in T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.Feb 27 2017, 6:05 PM

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
query/
2 lines
auth/
query/
6 lines
badges/
query/
2 lines
calendar/
query/
4 lines
4 lines
4 lines
conduit/
query/
4 lines
4 lines
conpherence/
query/
2 lines
dashboard/
query/
4 lines
4 lines
diviner/
query/
4 lines
files/
query/
4 lines
herald/
query/
4 lines
maniphest/
query/
2 lines
metamta/
query/
4 lines
oauthserver/
query/
4 lines
owners/
query/
4 lines
packages/
query/
4 lines
4 lines
4 lines
phrequent/
query/
5 lines
phurl/
query/
2 lines
project/
query/
5 lines
releeph/
query/
4 lines
4 lines
4 lines
search/
query/
4 lines
transactions/
query/
4 lines
infrastructure/
daemon/
workers/
query/
6 lines

Diff 41828

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php

Loading...
View Options

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Loading...
View Options

src/applications/diviner/query/DivinerAtomSearchEngine.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptSearchEngine.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

Loading...
View Options

src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php

Loading...
View Options

src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php

Loading...
View Options

src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php

Loading...
View Options

src/applications/phrequent/query/PhrequentSearchEngine.php

Loading...
View Options

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectColumnSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephBranchSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephProductSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestSearchEngine.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php

Loading...
View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php

Loading...
Phabricator · Built by Phacility