Page MenuHomePhabricator
Differential D17545

Restrict Audit buckets to just ApplicationSearch views
ClosedPublic
Actions

Authored by chad on Mar 23 2017, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 1:15 PM
Unknown Object (File)
Sat, Nov 9, 1:15 PM
Unknown Object (File)
Sat, Nov 9, 1:15 PM
Unknown Object (File)
Tue, Nov 5, 11:45 PM
Unknown Object (File)
Oct 23 2024, 3:40 PM
Unknown Object (File)
Oct 22 2024, 12:49 AM
Unknown Object (File)
Oct 12 2024, 6:58 PM
Unknown Object (File)
Sep 5 2024, 6:49 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9363: improve handling of panels that do not always return results
Commits
rP2707681b48a2: Restrict Audit buckets to just ApplicationSearch views
Summary

Fixes T9363. This drops empty buckets from dashboard panel context. Still see full results in Audit.

Test Plan

Create an "Active Audits" panel, add to Dashboard. See no commits found. Check Audit, see all buckets.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Mar 23 2017, 7:19 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 23 2017, 7:19 PM
Harbormaster completed remote builds in B16116: Diff 42202.Mar 23 2017, 7:20 PM
epriestley accepted this revision.Mar 23 2017, 7:30 PM
epriestley added inline comments.
src/applications/audit/query/PhabricatorCommitSearchEngine.php
195–201

"commit" -> "commits"?

This revision is now accepted and ready to land.Mar 23 2017, 7:30 PM
Closed by commit rP2707681b48a2: Restrict Audit buckets to just ApplicationSearch views (authored by chad, committed by chad). · Explain WhyMar 23 2017, 7:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
query/
19 lines

Diff 42205

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
Phabricator · Built by Phacility