Page MenuHomePhabricator
Differential D17348

Make Panels slightly easier to find and use
ClosedPublic
Actions

Authored by chad on Feb 14 2017, 12:33 AM.
Tags
None
Referenced Files
F15507655: D17348.id41726.diff
Tue, Apr 15, 9:54 PM
F15488532: D17348.diff
Thu, Apr 10, 11:23 PM
F15458358: D17348.id41726.diff
Sun, Mar 30, 11:13 PM
F15446353: D17348.id41721.diff
Thu, Mar 27, 6:37 PM
F15438892: D17348.id.diff
Wed, Mar 26, 4:21 AM
F15438078: D17348.diff
Tue, Mar 25, 11:16 PM
F15383133: D17348.id41726.diff
Mar 14 2025, 3:38 PM
Unknown Object (File)
Mar 3 2025, 7:27 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10390: Dashboards v2 (UX)
Commits
rP2c09fc56051b: Make Panels slightly easier to find and use
Summary

Ref T10390, turns "add existing panel" into a typeahead, and add lots more information to search.

Test Plan

Add an existing panel, click the search icon, see more information (type, engine).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Feb 14 2017, 12:33 AM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 14 2017, 12:33 AM
chad added inline comments.Feb 14 2017, 12:34 AM
src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php
14

oooh

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
14

ahhh

src/applications/dashboard/paneltype/PhabricatorDashboardTextPanelType.php
14

zomg

Harbormaster completed remote builds in B15619: Diff 41721.Feb 14 2017, 12:34 AM
chad added inline comments.Feb 14 2017, 12:34 AM
src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

feels janky.

epriestley accepted this revision.Feb 14 2017, 2:37 AM
epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

This is the best available way to do it, but I agree it feels a little janky.

This revision is now accepted and ready to land.Feb 14 2017, 2:37 AM
Closed by commit rP2c09fc56051b: Make Panels slightly easier to find and use (authored by chad, committed by chad). · Explain WhyFeb 14 2017, 3:38 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D18121: Allow dashboard panels to be found by monogram.Jun 13 2017, 9:47 PM

Revision Contents
Changeset List

Diff 41726

View Options

src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardTextPanelType.php

Loading...
View Options

src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php

Loading...
Phabricator · Built by Phacility