Make Panels slightly easier to find and use
ClosedPublic

Authored by chad on Feb 14 2017, 12:33 AM.

Details

Summary

Ref T10390, turns "add existing panel" into a typeahead, and add lots more information to search.

Test Plan

Add an existing panel, click the search icon, see more information (type, engine).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chad created this revision.Feb 14 2017, 12:33 AM
chad added inline comments.Feb 14 2017, 12:34 AM
src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php
14

oooh

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
14

ahhh

src/applications/dashboard/paneltype/PhabricatorDashboardTextPanelType.php
14

zomg

chad added inline comments.Feb 14 2017, 12:34 AM
src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

feels janky.

epriestley accepted this revision.Feb 14 2017, 2:37 AM
epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

This is the best available way to do it, but I agree it feels a little janky.

This revision is now accepted and ready to land.Feb 14 2017, 2:37 AM
This revision was automatically updated to reflect the committed changes.