Add a tooltip option to Link menu items
ClosedPublic
Actions

Authored by chad on Mar 1 2017, 7:07 PM.

Tags

None

Referenced Files

	F18110715: D17437.id41931.diff
	Mon, Aug 11, 10:50 PM

	F18094407: D17437.id.diff
	Thu, Aug 7, 10:07 PM

	F18090645: D17437.id41932.diff
	Wed, Aug 6, 4:36 PM

	F18084859: D17437.diff
	Tue, Aug 5, 5:59 PM

	F17936566: D17437.id41931.diff
	Thu, Jul 31, 12:25 AM

	F17921255: D17437.id.diff
	Wed, Jul 30, 5:01 AM

	F17910131: D17437.diff
	Tue, Jul 29, 2:38 PM

	F17897151: D17437.id41932.diff
	Tue, Jul 29, 7:23 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP3f1ee67972ac: Add a tooltip option to Link menu items

Summary

Ref T12174. Let's users add a tooltip to LinkProfileMenuItem

Test Plan

Add a tooltip, remove tooltip. Menu appears as expected

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 1 2017, 7:07 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2017, 7:07 PM

Harbormaster completed remote builds in B15835: Diff 41931.Mar 1 2017, 7:08 PM

Does this do anything goofy in the favorites menu?

This revision is now accepted and ready to land.Mar 1 2017, 7:15 PM

Closed by commit rP3f1ee67972ac: Add a tooltip option to Link menu items (authored by chad, committed by chad). · Explain WhyMar 1 2017, 7:16 PM

This revision was automatically updated to reflect the committed changes.

No, doesn't display there, just like Application tooltips.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

menuitem/

PhabricatorLinkProfileMenuItem.php

14 lines

Diff 41932

View Options

src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php

Add a tooltip option to Link menu itemsClosedPublicActions