Paths

Table of Contentst

Differential D17527

Add Dashboards as a default pinned application
ClosedPublic
Actions

Authored by chad on Mar 21 2017, 5:41 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T10390: Dashboards v2 (UX)

Commits

rP3a838ba31269: Add Dashboards as a default pinned application

Summary

Ref T10390. Dashboard usability is high enough that I think we should pin it by default for users to create custom home pages.

Test Plan

Review order of applications in sandbox.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 21 2017, 5:41 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 21 2017, 5:41 PM

Harbormaster completed remote builds in B16071: Diff 42156.Mar 21 2017, 5:42 PM

This feels like a fairly advanced application for normal users to me and I think setup/NUX already guides admins to it, but I don't feel strongly.

src/applications/dashboard/application/PhabricatorDashboardApplication.php
22	I think you can just `return true;`, we won't pin un-installed applications.

This revision is now accepted and ready to land.Mar 21 2017, 6:02 PM

cleaner

Harbormaster completed remote builds in B16073: Diff 42158.Mar 21 2017, 6:09 PM

Closed by commit rP3a838ba31269: Add Dashboards as a default pinned application (authored by chad, committed by chad). · Explain WhyMar 21 2017, 6:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

application/

PhabricatorDashboardApplication.php

8 lines

project/

application/

PhabricatorProjectApplication.php

4 lines

Diff 42159

View Options

src/applications/dashboard/application/PhabricatorDashboardApplication.php