Fix 'Add to Dashboard' issue with builtins
ClosedPublic
Actions

Authored by chad on Mar 20 2017, 10:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 10:51 PM

	Unknown Object (File)
	Fri, Apr 19, 6:19 PM

	Unknown Object (File)
	Thu, Apr 11, 7:44 AM

	Unknown Object (File)
	Sun, Apr 7, 3:52 AM

	Unknown Object (File)
	Sat, Mar 30, 9:20 AM

	Unknown Object (File)
	Sat, Mar 30, 4:21 AM

	Unknown Object (File)
	Sat, Mar 30, 3:35 AM

	Unknown Object (File)
	Mar 21 2024, 12:54 PM

View All 84 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5307: UX for taking actions with search results

Commits

rPe69f8f717b80: Fix 'Add to Dashboard' issue with builtins

Summary

Ref T5307. Actually check the built in query with query, not engine.

Test Plan

Try a builtin query, and a custom query when making a dashboard panel.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 20 2017, 10:05 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 20 2017, 10:05 PM

epriestley accepted this revision.Mar 20 2017, 10:06 PM

This revision is now accepted and ready to land.Mar 20 2017, 10:06 PM

Harbormaster completed remote builds in B16048: Diff 42133.Mar 20 2017, 10:06 PM

Closed by commit rPe69f8f717b80: Fix 'Add to Dashboard' issue with builtins (authored by chad, committed by chad). · Explain WhyMar 20 2017, 10:07 PM

This revision was automatically updated to reflect the committed changes.

I'm tempted to make the burger menu just a button if there is a single action.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardQueryPanelInstallController.php

2 lines

Diff 42134

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Fix 'Add to Dashboard' issue with builtinsClosedPublicActions