Use typeahead for tab panel selection
ClosedPublic

Authored by chad on Tue, Feb 14, 9:34 PM.

Details

Summary

Fixes T11449. Feels.... magical? Probably a more efficient way of doing this, but only 6 tabs so...

Test Plan

Create a tab panel in old UI. Edit panel in new UI. Create a panel in new UI, edit panel in new UI.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chad created this revision.Tue, Feb 14, 9:34 PM
chad retitled this revision from Use typeahead for tab panel selection. to Use typeahead for tab panel selection.Tue, Feb 14, 9:38 PM
epriestley accepted this revision.Tue, Feb 14, 9:40 PM
epriestley added inline comments.
src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php
38–39

LUL

This revision is now accepted and ready to land.Tue, Feb 14, 9:40 PM
chad added a comment.Tue, Feb 14, 9:42 PM

If we could get away with not naming tabs, this entire interface is just a tokenizer.

chad added a comment.Tue, Feb 14, 9:42 PM

BUT 12 FIELDS IT IS

This revision was automatically updated to reflect the committed changes.