Page MenuHomePhabricator
Feed Advanced Search

Aug 22 2016

epriestley added a comment to T11512: Add error handling to email commands.

I think you should be able to throw any exception to get a reply to the user. Here's what I expect you to get back (from T10709), at least roughly:

Aug 22 2016, 9:02 PM · Feature Request
epriestley added a project to T11513: Convert the application selector in "pin applications" to a typeahead: Contributor Onboarding.
Aug 22 2016, 9:01 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley moved T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:59 PM · Contributor Onboarding, Setup
epriestley moved T9117: Remove unused edges after Ponder comes out of beta from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:59 PM · Contributor Onboarding, Ponder
epriestley reassigned T9117: Remove unused edges after Ponder comes out of beta from chad to jcox.

This is similar to T9982. Complete that task first, which describes the SQL migration process in more detail.

Aug 22 2016, 8:59 PM · Contributor Onboarding, Ponder
epriestley renamed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from schemes upgrades problem, and can't use `git clone` to Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:54 PM · Contributor Onboarding, Setup
epriestley moved T8628: Modernize AphrontControllers to implement handleRequest from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:54 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
epriestley assigned T8628: Modernize AphrontControllers to implement handleRequest to jcox.

This is an opportunity to earn valuable contributor points and explore the dark corners of the codebase. Spooky!

Aug 22 2016, 8:54 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
epriestley reassigned T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from epriestley to jcox.

Welcome to PHP! This will familiarize you with PHP! PHP is a special language!

Aug 22 2016, 8:47 PM · Contributor Onboarding, Setup
epriestley merged T8253: Upload file fails, probably my fault into T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:41 PM · Contributor Onboarding, Setup
epriestley merged task T8253: Upload file fails, probably my fault into T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:41 PM · Files
epriestley added a comment to T8253: Upload file fails, probably my fault.

Guessing this is the same as T9235.

Aug 22 2016, 8:41 PM · Files
epriestley moved T9690: Remove calls to methods deprecated by newPage() from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:38 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley assigned T9690: Remove calls to methods deprecated by newPage() to jcox.

This will "help" you "become more familiar with Phabricator's codebase".

Aug 22 2016, 8:36 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley moved T9692: Warn but continue when installing bot certificates with `arc install-certificate` from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:25 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley assigned T9692: Warn but continue when installing bot certificates with `arc install-certificate` to jcox.

This will sort of introduce you to modifying arc.

Aug 22 2016, 8:25 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley renamed T9692: Warn but continue when installing bot certificates with `arc install-certificate` from Install certificate for bot to Warn but continue when installing bot certificates with `arc install-certificate`.
Aug 22 2016, 8:12 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley moved T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:12 PM · Contributor Onboarding, Setup
epriestley assigned T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] to jcox.

Phabricator can be configured with a "preamble" script, for making certain environmental adjustments to deal with loadbalancers. This is described in Configuring a Preamble Script.

Aug 22 2016, 8:11 PM · Contributor Onboarding, Setup
epriestley moved T9900: Figlet does not properly render apostrophes with some characters from Backlog to Intermediate on the Contributor Onboarding board.
Aug 22 2016, 8:07 PM · Contributor Onboarding, Remarkup
epriestley assigned T9900: Figlet does not properly render apostrophes with some characters to jcox.

PhabricatorRemarkupFigletBlockInterpreter is a remarkup rule for rendering figlet fonts, invoked like this:

Aug 22 2016, 8:07 PM · Contributor Onboarding, Remarkup
epriestley moved T9982: Eventually, drop the conduit_connectionlog table from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 7:57 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley reassigned T9982: Eventually, drop the conduit_connectionlog table from epriestley to jcox.

Let's permanently destroy some data! This will introduce you to how to perform schema changes.

Aug 22 2016, 7:57 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley moved T10951: Search shows document types corresponding to disabled apps from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 7:50 PM · Contributor Onboarding, Search, Bug Report
epriestley added a comment to T10951: Search shows document types corresponding to disabled apps.

Perhaps in a separate change, it would be nice to maybe show the application name under the more modern document types -- for example, show "Diffusion" here:

Aug 22 2016, 7:49 PM · Contributor Onboarding, Search, Bug Report
epriestley assigned T10951: Search shows document types corresponding to disabled apps to jcox.

To reach this dialog, mash some text into the search field in the global menu bar, then hit enter.

Aug 22 2016, 7:41 PM · Contributor Onboarding, Search, Bug Report
epriestley moved T10999: Expand MFA checks to all email operations from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 7:34 PM · Contributor Onboarding, Security
epriestley assigned T10999: Expand MFA checks to all email operations to jcox.

In Settings → (Personal Account Settings) → Email Addresses, you can take several actions with email addresses associated with your account, including adding new addresses.

Aug 22 2016, 7:34 PM · Contributor Onboarding, Security
epriestley moved T11508: Create a blacklist of terms that chatbots should ignore from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 7:22 PM · Contributor Onboarding, Feature Request
epriestley assigned T11508: Create a blacklist of terms that chatbots should ignore to jcox.

Phabricator ships with a chatbot, roughly documented in Chat Bot Technical Documentation.

Aug 22 2016, 7:22 PM · Contributor Onboarding, Feature Request
epriestley added a member for Blessed Committers: jcox.
Aug 22 2016, 7:04 PM
epriestley added a member for Community: jcox.
Aug 22 2016, 7:04 PM
epriestley closed T7901: S3 buckets with dot give SSL error as Resolved.

I believe this was resolved when D14982 moved us to a first-party client. We now ask for region/endpoint explicitly and I think there's no way to configure the bucketname.amazonaws.com version any more.

Aug 22 2016, 6:59 PM · Restricted Project, Documentation
epriestley added a project to T8236: `arc weld` should do something: Contributor Onboarding.
Aug 22 2016, 6:55 PM · Contributor Onboarding, Arcanist
epriestley added a project to T8330: Detect/repair invalid "enum" config: Contributor Onboarding.
Aug 22 2016, 6:53 PM · Contributor Onboarding, Setup
epriestley closed T8595: Don't show CSRF exception in the error logs as Resolved.

This and a few other overly-chatty errors should be quieter after T11480.

Aug 22 2016, 6:48 PM · Security
epriestley added a project to T8628: Modernize AphrontControllers to implement handleRequest: Contributor Onboarding.
Aug 22 2016, 6:47 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
epriestley closed T8634: Modernize search engines as Resolved.

I think most of these have been converted now, and the remaining stragglers are getting fixed up alongside other changes (EditEngine, third-generation APIs, etc).

Aug 22 2016, 6:47 PM · Modernization, Infrastructure
epriestley closed T8633: Modernize query engines as Resolved.

I'm just going to close this since we've converted most of the Query classes by now and are fixing the remaining ones as adjacent work happens. These changes were just minor improvements to code clarity and there's no particular urgency to fully modernizing things, nor do we get to delete a bunch of code once we're done or reduce maintenance costs in a global way or anything like that.

Aug 22 2016, 6:46 PM · Restricted Project, Modernization, Infrastructure
epriestley added a project to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR']: Contributor Onboarding.
Aug 22 2016, 6:42 PM · Contributor Onboarding, Setup
epriestley added a project to T9063: Conduit application search: Contributor Onboarding.
Aug 22 2016, 6:37 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley added a project to T9117: Remove unused edges after Ponder comes out of beta: Contributor Onboarding.
Aug 22 2016, 6:36 PM · Contributor Onboarding, Ponder
epriestley added a project to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured: Contributor Onboarding.
Aug 22 2016, 6:33 PM · Contributor Onboarding, Setup
epriestley closed T9272: Show x lines does not work as expected in dialog as Resolved.

This was indirectly resolved by the switch to prose diffs in T7643.

Aug 22 2016, 6:31 PM · PHUI
epriestley closed T9572: Thumbs up icon should be clickable as Resolved.

I think we got rid of this since it was kind of weird and overlapped a lot with tokens.

Aug 22 2016, 6:27 PM · Ponder
epriestley added a project to T9690: Remove calls to methods deprecated by newPage(): Contributor Onboarding.
Aug 22 2016, 6:26 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley added a project to T9692: Warn but continue when installing bot certificates with `arc install-certificate`: Contributor Onboarding.
Aug 22 2016, 6:26 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley added a project to T9854: Support date/time reformatting in Remarkup: Contributor Onboarding.
Aug 22 2016, 6:23 PM · Contributor Onboarding, Restricted Project, Remarkup
epriestley added a project to T11508: Create a blacklist of terms that chatbots should ignore: Contributor Onboarding.

Actually, from T9899 it looks like we already require it anyway, so whatever.

Aug 22 2016, 6:22 PM · Contributor Onboarding, Feature Request
epriestley added a project to T9900: Figlet does not properly render apostrophes with some characters: Contributor Onboarding.
Aug 22 2016, 6:21 PM · Contributor Onboarding, Remarkup
epriestley added a project to T9982: Eventually, drop the conduit_connectionlog table: Contributor Onboarding.
Aug 22 2016, 6:19 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley closed T10018: Application transactions don't get avatars in the Recent Activity Feed as Resolved.

This was resolved in conjunction with T8952.

Aug 22 2016, 6:19 PM · Bug Report, Feed
epriestley closed T10029: PhabricatorRepositoryGitCommitChangeParserWorker is unable to find a commit as Resolved.

I believe this is resolved with modern clustered repositories. secure has been spread across two hosts for some time now without encountering any of this.

Aug 22 2016, 6:18 PM · Infrastructure, Daemons
epriestley added a project to T10679: When phurl.short-uri is configured, use it in the UI: Contributor Onboarding.
Aug 22 2016, 6:04 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T11509: Provide a way to quickly see if all comments on a diff have been marked as "done".

Upstream-wise, T8250 should happen first.

Aug 22 2016, 6:03 PM · Inline Comments, Differential, Restricted Project, Feature Request
epriestley added a comment to T11508: Create a blacklist of terms that chatbots should ignore.

We have config for this (remarkup.ignored-object-names) but the chatbot currently (by design) only uses the API, and there's no way to get this over the API.

Aug 22 2016, 6:01 PM · Contributor Onboarding, Feature Request
epriestley added a project to T11511: Give edit forms email addresses: Contributor Onboarding.
Aug 22 2016, 5:57 PM · Restricted Project, Contributor Onboarding, Feature Request
epriestley closed T10682: Applications have no profile photos when they author transactions as Resolved.

I believe this was resolved as part of T8952:

Aug 22 2016, 5:55 PM · Restricted Project, Harbormaster, Bug Report
epriestley reopened T8952: Hide "Herald added subscribers..." stories from feed completely as "Open".

Just reopening this so I don't forget about it since I agree about that last change.

Aug 22 2016, 5:55 PM · Feed, Herald
epriestley added a project to T10715: Badge name on badge cards should be a link to the badge page: Contributor Onboarding.
Aug 22 2016, 5:50 PM · Contributor Onboarding, Badges
epriestley added a project to T10798: Limit, order recipients list in BadgeView: Contributor Onboarding.
Aug 22 2016, 5:48 PM · Badges (v0), Contributor Onboarding, Restricted Project
epriestley added a project to T10881: git diff parsing fails with --submodule=log: Contributor Onboarding.
Aug 22 2016, 5:46 PM · Contributor Onboarding, Arcanist, Bug Report
epriestley added a project to T10951: Search shows document types corresponding to disabled apps: Contributor Onboarding.
Aug 22 2016, 5:44 PM · Contributor Onboarding, Search, Bug Report
epriestley added a project to T10999: Expand MFA checks to all email operations: Contributor Onboarding.
Aug 22 2016, 5:42 PM · Contributor Onboarding, Security
epriestley added a project to T11217: Make Tokens modular / real application: Contributor Onboarding.
Aug 22 2016, 5:38 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T11476: Record transaction histories when users edit application capabilities from Intermediate to Backlog on the Contributor Onboarding board.
Aug 22 2016, 5:34 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley added a project to T11360: Detect MySQL `read_only` and degrade masters to replicas: Contributor Onboarding.

Although this is cluster-related, it can be tested with a single database host and is probably not exceptionally difficult to handle better. Briefly:

Aug 22 2016, 5:34 PM · Contributor Onboarding, Restricted Project, Clusters
epriestley moved T11476: Record transaction histories when users edit application capabilities from Backlog to Intermediate on the Contributor Onboarding board.
Aug 22 2016, 5:08 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley added a project to T11476: Record transaction histories when users edit application capabilities: Contributor Onboarding.

In most cases, edits in Phabricator are preserved and displayed in a transaction log, similar to the one you are looking at right now on this task, where this very comment appears. The transaction log records a complete record of changes so it's easy to review what changed and when.

Aug 22 2016, 5:06 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley removed a member for Contributor Onboarding: epriestley.
Aug 22 2016, 4:45 PM
epriestley removed a project from T4997: App naming is a barrier to entry: Contributor Onboarding.
Aug 22 2016, 4:44 PM
epriestley removed a project from T4945: Subscribing users when they award tokens : Contributor Onboarding.
Aug 22 2016, 4:44 PM · Tokens
epriestley removed a project from T3669: Make it easier to remember to submit inline comments when updating a diff: Contributor Onboarding.
Aug 22 2016, 4:43 PM · Design, Differential
epriestley renamed Contributor Onboarding from Onboarding to Contributor Onboarding.
Aug 22 2016, 4:43 PM
epriestley added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

We really, truly need reproduction instructions that let us reproduce the problem in an environment we control. We're happy to accept this bug report and fix the underlying issue as soon as we're able to reproduce it.

Aug 22 2016, 3:51 PM · Bug Report (Needs Information)
epriestley edited the content of Vacation Policy.
Aug 22 2016, 11:38 AM
epriestley added a comment to T11132: New Phabricator NUX.

I think we're on fairly firm technical footing on some specific changes, which I can probably lay the groundwork for and hand off to you to populate:

Aug 22 2016, 11:05 AM · Design, Phacility, NUX
epriestley added projects to T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:": Differential, Diffusion.
Aug 22 2016, 8:48 AM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley renamed T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" from arc complains when tests is in the title to Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:".
Aug 22 2016, 8:48 AM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley reopened T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" as "Open".

I agree with that (and actually believed we already did that, see T11485 for me claiming that this is the current behavior). We'll change this.

Aug 22 2016, 8:47 AM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley closed T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project. as Invalid.

We haven't seen other reports of similar issues and can't reproduce this issue ourselves in a variety of production and development environments.

Aug 22 2016, 7:56 AM · Bug Report
epriestley closed T11498: "Change Subscribers" field does not include subscribers that will be added to a task when a Maniphest comment is submitted as Resolved.

I'm going to close this since it's working as intended and was just based on a miscommunication -- the actions UI (above the comment text area) is not expected to show a preview of the effects of a change. Instead, the preview UI (below the comment text area) shows this preview information.

Aug 22 2016, 7:54 AM · Bug Report

Aug 21 2016

epriestley added a comment to Q464: Seemingly repeating transaction causing many emails to be sent (Answer 440).

Actually, this is probably not T10968, although perhaps it's something similar -- possibly bad behavior when generating inline diffs or diff attachments for mail? It should normally be very difficult for a TransactionPublishWorker to generate mail side effects multiple times.

Aug 21 2016, 10:47 PM
epriestley added Q464: Seemingly repeating transaction causing many emails to be sent (Answer 440).
Aug 21 2016, 10:45 PM
epriestley reopened T11495: Drydock doesn't delete working copies as "Open".
Aug 21 2016, 1:36 PM · Bug Report (Needs Information), Drydock
epriestley added a comment to T11506: Build smarter CLI caching for instance data in the Phacility cluster.

It's also vaguely desirable if the bulk processes (deploy/upgrade) can explicitly prefill the disk caches after mass-purging, since a bulk prefill is significantly more efficient than doing a readthrough fill moments later when the daemons restart. This only smooths out API burstiness during deploys, though.

Aug 21 2016, 1:03 PM · Phacility
epriestley created T11506: Build smarter CLI caching for instance data in the Phacility cluster.
Aug 21 2016, 1:01 PM · Phacility
epriestley closed T11495: Drydock doesn't delete working copies as Invalid.

Sorry, we don't offer help diagnosing problems. See Support Resources for a list of what we do and do not offer help with.

Aug 21 2016, 12:48 PM · Bug Report (Needs Information), Drydock
epriestley added a comment to T11443: T-shirts with new logo.

Some other things that could use updates:

Aug 21 2016, 12:39 AM · Public & Media Relations
epriestley added a comment to T11413: Support renaming Phacility instances.

After more thinking, I'm leaning heavily toward just doing a "display rename":

Aug 21 2016, 12:17 AM · Phacility
chad awarded T7148: Allow users to export their data from Phacility a Mountain of Wealth token.
Aug 21 2016, 12:06 AM · Phacility
epriestley added a comment to T7148: Allow users to export their data from Phacility.

I used the new support code in connection with a manual instance rename (see T11413) and it appears to have worked.

Aug 21 2016, 12:03 AM · Phacility

Aug 20 2016

epriestley edited the content of Changelog.
Aug 20 2016, 11:09 PM
epriestley created 2016 Week 34 (Late August).
Aug 20 2016, 11:08 PM
epriestley merged T11503: Notifications for past events sent after Phabricator upgrade into T11188: Updating to latest Phabricator caused feed corruption.
Aug 20 2016, 10:55 PM · Bug Report
epriestley merged task T11503: Notifications for past events sent after Phabricator upgrade into T11188: Updating to latest Phabricator caused feed corruption.
Aug 20 2016, 10:55 PM · Diffusion, Bug Report (Needs Information)
epriestley added a comment to T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..

I can't reproduce this. Here's what I did:

Aug 20 2016, 10:52 PM · Bug Report
epriestley added a comment to T7148: Allow users to export their data from Phacility.

After D16427, I have an automated version of this working locally. It needs some more UI polish and I'm not going to try to get it in this week, but the support code (services dump / services export) will go out and then this can maybe go out next week or so.

Aug 20 2016, 9:35 PM · Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Aug 20 2016, 9:09 PM · Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Aug 20 2016, 9:08 PM · Phacility