Page MenuHomePhabricator
Feed Advanced Search

Jul 8 2016

epriestley closed T11293: Show the repo name in the Owners app's "paths" editor as Resolved by committing Restricted Diffusion Commit.
Jul 8 2016, 2:08 PM · Owners, Bug Report
epriestley added a revision to T11278: It's confusing to figure out in the UI how to import a repository now: Unknown Object (Differential Revision).
Jul 8 2016, 12:50 PM · Design, Diffusion
epriestley closed T11157: ability to disable support for certain VCS as Invalid.

This is purely hypothetical and it's hard for me to imagine users getting it wrong by accident.

Jul 8 2016, 12:24 PM · Diffusion, Feature Request
epriestley closed T11161: Panel creation can be confusing as Resolved.

After D16226, panels no longer support tagging.

Jul 8 2016, 12:18 PM · Design, Dashboards (v2)
epriestley added a comment to T11168: Clicking a milestone tag should take you to the workboard, not the milestone project page.

This is working as intended.

Jul 8 2016, 12:15 PM · Projects, Feature Request
epriestley added a comment to T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal.

We might have had some kind of dialog action from lightboxes in the past (or planned to have one -- like image inline comments?), but didn't have a lightbox action from dialogs until inline previews.

Jul 8 2016, 11:59 AM · Lightbox, Bug Report
epriestley closed T11296: Edit Queries/Advanced Search 404s from Settings page as Resolved.

This was fixed by D16238 (Tuesday, July 5). It's available at HEAD of master and will promote to stable and be available in the Phacility cluster in a little more than 24 hours.

Jul 8 2016, 11:53 AM · Bug Report
epriestley added a comment to T11254: Provide a way for quick revert of all activities of the most recent task editor..

This is enormously complex to implement in the general case.

Jul 8 2016, 11:49 AM · Abuse, Maniphest, Wikimedia, Feature Request
epriestley edited projects for T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts, added: Bug Report (Needs Information); removed Bug Report.
Jul 8 2016, 11:43 AM · Bug Report (Needs Information)
epriestley added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

A possible fix to this is to handle ` on keydown instead of keypress (as we do for some other other keystrokes) but since we can't reproduce it we can't test that.

Jul 8 2016, 11:43 AM · Bug Report (Needs Information)
epriestley renamed T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts from Keyboard bindings missing? to DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.
Jul 8 2016, 11:38 AM · Bug Report (Needs Information)
epriestley triaged T11277: Provide a generic SSH public key store for users as Wishlist priority.
Jul 8 2016, 11:34 AM · Auth, Feature Request
epriestley added a revision to T11295: Worker queue 404 page fails with invalid `$header`: Unknown Object (Differential Revision).
Jul 8 2016, 11:34 AM · Daemons, Bug Report
epriestley added projects to T11295: Worker queue 404 page fails with invalid `$header`: Bug Report, Daemons.
Jul 8 2016, 11:29 AM · Daemons, Bug Report
epriestley added a comment to T11291: Error while executing task (phd daemon).

Your database may not have proper column encodings configured. Run this command to verify them:

Jul 8 2016, 11:29 AM · Daemons, Bug Report
epriestley created T11295: Worker queue 404 page fails with invalid `$header`.
Jul 8 2016, 11:21 AM · Daemons, Bug Report
epriestley added a comment to T11293: Show the repo name in the Owners app's "paths" editor.

D16253 should fix this; a quasi-workaround in the meantime is to set "Short Names" on repositories.

Jul 8 2016, 11:19 AM · Owners, Bug Report
epriestley claimed T11293: Show the repo name in the Owners app's "paths" editor.
Jul 8 2016, 11:19 AM · Owners, Bug Report
epriestley added a revision to T11293: Show the repo name in the Owners app's "paths" editor: Unknown Object (Differential Revision).
Jul 8 2016, 11:18 AM · Owners, Bug Report
epriestley added a comment to T11292: Permanent failure while executing Task ID <id>.

(Or likewise with the task ID.)

Jul 8 2016, 12:01 AM · Bug Report
epriestley added a comment to T11292: Permanent failure while executing Task ID <id>.

Is the commit ID exactly the same each time, or does it change?

Jul 8 2016, 12:01 AM · Bug Report

Jul 7 2016

epriestley added a comment to T8250: Would like to see all comments and their status in a list.

Here's approximately where I'm headed with this:

Jul 7 2016, 11:59 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley added a comment to T11271: Inconsistency in project membership displaying.

No problem, thanks for the followup!

Jul 7 2016, 11:10 PM · Projects, People, Bug Report
epriestley added a comment to T8573: All reviewers should be allowed to mark a comment as done.

Per T1460:

Jul 7 2016, 11:04 PM · Restricted Project, Differential, Restricted Project
epriestley added a subtask for T1460: Add "Done" link to an inline comment: T8573: All reviewers should be allowed to mark a comment as done.
Jul 7 2016, 10:59 PM · User Delight, Differential
epriestley added a parent task for T8573: All reviewers should be allowed to mark a comment as done: T1460: Add "Done" link to an inline comment.
Jul 7 2016, 10:59 PM · Restricted Project, Differential, Restricted Project
epriestley added a comment to T11286: make it possible to remove tasks from a batch edit tasks workflow.

thank you for your compliance

Jul 7 2016, 10:57 PM · Maniphest, Feature Request
epriestley awarded T11286: make it possible to remove tasks from a batch edit tasks workflow a Burninate token.
Jul 7 2016, 10:57 PM · Maniphest, Feature Request
epriestley added a comment to T11286: make it possible to remove tasks from a batch edit tasks workflow.

Oh, no, it's 268 and 286. No guac!

Jul 7 2016, 10:57 PM · Maniphest, Feature Request
epriestley added a comment to T11286: make it possible to remove tasks from a batch edit tasks workflow.

Wow, exactly 1,000 apart.

Jul 7 2016, 10:55 PM · Maniphest, Feature Request
epriestley added a comment to T11286: make it possible to remove tasks from a batch edit tasks workflow.

T10268 is also vaguely related.

Jul 7 2016, 10:55 PM · Maniphest, Feature Request
epriestley closed T11092: Review comments lost or posted to wrong diff as Resolved.

Presuming this is resolved now, let us know if you're still seeing issues.

Jul 7 2016, 10:54 PM · Differential, Bug Report
epriestley added a project to T8250: Would like to see all comments and their status in a list: Prioritized.
Jul 7 2016, 10:53 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley added a comment to T8250: Would like to see all comments and their status in a list.

My tentative plan for this is a separate view where all inlines are shown in threads, sorted by done-ness and activity.

Jul 7 2016, 10:53 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley added a project to T5654: Show more context for inline comments in Differential timeline: Prioritized.

I'm not particularly sold on putting context in the timeline, particularly because I think we've received about as much feedback about Differential having "too much stuff" as we have about this context being desirable.

Jul 7 2016, 10:51 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley closed T1460: Add "Done" link to an inline comment as Resolved.

I'm going to close this in favor of more specific followup subtasks:

Jul 7 2016, 10:48 PM · User Delight, Differential
epriestley closed T1460: Add "Done" link to an inline comment, a subtask of T5179: Unearth Differential rendering technical debt, as Resolved.
Jul 7 2016, 10:48 PM · Differential
epriestley closed T1460: Add "Done" link to an inline comment, a subtask of T5654: Show more context for inline comments in Differential timeline, as Resolved.
Jul 7 2016, 10:48 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley closed T1460: Add "Done" link to an inline comment, a subtask of T5742: Add commentor column to "Revision Update History" table, as Resolved.
Jul 7 2016, 10:48 PM · Differential
epriestley closed T1460: Add "Done" link to an inline comment, a subtask of T7358: When Replying to an Inline Comment, provide original context in email?, as Resolved.
Jul 7 2016, 10:48 PM · Mail
epriestley closed T11235: Threaded comments as Wontfix.

I don't plan to pursue this outside of the context of T1460, T8250, etc. If we did, it would be in the far future and after those changes land.

Jul 7 2016, 10:42 PM · Restricted Project, Differential, Feature Request
epriestley closed T11285: PhabricatorApplicationTransactionPublishWorker fails on bad getURI call as Resolved by committing Restricted Diffusion Commit.
Jul 7 2016, 9:55 PM · Bug Report
epriestley added a comment to T11290: bold text for values in transaction.

Upshot: I think renderValue($string) on ModularTransactionType is totally reasonable. We can fiddle with how it looks later.

Jul 7 2016, 9:55 PM · Design
epriestley added a revision to T11285: PhabricatorApplicationTransactionPublishWorker fails on bad getURI call: Unknown Object (Differential Revision).
Jul 7 2016, 9:53 PM · Bug Report
epriestley added a comment to T11289: Missing avatar in Feed for Test Notifications.

I intend to remove them from feed, but it might have just been on a diff somewhere and not made it to a task.

Jul 7 2016, 7:43 PM · Bug Report
epriestley awarded T11290: bold text for values in transaction a Dat Boi token.
Jul 7 2016, 7:18 PM · Design
epriestley added a comment to T11290: bold text for values in transaction.

I think it's generally reasonable to show values with style instead of quotes in the web UI, although maybe a style other than bold would be best.

Jul 7 2016, 7:17 PM · Design
epriestley added a comment to T9412: Annotate all the reasons that a user is included on the recipient list for mail.

There is no way to unsubscribe from them.

Jul 7 2016, 7:11 PM · llvm, Restricted Project, Mail
epriestley closed T5275: Activate Twitter as External Auth Provider for https://secure.phabricator.com as Wontfix.

We haven't gotten to this in two years and haven't really seen other interest. We already support ~8 providers.

Jul 7 2016, 6:18 PM · Auth
epriestley closed T11288: Titl as Spite.
Jul 7 2016, 6:12 PM
epriestley closed T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential as Resolved.

Some additional work (the "Stack" tab) ended up overlapping with T4788 but I think this is resolved.

Jul 7 2016, 5:32 PM · Restricted Project, Differential
epriestley added a revision to T9275: Move Calendar to EditEngine: Unknown Object (Differential Revision).
Jul 7 2016, 5:26 PM · ApplicationEditor, Policy, Calendar
epriestley added a comment to T11286: make it possible to remove tasks from a batch edit tasks workflow.

Workaround is to edit this URI:

Jul 7 2016, 4:39 PM · Maniphest, Feature Request
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Okay, but the docs don't actually describe or refer to an import button anywhere -- there's no text like "click the import button" that I missed when updating things?

Jul 7 2016, 2:58 PM · Design, Diffusion
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

so the UI should still look good given that edge-case.

Jul 7 2016, 1:56 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a revision to T9895: Update Phame Documentation: Unknown Object (Differential Revision).
Jul 7 2016, 1:40 AM · Phame
epriestley closed T9895: Update Phame Documentation as Resolved.

Resolved by D16246, I suppose.

Jul 7 2016, 1:40 AM · Phame
epriestley closed T9895: Update Phame Documentation, a subtask of T9360: Unbeta Phame, as Resolved.
Jul 7 2016, 1:40 AM · Phame
epriestley moved T6299: Remarkup links to objects in Phame break if a CNAME is set from Backlog to Future on the Phame board.
Jul 7 2016, 1:40 AM · Haskell.org, Remarkup, Phame
epriestley removed a subtask for T9897: Unbeta Feedback on Phame: T6299: Remarkup links to objects in Phame break if a CNAME is set.
Jul 7 2016, 1:40 AM · Phame
epriestley removed a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 7 2016, 1:40 AM · Haskell.org, Remarkup, Phame
epriestley added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Jul 7 2016, 1:34 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

Oh, now that we gave posts the J monogram, we should probably also find a way to put that on the blog page somewhere (at least the internal one, and maybe the ApplicationSearch results page). Right now you have to know that you can fish the ID out of the URI. Let me see if I can poke at that a bit with my doc stuff.

Jul 7 2016, 1:02 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

Just the T6299 stuff, I think.

Jul 7 2016, 12:26 AM · Phame

Jul 6 2016

epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I'm leaning toward making it a "Relationships" box with "Task Graph", "Mocks" (with a thumbnail/gallery view instead of just titles), and "Commits/Revisions" (probably with a little more status information than we currently show).

Jul 6 2016, 11:50 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Another issue is that when following the user docs, the docs still points towards having the import button on the creation of project.

Jul 6 2016, 11:31 PM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

I'm leaning toward just adding a big "Clippy" element to this UI:

Jul 6 2016, 11:30 PM · Design, Diffusion
epriestley added a comment to T11277: Provide a generic SSH public key store for users.

SSH keys only got half-upgraded to modern stuff in T10917, but we could finish that at some point and let you tag them with projects -- roughly the same as renaming them, but a little more formal.

Jul 6 2016, 2:42 PM · Auth, Feature Request
epriestley added a comment to T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log.

Thanks for the report! This should be resolved in HEAD of master.

Jul 6 2016, 2:21 PM · Paste, Bug Report
epriestley closed T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log as Resolved by committing Restricted Diffusion Commit.
Jul 6 2016, 2:17 PM · Paste, Bug Report
epriestley added a revision to T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log: Unknown Object (Differential Revision).
Jul 6 2016, 11:00 AM · Paste, Bug Report
epriestley claimed T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log.
Jul 6 2016, 10:59 AM · Paste, Bug Report
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Here's what I see -- step 1:

Jul 6 2016, 2:28 AM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

GitHub's import doesn't seem to work with any repositories that require credentials?

Jul 6 2016, 2:04 AM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Oh, I was looking at this:

Jul 6 2016, 2:01 AM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

GitHub make this reasonably obvious.

Jul 6 2016, 1:59 AM · Design, Diffusion

Jul 5 2016

epriestley closed T11275: Missing "Edit Queries..." and "Advanced Search" pages in User Settings as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 11:55 PM · Bug Report
epriestley closed T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 11:45 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a revision to T11275: Missing "Edit Queries..." and "Advanced Search" pages in User Settings: Unknown Object (Differential Revision).
Jul 5 2016, 11:45 PM · Bug Report
epriestley added a revision to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input: Unknown Object (Differential Revision).
Jul 5 2016, 11:40 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

A possible alternate approach would be to attachRepository() as a side-effect of validating the transaction instead of while applying the transaction, but then if something throws between the "validate" and "apply" steps we could end up with a URI in a weird state. That probably never actually matters, but feels a little more awkward to me than ordering the transactions.

Jul 5 2016, 11:34 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

It's impossible to create a URI without a repository transaction (it doesn't make sense, since URI objects can't just exist), and we already give you an appropriate error when you try:

Jul 5 2016, 11:31 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T9275: Move Calendar to EditEngine.

One problem with updating this is that recurring events currently work like this:

Jul 5 2016, 10:50 PM · ApplicationEditor, Policy, Calendar
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

My initial thought is that we should just reorder these transactions. We should use a stable sort, but that's relatively easy now that we have msortv(). There are probably a handful of other transactions with similar properties in other object types.

Jul 5 2016, 9:10 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a revision to T9275: Move Calendar to EditEngine: Unknown Object (Differential Revision).
Jul 5 2016, 4:30 PM · ApplicationEditor, Policy, Calendar
epriestley claimed T9275: Move Calendar to EditEngine.
Jul 5 2016, 4:28 PM · ApplicationEditor, Policy, Calendar
epriestley added a comment to T11269: Repository update command fails on empty Git repositories.

Thanks for the report! I believe this should now be resolved in HEAD of master.

Jul 5 2016, 4:10 PM · Diffusion, Bug Report
epriestley closed T11269: Repository update command fails on empty Git repositories as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 4:09 PM · Diffusion, Bug Report
epriestley added a comment to T10633: Render timezones explicitly in email.

T9854 is also vaguely related, but fairly separate.

Jul 5 2016, 4:06 PM · Calendar, Mail, Countdown, Bug Report
epriestley closed T7929: Integrate Calendar with external systems as Resolved.

I'm just going to close this in favor of the specific ICS (T10747) and Google Calendar (T2334) tasks, which are the only systems we plan to target for now and don't have much in common.

Jul 5 2016, 3:59 PM · Calendar
epriestley closed T9606: "Calendar" tab on user profiles is pretty junky as Resolved.

I think this is in reasonable shape, now.

Jul 5 2016, 3:58 PM · Calendar
epriestley closed T9606: "Calendar" tab on user profiles is pretty junky, a subtask of T7925: Calendar v1 Errata, as Resolved.
Jul 5 2016, 3:58 PM · Calendar
epriestley closed T10920: Allow assigning a diff to a commit post-facto as Resolved.

Yes, commit/revision and commit/task relationships can now be managed manually from the web UI.

Jul 5 2016, 3:52 PM · Diffusion, Feature Request
epriestley added a revision to T11269: Repository update command fails on empty Git repositories: Unknown Object (Differential Revision).
Jul 5 2016, 3:30 PM · Diffusion, Bug Report
epriestley claimed T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Diffusion, Bug Report
epriestley merged T11273: Update error while Repository Updates into T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Diffusion, Bug Report
epriestley merged task T11273: Update error while Repository Updates into T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Bug Report
epriestley added a comment to T11273: Update error while Repository Updates .

I'm going to merge this into T11269, which I believe describes the same problem.

Jul 5 2016, 3:25 PM · Bug Report
epriestley added a comment to T11274: Task Graph has extra vertical space on tickets with titles that run onto multiple lines.

Thanks for the report! I think this should be fixed at HEAD of master. Let us know if you're still seeing issues after updating.

Jul 5 2016, 3:11 PM · Bug Report
epriestley closed T11274: Task Graph has extra vertical space on tickets with titles that run onto multiple lines as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 3:00 PM · Bug Report