Page MenuHomePhabricator

DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts
Closed, DuplicatePublic

Description

Couple days ago, I noticed, that / for search no longer works, now, when wanted to test dark console, i noticed, that ` doesn't work either.(*)

Both tested ATM in this Phabricator instance.

Firefox 64bit 47/47.0.1 @ Win7x64

(*) When enabling the console, it is there constantly, can't be hidden -> may this be another bug? Feel free to start another task, please subscribe me there then.

Event Timeline

/ was removed, see D15976 and the changelog:

Removed "/"-to-focus-search behavior.
https://secure.phabricator.com/w/changelog/2016.22/

The ` key works fine for me in Chrome, Safari and Firefox on MacOS X, but I haven't checked Windows. One other possibility: are you using a non-US keyboard?

Tested in both en and cs layouts.

Mind the (*) note, which may be indicating different issue then (my original assumption was keyboard binding due to the search, since I didn't know about / removal).

I can't reproduce on Windows, Chrome, FF, IE with en layouts.

@chad Which version of Win & FF you use?

Tested 8 and 10. I don't have Win7.

The next step on this report would be for you to try to reproduce on a different environment.

That's what I plan. Just tested it on WXPx86 and FF 47.0.1 32bit and it works there.

But knowing the versions you used would help to save necessity to test the same environment again.

I can look in more detail when I'm back home. Kids have a picnic today.

Firefox 44 / Ubuntu 15.04
Firefox 47.0.1 (64) Windows 8.1
Firefox 47.0.1 (64) Windows 10
Firefox 47.0.1 (64) macOS

Two main things to look at, since it's not likely a Firefox issue, is keyboard layout or if maybe something's borked with Preferences. Make sure you have developer preference in Settings turned to Enable Darkconsole.

Thanks.

I found a workaround in the meantime: Press ` and then space (or any other key). The issue obviously is that ` is being sent like dead (combining) key on en-US keyboard layout.

epriestley renamed this task from Keyboard bindings missing? to DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.Jul 8 2016, 11:38 AM
epriestley triaged this task as Wishlist priority.

A possible fix to this is to handle ` on keydown instead of keypress (as we do for some other other keystrokes) but since we can't reproduce it we can't test that.

This is a possible (completely untested) patch if anyone with a development install handy is able to reproduce the issue:

diff --git a/webroot/rsrc/js/core/KeyboardShortcutManager.js b/webroot/rsrc/js/core/KeyboardShortcutManager.js
index 3acef19..ec59d3e 100644
--- a/webroot/rsrc/js/core/KeyboardShortcutManager.js
+++ b/webroot/rsrc/js/core/KeyboardShortcutManager.js
@@ -29,7 +29,8 @@ JX.install('KeyboardShortcutManager', {
       left: 1,
       right: 1,
       up: 1,
-      down: 1
+      down: 1,
+      '`': 1
     },
 
     getInstance : function() {

I'm going to merge this into T10252, which may not be the same issue, but which has reproduction steps.