Page MenuHomePhabricator

bold text for values in transaction
Closed, ResolvedPublic

Description

In most transactions, the key information is a link, which is rendered in bold, or free-text, which is long and rendered in ".
In some transactions, most notably maniphest status/priority changes, the "key information" is one word, but it's rendered in " as well. I have a couple of extra examples in my extensions where I want to highlight some short information ("x deployed bar to this env", "x updated status of this artifact to bad", etc).

I think it would make sense to have a renderValue($text) method, that will show up bold in html and in quotes in text, to draw attention to the primary information.

Revisions and Commits

Event Timeline

Tagged this with Design, because this is mostly UI question...

I'd like these to be extendable actually, and not just dark links. So for instance, if you tag a project, we could render the actual project tag:

chad added a project: Design

There was a longer discussion in enriching timelines in D15442.

Projects are PHUIHandleView, so we could theoretically teach the handle to render them with tags.

I was talking more about things that aren't real objects, like task status.

I think it's generally reasonable to show values with style instead of quotes in the web UI, although maybe a style other than bold would be best.

The major reason status and priority names are quoted is because they're user-customizable. Although this is obvious with or without quotes:

epriestley changed the priority of this task from "Low" to "High".

...this might not be:

epriestley changed the priority of this task from waiting on customer to provide feedback to to chad's house we go.

That example is very silly and it's probably rarely unclear in the wild, but that was my thinking, at least.


In the specific case of title edits, I'd also like to render a diffed form (ala prose diffs) for minor changes and typo corrections. If you correct one letter or one spelling mistake, it would be nice to show something like this:

epriestley made a minor edit to the title: ... several frugsfrogs have escaped ...

Upshot: I think renderValue($string) on ModularTransactionType is totally reasonable. We can fiddle with how it looks later.