Page MenuHomePhabricator
Feed Advanced Search

Oct 27 2015

epriestley closed T9252: Unprototype Drydock (v1), a subtask of T9123: Build Phabricator in Harbormaster (v2), as Resolved.
Oct 27 2015, 9:54 PM · Prioritized, Harbormaster
epriestley added a comment to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context.

Can you see the repository? (PHID-REPO-rgnn364lembo2emt5622)?

Oct 27 2015, 9:47 PM · Policy, Differential
epriestley added a comment to T182: Commit into repository directly from differential.

This is in reasonably functional shape for ambitious users. There's some documentation now:

Oct 27 2015, 9:08 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9643: XHPast Parse error when extracting i18n.

Probably not, but it seems vaguely nice that i18n extract doesn't need to know anything about the directory structure, and that we can put pht() in externals/ as a local patch if we need to clarify some error or something.

Oct 27 2015, 9:07 PM · XHPAST
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

@Krinkle: I can't come up with a reasonable way to fix the height=300 comment preview case unless we render the element entirely on the client or relax the WMF constraints. I think the WMF constraints are excessively paranoid, but it's moot since you're the only person complaining about this and you're on the WMF install, so adding a "[X] Use less paranoid caching that doesn't flicker all the time." option wouldn't fix the problem for you.

Oct 27 2015, 8:21 PM · Files, Wikimedia
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.
  • With height=300, yeah, it's going to be a flickery mess.
    • Without height=300, it's a flickery mess in Safari only, in the last few weeks, as far as I can tell.
Oct 27 2015, 8:01 PM · Files, Wikimedia
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

I'm pretty sure the preview case is recent (last couple weeks) and I don't think we changed anything, but I haven't hunted down what actually did change. My theory was that it was a change in Safari behavior, since I don't see this behavior in Chrome and I first observed it after applying an OSX update. Are you using Safari in OSX?

Oct 27 2015, 7:56 PM · Files, Wikimedia
epriestley edited projects for T9646: Duplicates commits after doing git reset, added: Diffusion; removed Public & Media Relations.
Oct 27 2015, 7:29 PM · Diffusion
epriestley closed T9646: Duplicates commits after doing git reset as Wontfix.

Some discussion in, e.g, T9028, but we don't plan to ever actually delete these commits. They may have comments, audit status, meaningful relationships to other objects, builds, build artifacts, etc.

Oct 27 2015, 7:29 PM · Diffusion
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 27 2015, 5:25 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 27 2015, 5:08 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Oct 27 2015, 5:08 PM · Prioritized, Drydock
epriestley triaged T9643: XHPast Parse error when extracting i18n as Wishlist priority.
Oct 27 2015, 4:47 PM · XHPAST
epriestley added a comment to T9643: XHPast Parse error when extracting i18n.

This is because externals/stripe-php/lib/Stripe/ApiRequestor.php has this on line 357:

Oct 27 2015, 4:47 PM · XHPAST
epriestley added a comment to T182: Commit into repository directly from differential.

The action is always available right now because it makes testing (particularly, testing things like "does it do the right thing when the revision is already landed") easier, but I'm going to require "Accepted" for v0 of this, which will indirectly disable it for landed ("Closed") revisions. We'll probably relax that later but it seems like the right place to start from, at least.

Oct 27 2015, 12:45 PM · Haskell.org, Restricted Project, Differential

Oct 26 2015

epriestley added a revision to T182: Commit into repository directly from differential: Restricted Differential Revision.
Oct 26 2015, 9:24 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 26 2015, 9:09 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T3277: `arc cleanup` to cleanup branches used by `arc patch`.

After T182, web-landed changes tend to leave local branches around since we never run any code on the user's machine. These are handled reasonably by arc branch, but having arc cleanup clean them up (or have an option to clean them up) might be nice.

Oct 26 2015, 8:54 PM · Arcanist
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Oct 26 2015, 8:48 PM
epriestley abandoned D14332: Test Revision.
Oct 26 2015, 8:30 PM
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 26 2015, 8:21 PM · Haskell.org, Restricted Project, Differential
epriestley closed T9519: Design the Drydock Blueprint selection mechanism as Resolved by committing Restricted Diffusion Commit.
Oct 26 2015, 7:38 PM · Drydock
epriestley closed T9519: Design the Drydock Blueprint selection mechanism, a subtask of T9252: Unprototype Drydock (v1), as Resolved.
Oct 26 2015, 7:38 PM · Prioritized, Drydock
epriestley added a comment to Image Macro "whatcouldgowrong2".

Seems educational!

Oct 26 2015, 7:31 PM
epriestley added a member for Blessed Committers: Mnkras.
Oct 26 2015, 6:24 PM
epriestley added a revision to T182: Commit into repository directly from differential: Restricted Differential Revision.
Oct 26 2015, 6:23 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 26 2015, 5:21 PM · Haskell.org, Restricted Project, Differential
epriestley closed T9632: Maximum execution time of 30 seconds exceeded as Resolved by committing Restricted Diffusion Commit.
Oct 26 2015, 4:49 PM · Paste
epriestley closed T9635: arc unit throws when there are no tests to run on PHP7 as Resolved by committing Restricted Diffusion Commit.
Oct 26 2015, 4:48 PM · Arcanist
epriestley added a revision to T9632: Maximum execution time of 30 seconds exceeded: Unknown Object (Differential Revision).
Oct 26 2015, 2:53 PM · Paste
epriestley added a comment to T9634: Have `arc land` detect latest build status and act appropriately..

arc land already does this.

Oct 26 2015, 1:40 PM
epriestley claimed T9632: Maximum execution time of 30 seconds exceeded.
Oct 26 2015, 1:12 PM · Paste
epriestley added Q179: How do you configure an Almanac based Drydock resource (Answer 223).
Oct 26 2015, 1:08 PM

Oct 25 2015

epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 25 2015, 11:23 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 25 2015, 11:08 PM · Haskell.org, Restricted Project, Differential
epriestley closed T9631: Don't crash when users fail to specify additional working copies as Resolved by committing Restricted Diffusion Commit.
Oct 25 2015, 9:53 PM
epriestley added a comment to T9631: Don't crash when users fail to specify additional working copies.

(If that sounds wrong, I can try harder to repro this.)

Oct 25 2015, 8:54 PM
epriestley added a comment to T9631: Don't crash when users fail to specify additional working copies.

Specifically, I think this was only for steps created prior to the introduction of the "Other Working Copies" field. New ones should work OK without specifying additional working copies.

Oct 25 2015, 8:54 PM
epriestley added a revision to T9631: Don't crash when users fail to specify additional working copies: Unknown Object (Differential Revision).
Oct 25 2015, 8:53 PM
epriestley added a comment to T9492: Make WorkingCopy resources more powerful and flexible.

I'm generally imagining we'll get something like this in the Blueprint configuration:

Oct 25 2015, 8:49 PM · Restricted Project, Drydock
epriestley updated subscribers of T9492: Make WorkingCopy resources more powerful and flexible.
Oct 25 2015, 8:40 PM · Restricted Project, Drydock
epriestley merged task T9630: Support submodules in Drydock working copies into T9492: Make WorkingCopy resources more powerful and flexible.
Oct 25 2015, 8:40 PM
epriestley added a comment to T9631: Don't crash when users fail to specify additional working copies.

As a workaround, editing + saving the step should populate this with an empty array. But we can be a little more defensive in the actual implementation.

Oct 25 2015, 8:39 PM
epriestley added a revision to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen: Unknown Object (Differential Revision).
Oct 25 2015, 7:27 PM · Differential
epriestley closed T9629: Allow herald to create a differtial revision, if a commit matched the conditions as Wontfix.

See T5000. I don't plan to implement this feature as described.

Oct 25 2015, 7:25 PM · Differential, Herald
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Oct 25 2015, 6:12 PM · Prioritized, Drydock
epriestley added a comment to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

Cool, glad to hear it! This is, at the very least, something we could document better. I don't think the documentation currently mentions that inlines are even a thing, much less describes the porting behavior or the rationale for it.

Oct 25 2015, 6:09 PM · Differential
epriestley added a comment to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

This feature is always going to be imperfect, but my personal experience, at least, is that something like 80-90% of inlines port somewhere reasonable (the code is still the same, or nearly the same), and I understand about half of the rest of them from context, and can click the "Rewind" button for the remaining few to see what the author was talking about if I don't remember. There are also cases where we can improve the behavior without needing to solve any hard AI problems, see T7870 for the ones we know about (it's possible that whatever you hit here is a case we could improve).

Oct 25 2015, 5:57 PM · Differential
epriestley added a comment to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

Okay, I think what you're seeing is an inline which has been ported forward. This is a feature, and an expected behavior. Here's an example of what it looks like.

Oct 25 2015, 5:44 PM · Differential
epriestley added inline comments to D14332: Test Revision.
Oct 25 2015, 5:40 PM
epriestley added a comment to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

Maybe it's easier if I try to follow your instructions. Here's what I did:

Oct 25 2015, 5:36 PM · Differential
epriestley added a comment to D14332: Test Revision.

I have reviewed "A".

Oct 25 2015, 5:34 PM
epriestley updated the diff for D14332: Test Revision.

Update with "B".

Oct 25 2015, 5:34 PM
epriestley retitled D14332: Test Revision from to Test Revision.
Oct 25 2015, 5:31 PM
epriestley added a comment to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

You can probably use rGITTEST, but just copy/pasting some random diffs into the web UI is likely sufficient in this case too (no special behavior around inlines should get triggered). You're recent enough locally that you shouldn't run into any compatibility issues.

Oct 25 2015, 5:07 PM · Differential
epriestley added a comment to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

In particular, inlines are bound to the exact diff they are left on ("line 17 of changeset 28942 on diff 1842"), not a mutable location like "line 17 on file x/y.c on the most recent diff of revision 293". For example, you can go make comments on older diffs, which would not be possible if we didn't bind them to specific changesets.

Oct 25 2015, 3:24 PM · Differential
epriestley added a comment to T9628: When viewing a diff in differential, and making comments against specific lines, the comment submitted should be against what was seen.

This is not T4768.

Oct 25 2015, 3:20 PM · Differential
jane awarded T4768: Phabricator silently overwrites concurrent changes (no conflict detection) a The World Burns token.
Oct 25 2015, 2:43 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley closed T9610: You can `bin/auth recover` a mailing list administrator, and get a confusing error when you do as Resolved by committing Restricted Diffusion Commit.
Oct 25 2015, 1:13 AM · Auth

Oct 24 2015

epriestley added a revision to T9519: Design the Drydock Blueprint selection mechanism: Unknown Object (Differential Revision).
Oct 24 2015, 7:26 PM · Drydock
epriestley moved T7441: Support OAuth providers in the cluster from Backlog to The Queue on the Prioritized board.
Oct 24 2015, 4:49 PM · Auth, Phacility
epriestley closed T8983: Tickboxes are unavailable within tables as Wontfix.

I think there's a reasonable chance we'll build a dedicated "Manual QA Workflow" / "Runbook" / "Preflight Checklist" application some day, but I'd guess not before 2017 unless things change a lot. If we had this application, you could embed workflows into tasks or other documents using {...} syntax and check them off as you worked through things.

Oct 24 2015, 3:43 PM · Remarkup
epriestley closed T9023: phabot leaks memory as Invalid.

We don't see this on this install:

Oct 24 2015, 3:37 PM · Phabot
epriestley closed T9039: AWS CodeCommit and Google Cloud Repository Support as Wontfix.

The SSH stuff should work fine. I don't anticipate supporting the HTTP stuff.

Oct 24 2015, 3:33 PM · Diffusion
epriestley moved T4863: Allow Workboard Cards to be customized for display from Backlog to Projects v3 on the Projects board.
Oct 24 2015, 3:27 PM · Projects, Workboards, Wikimedia
epriestley added a project to T4863: Allow Workboard Cards to be customized for display: Projects.
Oct 24 2015, 3:27 PM · Projects, Workboards, Wikimedia
epriestley added a comment to T182: Commit into repository directly from differential.

We had a very slow week and haven't made much progress here. There is a new list view and some new, more reasonable UI. We landed our first production change with this mechanism.

Oct 24 2015, 3:26 PM · Haskell.org, Restricted Project, Differential
epriestley closed T9598: "Send message" is not greyed out for logged-out users as Resolved by committing Restricted Diffusion Commit.
Oct 24 2015, 3:13 PM · People
epriestley renamed T9590: Subversion directory anchoring rules are unclear and underpowered from wrong incremental change with subversion commit to Subversion directory anchoring rules are unclear and underpowered.
Oct 24 2015, 3:11 PM · Differential, Subversion
epriestley added a comment to T9540: Passphrase show secret dialog does not close if conphernce sidebar is enabled..

There's some usual magic on this dialog to try to make sure the "you looked at the secret" transaction is shown to you when you close the dialog to make it more obvious that your view was logged.

Oct 24 2015, 1:45 PM · Quicksand, Passphrase
epriestley added a project to T9540: Passphrase show secret dialog does not close if conphernce sidebar is enabled.: Quicksand.
Oct 24 2015, 1:43 PM · Quicksand, Passphrase
epriestley added a revision to T9598: "Send message" is not greyed out for logged-out users: Unknown Object (Differential Revision).
Oct 24 2015, 1:41 PM · People
epriestley claimed T9598: "Send message" is not greyed out for logged-out users.
Oct 24 2015, 1:38 PM · People
epriestley claimed T9610: You can `bin/auth recover` a mailing list administrator, and get a confusing error when you do.
Oct 24 2015, 1:35 PM · Auth
epriestley added a revision to T9610: You can `bin/auth recover` a mailing list administrator, and get a confusing error when you do: Unknown Object (Differential Revision).
Oct 24 2015, 1:35 PM · Auth
epriestley added a comment to T9610: You can `bin/auth recover` a mailing list administrator, and get a confusing error when you do.

I guess I'm sort of OK with letting you make mailing lists administrators so they can pick up policy stuff. This is definitely pretty silly but maybe not only silly, and wouldn't hurt anything except for the other issues.

Oct 24 2015, 1:24 PM · Auth
epriestley moved T9622: Allow Phriction pages to have Project tags from Backlog to Next on the Phriction board.
Oct 24 2015, 1:20 PM · Projects, Phriction, Restricted Project
epriestley merged task T9624: Creating macro doesn't show macro logo in user feed into T9625: Fill in missing applications and icons on PHID types.
Oct 24 2015, 1:19 PM · Macros
epriestley merged task T9541: Ponder's small icon in user feed is sometimes missing into T9625: Fill in missing applications and icons on PHID types.
Oct 24 2015, 1:19 PM · Ponder
epriestley updated subscribers of T9625: Fill in missing applications and icons on PHID types.
Oct 24 2015, 1:19 PM · Applications
epriestley updated the task description for T9625: Fill in missing applications and icons on PHID types.
Oct 24 2015, 1:18 PM · Applications
epriestley added a revision to T9625: Fill in missing applications and icons on PHID types: Unknown Object (Differential Revision).
Oct 24 2015, 1:16 PM · Applications
epriestley added a revision to T9625: Fill in missing applications and icons on PHID types: Unknown Object (Differential Revision).
Oct 24 2015, 1:13 PM · Applications
epriestley created T9625: Fill in missing applications and icons on PHID types.
Oct 24 2015, 1:12 PM · Applications
epriestley edited the content of Changelog.
Oct 24 2015, 12:39 PM
epriestley created 2015 Week 43 (Late October).
Oct 24 2015, 12:39 PM
epriestley closed T6707: 'Attaching' two external accounts of the same type results in AphrontCountQueryException as Resolved by committing Restricted Diffusion Commit.
Oct 24 2015, 11:50 AM · Wikimedia, Auth
epriestley closed T6707: 'Attaching' two external accounts of the same type results in AphrontCountQueryException, a subtask of T2549: Support linking multiple external accounts from the same provider with one Phabricator account, as Resolved.
Oct 24 2015, 11:50 AM · Restricted Project, Restricted Project, LDAP, Auth, OAuthServer

Oct 23 2015

epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

I'm likely to restrict pause/abort but leave restart broadly available, since engineers generally won't gain anything by restarting enemy builds (it causes them to take more resources) and I think there are legitimate reasons for innocent bystanders to restart failed builds even if they don't have administrative/management powers.

Oct 23 2015, 9:14 PM · Harbormaster (v3), Restricted Project
epriestley added a revision to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds: Unknown Object (Differential Revision).
Oct 23 2015, 9:07 PM · Harbormaster (v3), Restricted Project
epriestley added a revision to T6707: 'Attaching' two external accounts of the same type results in AphrontCountQueryException: Unknown Object (Differential Revision).
Oct 23 2015, 8:03 PM · Wikimedia, Auth
epriestley added a comment to T9525: Provide a reasonable general use logo.

(T9308 is the origin story of cat1 through cat3.)

Oct 23 2015, 7:27 PM · Public & Media Relations
epriestley added a comment to T9525: Provide a reasonable general use logo.

Sadly, cats 1-2 were prototype cats showing a progression toward cat3. cat4 is a unique cat but I'm not sure it has the charm of cat3.

Oct 23 2015, 7:25 PM · Public & Media Relations
epriestley added a comment to T9525: Provide a reasonable general use logo.

cat1.png (400×400 px, 2 KB)

Oct 23 2015, 7:24 PM · Public & Media Relations
tycho.tatitscheff awarded T9378: Build Projects v3 a Love token.
Oct 23 2015, 4:13 PM · Projects (v3), Prioritized
epriestley added a comment to T5096: Create a phabricator authentication provider that uses mediawiki oauth.

Since we haven't seen any other interest in this in the meantime (although maybe you have?), keeping it external is probably best for us -- it's conceptually something that we're comfortable with, but it's conceivable that you're approximately the only install using it. We'd be open to bringing it upstream in the future if there's more widespread interest/use.

Oct 23 2015, 12:50 PM · Auth, Wikimedia
epriestley renamed Changelog from "><svg onload=alert(1)> to Changelog.
Oct 23 2015, 12:44 PM
epriestley closed T9619: "><svg onload=alert(1)> as Spite.
Oct 23 2015, 12:43 PM
epriestley closed T9618: "><svg onload=alert(1)> as Spite.
Oct 23 2015, 12:43 PM
epriestley closed T9618: "><svg onload=alert(1)>, a subtask of T9617: "><svg onload=alert(1)>, as Spite.
Oct 23 2015, 12:43 PM