Page MenuHomePhabricator

Have `arc land` detect latest build status and act appropriately.
Closed, ResolvedPublic

Description

Greetings,

Is this something that fits in with your long term vision for the project? If so, we could see about providing a pull request if you're interested.

Hopefully this GTW highlights the problem we want to solve without getting too implementation detail solution oriented :), thanks!

The Problem to Solve

Given an API that gives back a status
When a User runs arc land and the latest build has failed
Then arc land should fail w/ an explanatory note

Given an API that gives back a status
When a User runs arc land and the latest build was neither a failure or a success (e.g. is in progress, had warning but did not fail, etc)
Then arc land should output specifics and prompt the user to continue or not

Given an API that gives back a status
When a User runs arc land and the latest build was successful
Then arc land should output that fact and continue

[? Must have/nice to have/YAGNI ?]

Given an API that gives back a status
When a User runs arc land with some sort of force option and the latest build has failed
Then arc land should warn w/ an explanatory note and continue

Event Timeline

drmuey updated the task description. (Show Details)
drmuey added a subscriber: drmuey.

arc land already does this.

https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistLandWorkflow.php$1235

It also prompts you for ongoing builds.

If you're using some third-party build system, you need to report your build results into Harbormaster in Phabricator for this integration to work. See https://secure.phabricator.com/book/phabricator/article/harbormaster/, T9456, etc.

drmuey claimed this task.

Perfect, thanks! I didn't look far enough down ArcanistLandWorkflow.php appreciate the line pointer ;)