Page MenuHomePhabricator

Fill in missing applications and icons on PHID types
Closed, ResolvedPublic


Some PHIDType classes have missing application or icon specifications. Today, this primarily means that feed stories don't show icons.

After D14323, you can find PHID types with missing applications in ConfigPHID Types. PHID types which are clearly part of an application but don't show anything in the "Application" column have missing methods.

D14324 is an example of how to add a method call and test that it is correct.

These patches are straightforward. We will review and accept work here from contributors if you're looking for something easy to get started with.

By the end of this, we'll probably hit 100% coverage and then make the base method abstract to force implementation and prevent this from happening again in the future.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Applications.
epriestley added a subscriber: epriestley.