Page MenuHomePhabricator
Create Task
Maniphest T9625

Fill in missing applications and icons on PHID types
Closed, ResolvedPublic
Actions

Description

Some PHIDType classes have missing application or icon specifications. Today, this primarily means that feed stories don't show icons.

After D14323, you can find PHID types with missing applications in Config → PHID Types. PHID types which are clearly part of an application but don't show anything in the "Application" column have missing methods.

D14324 is an example of how to add a method call and test that it is correct.

These patches are straightforward. We will review and accept work here from contributors if you're looking for something easy to get started with.

By the end of this, we'll probably hit 100% coverage and then make the base method abstract to force implementation and prevent this from happening again in the future.

Revisions and Commits

rP Phabricator
D14068rP495cb7a2e037 Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
D14331rPa39ec26a672a Provide an application link for Ponder Answer PHID type
D14324rPd0098bc43626 Provide an application link for the Macro PHID type
D14323rP58957e62c1fa Show applications and icons for PHID types in config table

Related Objects

Event Timeline

epriestley created this task.Oct 24 2015, 1:12 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Applications.
epriestley added a subscriber: epriestley.
epriestley added a revision: D14323: Show applications and icons for PHID types in config table.Oct 24 2015, 1:13 PM
epriestley added a revision: D14324: Provide an application link for the Macro PHID type.Oct 24 2015, 1:16 PM
epriestley updated the task description. (Show Details)Oct 24 2015, 1:18 PM
epriestley merged tasks: T9624: Creating macro doesn't show macro logo in user feed, T9541: Ponder's small icon in user feed is sometimes missing.
epriestley added subscribers: revi, chad.
epriestley added a commit: rP58957e62c1fa: Show applications and icons for PHID types in config table.Oct 24 2015, 3:16 PM
epriestley added a commit: rPd0098bc43626: Provide an application link for the Macro PHID type.Oct 24 2015, 4:41 PM
joshuaspence added a subscriber: joshuaspence.Oct 24 2015, 8:39 PM
revi added a revision: D14331: Provide an application link for Ponder Answer PHID type.Oct 25 2015, 12:43 AM
epriestley added a commit: rPa39ec26a672a: Provide an application link for Ponder Answer PHID type.Oct 25 2015, 1:12 AM
epriestley added a revision: D14068: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract.Nov 2 2015, 1:03 PM
joshuaspence closed this task as Resolved by committing rP495cb7a2e037: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract.Nov 2 2015, 7:47 PM
joshuaspence added a commit: rP495cb7a2e037: Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract.
Herald added a subscriber: eadler. · View Herald TranscriptJun 28 2016, 1:54 PM
Phabricator · Built by Phacility