Page MenuHomePhabricator

Passphrase show secret dialog does not close if conphernce sidebar is enabled.
Open, Needs TriagePublic

Description

Steps to reproduce bug:

  1. Enable conpherence sidebar by pressing "\" keyboard shortcut.
  2. Go to passphrase, choose a credential and click "Show secret"
  3. Once secret shows up, try to click "done" to close the dialog - it doesn't close.

Related Objects

Event Timeline

vkcr created this task.Oct 9 2015, 4:44 AM
vkcr updated the task description. (Show Details)
vkcr added a project: Passphrase.
vkcr updated the task description. (Show Details)
vkcr updated the task description. (Show Details)
vkcr added a subscriber: vkcr.
epriestley added a subscriber: epriestley.

There's some usual magic on this dialog to try to make sure the "you looked at the secret" transaction is shown to you when you close the dialog to make it more obvious that your view was logged.

A simple fix would be to remove the magic, since this behavior is not too important, but I suspect there's a general mishandling of same-page navigation actions in Quicksand.

epriestley moved this task from Backlog to Conpherence on the Quicksand board.Apr 17 2017, 12:03 PM