No, this was surprising, and surprises are bad. If it could alert the user
and say "whoa there, it looks like this diff was updated while you were
commenting," that would be good -- but this was literally the exact minute.
My coworker and I were submitting within seconds of eachother. This is
definitely an edge case.

My previous employer was a 100%-on-github shop. This employer is a nearly-100%-on-phabricator shop. I will tell you I am entirely a phabricator convert. I've been using github and singing its praises for years and the last six months I've been using phabricator have been eye-opening. I love this software. :)

In T9628#141693, @epriestley wrote:

Okay, I think what you're seeing is an inline which has been ported forward. This is a feature, and an expected behavior. Here's an example of what it looks like.

So for example, if i were to go make some changes to D14333 and wait to submit those changes, and you were to comment on it, those comments would be largely meaningless after.

Oh, wait, re-reading your comment. No, I can't share the exact screenshots because it's our source, and that's proprietary. But when I commented on line 58 of the diff, and then the diff was updated as I submitted, that line actually became line 78 or whatever, and so the comment is still there on 58 or whichever, and makes no sense anymore, so the "review" of my comments on that diff are now entirely confusing and not helpful.

The comments were pinned to line numbers, and when the diff was updated, the line numbers changed, and so the comments became meaningless. This was really a problem because the diff changed substantially and the comments were important to those lines, rather than the specific files.

Yes, that is exactly what I was expecting to see. I had just now gotten a diff created. :)

I am having trouble configuring arcanist to work against this phabricator vs my "home" phabricator. Otherwise I am ready to do this.

i am not sure it works if all of those things happen with me as the sole actor.

so let's start with this revision. to reproduce, i would need to create a diff on that, and then comment on it, and while i had a session with those comments "in the air" in the web, have that diff updated, and then submit my comments.

yep, doing so now.

So I just want to add a little bit more context here:

Sure, let me see if I can do that, I'm heading in to the office now.

Actually.... Rereading, maaaaaaaybe it's the same? It would have to depend
on how the back end actually managed those revisions. If phriction treats a
wiki update the same way diffusion treats a differential update then yeah,
this is our bug.

Oh god, that's it. This has been around since 2014? :(