The change above seems to have worked around things, I'll leave this open until we can confirm that PHP 7.3.6 or some later version fixes the underlying issue.

Jun 17 2019, 6:02 PM · Infrastructure

epriestley requested review of D20584: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link to the main branch list.

Jun 17 2019, 5:53 PM

epriestley added a revision to T13312: "Branch Status" in Diffusion has a bizarre pager at the top of the element: D20584: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link to the main branch list.

Jun 17 2019, 5:52 PM · Diffusion

epriestley requested review of D20583: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes.

Jun 17 2019, 5:42 PM

epriestley committed rPd3112392d1e8: Allow "Sign with MFA" to be applied as a comment action without requiring… (authored by epriestley).

Allow "Sign with MFA" to be applied as a comment action without requiring…

Jun 17 2019, 5:41 PM

epriestley closed D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT".

Jun 17 2019, 5:41 PM

epriestley closed T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission as Resolved by committing rPd3112392d1e8: Allow "Sign with MFA" to be applied as a comment action without requiring….

Jun 17 2019, 5:41 PM · Auth

epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20583: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes.

Jun 17 2019, 5:40 PM · Transactions

epriestley requested review of D20582: Consider "msort()" on "PhutilSortVector" objects to be an error.

Jun 17 2019, 5:37 PM

epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20582: Consider "msort()" on "PhutilSortVector" objects to be an error.

Jun 17 2019, 5:36 PM · Transactions

epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

uhoh looks like I'm a dum dum

Jun 17 2019, 5:33 PM · Transactions

epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

This is doing somewhat better now, but I've still seen:

Jun 17 2019, 5:23 PM · Transactions

epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

In the Discourse thread (https://discourse.phabricator-community.org/t/how-to-have-a-shallow-git-mirror/2805/) the reporting user also reported that this patch worked in their (illegal, forbidden) use case.

Jun 17 2019, 5:20 PM

D20580: When triggering audits, respect committer identities when importing commits is now accepted and ready to land.

Jun 17 2019, 5:17 PM

D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT" is now accepted and ready to land.

Jun 17 2019, 5:17 PM

epriestley requested review of D20581: Respect repository identities when selecting author vs auditor actions.

Jun 17 2019, 5:13 PM

epriestley added a revision to T13311: Audit code does not fully respect committer identities as commit authors: D20581: Respect repository identities when selecting author vs auditor actions.

Jun 17 2019, 5:11 PM · Diffusion

epriestley requested review of D20580: When triggering audits, respect committer identities when importing commits.

Jun 17 2019, 5:06 PM

epriestley added a revision to T13311: Audit code does not fully respect committer identities as commit authors: D20580: When triggering audits, respect committer identities when importing commits.

Jun 17 2019, 5:04 PM · Diffusion

epriestley requested review of D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes.

Jun 17 2019, 4:52 PM

epriestley added a revision to T13313: "Download Raw Diff" may fail in a misleading way after failing to engage the chunk engine if the raw diff is larger than 4MB: D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes.

Jun 17 2019, 4:51 PM · Differential, Files

epriestley created T13314: Poke around `bin/repository update` and chase off any ghosts.

Jun 17 2019, 4:06 PM · Diffusion

epriestley created T13313: "Download Raw Diff" may fail in a misleading way after failing to engage the chunk engine if the raw diff is larger than 4MB.

Jun 17 2019, 2:40 PM · Differential, Files

epriestley added a comment to T13312: "Branch Status" in Diffusion has a bizarre pager at the top of the element.

If this table is retained, there's a mystery meat "branch" icon meaning "default branch" in the leftmost column. This should get a label/tip.

Jun 17 2019, 2:31 PM · Diffusion

epriestley created T13312: "Branch Status" in Diffusion has a bizarre pager at the top of the element.

Jun 17 2019, 2:30 PM · Diffusion

Jun 15 2019

epriestley committed rP64a95000788d: Add "bin/file migrate" options to support import of a local-disk backup for… (authored by epriestley).

Add "bin/file migrate" options to support import of a local-disk backup for…

Jun 15 2019, 3:12 PM

epriestley closed D20571: Add "bin/file migrate" options to support import of a local-disk backup for Phacility instances.

Jun 15 2019, 3:12 PM

epriestley added a comment to D20571: Add "bin/file migrate" options to support import of a local-disk backup for Phacility instances.

(I'm going to land this as-is so I can move PHI1295 forward.)

Jun 15 2019, 3:08 PM

Jun 14 2019

epriestley created T13311: Audit code does not fully respect committer identities as commit authors.

Jun 14 2019, 4:02 PM · Diffusion

epriestley requested review of D20578: Don't require users be logged in to access the Logout controller, so users with no Spaces can log out.

Jun 14 2019, 12:00 AM

Jun 13 2019

epriestley added a revision to T13310: Users with no access to Spaces can not log out: D20578: Don't require users be logged in to access the Logout controller, so users with no Spaces can log out.

Jun 13 2019, 11:59 PM · Auth, Spaces

epriestley created T13310: Users with no access to Spaces can not log out.

Jun 13 2019, 11:49 PM · Auth, Spaces

epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Minor wordsmithing.

Jun 13 2019, 11:35 PM

epriestley requested review of D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Jun 13 2019, 11:33 PM

epriestley added a revision to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone: D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Jun 13 2019, 11:31 PM · Diffusion

epriestley added a comment to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.

The shallow <hash> frames can not advertise capabilities.

Jun 13 2019, 11:28 PM · Diffusion

epriestley added a comment to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.

Here's what goes over the wire:

Jun 13 2019, 10:46 PM · Diffusion

epriestley added a comment to T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.

To reproduce this, you can:

Jun 13 2019, 10:42 PM · Diffusion

epriestley created T13309: Git protocol proxy can not parse protocol frames if repository on disk is a shallow clone.

Jun 13 2019, 10:42 PM · Diffusion

epriestley added a revision to T13308: Phacility account import flow can misfire when both invites and account links are present: Unknown Object (Differential Revision).

Jun 13 2019, 10:15 PM · Phacility

epriestley added a comment to T13308: Phacility account import flow can misfire when both invites and account links are present.

To reproduce the first issue, do this:

Jun 13 2019, 8:43 PM · Phacility

epriestley created T13308: Phacility account import flow can misfire when both invites and account links are present.

Jun 13 2019, 8:23 PM · Phacility

epriestley added a revision to T13146: Phacility account import tool fails to recognize usernames with differing case, e.g. "Alice" vs "alice": Unknown Object (Differential Revision).

Jun 13 2019, 8:10 PM · Phacility

Jun 11 2019

epriestley updated the task description for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.

Jun 11 2019, 6:18 PM · Arcanist, Differential

Jun 6 2019

epriestley added a comment to D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT".

Ignore this, test.

Jun 6 2019, 2:35 AM

epriestley requested review of D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT".

Jun 6 2019, 2:25 AM

epriestley added a project to T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission: Auth.

Jun 6 2019, 2:23 AM · Auth

epriestley added a revision to T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission: D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT".

Jun 6 2019, 2:23 AM · Auth

epriestley created T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission.

Jun 6 2019, 2:18 AM · Auth

epriestley added a subtask for T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window!: T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

Jun 6 2019, 1:58 AM · Quicksand, Feature Request, Workboards

epriestley added a parent task for T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window!.

Jun 6 2019, 1:58 AM · Quicksand

epriestley renamed T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it from With Quicksand enabled, "Choose Subtype" dialog on "Create Subtask" workflow is not dismissed by making a selection to When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

Jun 6 2019, 1:57 AM · Quicksand

epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

D20573 will fix this, but perhaps not in the most graceful way possible.

Jun 6 2019, 1:56 AM · Quicksand

epriestley requested review of D20573: When a user clicks a navigation link in a dialog, close the dialog.

Jun 6 2019, 1:52 AM

epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: D20573: When a user clicks a navigation link in a dialog, close the dialog.

Jun 6 2019, 1:50 AM · Quicksand