Page MenuHomePhabricator
Feed Advanced Search

Mar 23 2017

epriestley added a comment to T12442: Build PhrictionPortal.

One other thought as a sort of counterpoint to myself: if we do implement T11367, I probably would expect it to work more like "portals", where you define a portal/directory/volume and everything inside it shares the same permissions. But that's because I'd plan to eventually build DefinitelyNotDropbox.app for bridging file directories to the desktop so you could mount the filesystem on your computer as a disk, and I think we get into enormous amounts of trouble if I mount the phacility_tax_documents/ drive locally and then individual files inside it might have individual permissions so I couldn't view or edit some of them, since there's no way we can give users guidance about that from a filesystem mount. But maybe we have more flexibility there than I think.

Mar 23 2017, 12:22 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I think we could just add spaces without any real fuss, yeah. Two possible considerations:

Mar 23 2017, 12:15 AM · Phriction
chad merged T12442: Build PhrictionPortal into T9379: Build Phriction v3.
Mar 23 2017, 12:13 AM · Phriction
chad merged task T12442: Build PhrictionPortal into T9379: Build Phriction v3.
Mar 23 2017, 12:12 AM · Phriction
chad added a comment to T12442: Build PhrictionPortal.

Ok I think this is mostly a UI issue then, and I didn't think this entirely through. Also, spaces then should just work?

Mar 23 2017, 12:10 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I do think we could make a product argument like "the hierarchical permissions system is too complicated for users to understand, and they'd be better off with a less powerful system". That might look like:

Mar 23 2017, 12:08 AM · Phriction
chad added a comment to T12442: Build PhrictionPortal.

(this is a problem for me switching on and off projects, haha, I forget design decisions)

Mar 23 2017, 12:08 AM · Phriction
chad added a comment to T12442: Build PhrictionPortal.

I probably solved most of this with my Phriction redesign which visually treated child pages as navigation.

Mar 23 2017, 12:08 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I think PhrictionPortal probably doesn't look too much different from "make a second wiki, except this time you don't have permission to edit the root document, and it's locked to public / all users visibility automatically, and it's at some other URL other than /w/, and remarkup has two different rules".

Mar 23 2017, 12:03 AM · Phriction

Mar 22 2017

chad added a comment to T12442: Build PhrictionPortal.

Hmmmmm, so this essentially exists but you have to make /w/ public in order to achieve it?

Mar 22 2017, 11:45 PM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

When I create a second portal ("Encyclopedia of Fruit") and a page ("Orange"), what URL does the page exist at?

Mar 22 2017, 11:42 PM · Phriction
chad renamed T12435: Add support for Spaces in Phriction from Add support for spaces in phriction to Add support for spaces in Phriction.
Mar 22 2017, 11:20 PM · Phriction, Feature Request
chad added a subtask for T12442: Build PhrictionPortal: T12435: Add support for Spaces in Phriction.
Mar 22 2017, 11:20 PM · Phriction
chad created T12442: Build PhrictionPortal.
Mar 22 2017, 11:19 PM · Phriction
kristo.mario added a comment to T12435: Add support for Spaces in Phriction.

Yeah, we kind of fake that now by offering an index page on Phriction welcome with major projects being there on "root" level.

Mar 22 2017, 9:32 PM · Phriction, Feature Request
chad added a project to T12435: Add support for Spaces in Phriction: Phriction.
Mar 22 2017, 9:20 PM · Phriction, Feature Request

Mar 6 2017

eliaspro added a comment to T5380: Better handling of anchored links in Phriction.

I'd love to see anchor indicators when hovering headings.

Mar 6 2017, 9:38 PM · Phriction, Remarkup

Mar 4 2017

epriestley closed T12352: Table of conent should be visible in beginning of the page as Invalid.

Sorry, this isn't a feature request we can accept. See Support Resources for help understanding what kind of support is available, and Contributing Feature Requests for help with feature requests.

Mar 4 2017, 11:11 AM · Phriction, Feature Request
SvHu updated the task description for T12352: Table of conent should be visible in beginning of the page .
Mar 4 2017, 9:36 AM · Phriction, Feature Request
SvHu created T12352: Table of conent should be visible in beginning of the page .
Mar 4 2017, 9:33 AM · Phriction, Feature Request

Mar 3 2017

epriestley merged task T12345: Links in titles into T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Mar 3 2017, 1:24 PM · Phriction, Bug Report
jnobel created T12345: Links in titles.
Mar 3 2017, 12:46 PM · Phriction, Bug Report
cspeckmim renamed T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Relative links to Phriction pages mis-encode URL-encoded characters to Relative links to Phriction pages misinterprets URL-encoded characters.
Mar 3 2017, 3:15 AM · Phriction, Remarkup, Bug Report
cspeckmim created T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Mar 3 2017, 3:13 AM · Phriction, Remarkup, Bug Report

Feb 22 2017

chad closed T12303: Print View in Phriction shows Persistent Chat as Resolved by committing rP254ee82a0c9d: Hide Conpherence durable column when printing.
Feb 22 2017, 8:31 PM · Phriction, Bug Report
chad added a revision to T12303: Print View in Phriction shows Persistent Chat: D17395: Hide Conpherence durable column when printing.
Feb 22 2017, 5:44 PM · Phriction, Bug Report

Feb 21 2017

Mnkras created T12303: Print View in Phriction shows Persistent Chat.
Feb 21 2017, 8:26 PM · Phriction, Bug Report

Feb 2 2017

robertos added a comment to T12193: Allow mentions to work in Phriction edit notes.

That sounds good to me.

Feb 2 2017, 7:51 PM · Phriction, Feature Request
epriestley added a comment to T12193: Allow mentions to work in Phriction edit notes.

I think it would be reasonable to treat this field as remarkup (at least, internally -- probably no bulky UI) so we end up generating a mention on the task. I have similar reservations about making "fixes X" start performing magic in surprising contexts.

Feb 2 2017, 7:50 PM · Phriction, Feature Request
chad renamed T12193: Allow mentions to work in Phriction edit notes from Task references in Phriction edit notes should work like references in commit messages to Allow mentions to work in Phriction edit notes.
Feb 2 2017, 7:27 PM · Phriction, Feature Request

Dec 22 2016

rfreebern added a comment to T3963: Templates in Phriction.

P2028 is a really quick bookmarklet that will pull the content of a given Phriction document and insert it into the current Phriction edit page's textarea. Hopefully it'll save a few clicks for those of us who write lots of pages with a similar structure.

Dec 22 2016, 2:33 PM · Phriction
rfreebern created P2028 Quick and dirty Phriction template bookmarklet.
Dec 22 2016, 2:28 PM · Phriction

Dec 12 2016

epriestley closed T4448: Support symlinking phriction pages as Invalid.

This is pretty old and doesn't meet the requirements of a modern feature request (notably, clear definition of a root problem). Feel free to file a new request if this is still an issue. Particularly helpful would be discussion of why editing the page to say "Go see <other page>" is insufficient.

Dec 12 2016, 9:47 PM · Restricted Project, Phriction

Nov 29 2016

chad added a comment to T11928: Risk of losing work when creating a new document while editing a Phriction page .

(Also, I can't reproduce this.)

Nov 29 2016, 5:24 PM · Phriction, Bug Report
chad added a comment to T11928: Risk of losing work when creating a new document while editing a Phriction page .

Generally there shouldn't bee a "New <object>" on edit object pages. I think this goes away with EditEngine.

Nov 29 2016, 3:26 PM · Phriction, Bug Report
chad merged task T11928: Risk of losing work when creating a new document while editing a Phriction page into T11440: Drafts for unsaved objects.
Nov 29 2016, 3:16 PM · Phriction, Bug Report
timor created T11928: Risk of losing work when creating a new document while editing a Phriction page .
Nov 29 2016, 2:45 PM · Phriction, Bug Report

Nov 24 2016

stevex added a comment to T7205: Cannot delete Phriction document.

I also had the same problem and solved in the same way!...

Nov 24 2016, 2:27 PM · Phriction

Nov 10 2016

epriestley removed a project from T9379: Build Phriction v3: Prioritized.

I'm going to kick this out of the queue for now and we'll reconsider it alongside other internal priorities once the queue clears. I think it's probably secondary to Conpherence now, at least, product-roadmap-wise, maybe?

Nov 10 2016, 5:12 PM · Phriction

Nov 6 2016

dseifert created T11825: Prose diffs unusable for changes with large blocks of unmodified text.
Nov 6 2016, 8:08 PM · Remarkup, Bug Report

Oct 26 2016

ogoletti added a watcher for Phriction: ogoletti.
Oct 26 2016, 7:35 AM

Oct 21 2016

kouahab added a comment to T8594: Develop system for dumping/backing up Phriction documents.

@epriestley , do you have an example of how one can use 'arc call-conduit phriction.query' ?

Oct 21 2016, 3:49 AM · Phriction, Restricted Project

Oct 18 2016

gd merged task T8708: Undefined variable: message when trying to move a phriction page to a lower level into T8082: Exception when moving Phriction document into place of old one.
Oct 18 2016, 1:01 PM · Phriction, Restricted Project
gd merged T8708: Undefined variable: message when trying to move a phriction page to a lower level into T8082: Exception when moving Phriction document into place of old one.
Oct 18 2016, 1:01 PM · Restricted Project, Support Impact, Phriction
gd closed T8082: Exception when moving Phriction document into place of old one, a subtask of T9379: Build Phriction v3, as Resolved.
Oct 18 2016, 11:58 AM · Phriction
gd closed T8082: Exception when moving Phriction document into place of old one as Resolved by committing rP4e831e786e7a: Fix Phriction document move on to existing document placeholder.
Oct 18 2016, 11:58 AM · Restricted Project, Support Impact, Phriction

Oct 17 2016

gd added a revision to T8082: Exception when moving Phriction document into place of old one: D16713: Fix Phriction document move on to existing document placeholder.
Oct 17 2016, 1:21 PM · Restricted Project, Support Impact, Phriction

Oct 7 2016

fooishbar added a comment to T3353: Make Phriction Document changes reviewable.
In T3353#196761, @chad wrote:

Can you do that today with view and edit policy?

Oct 7 2016, 9:49 AM · Restricted Project, Prioritized, Phriction

Oct 4 2016

chad added a comment to T3353: Make Phriction Document changes reviewable.

Can you do that today with view and edit policy?

Oct 4 2016, 2:24 PM · Restricted Project, Prioritized, Phriction
fooishbar added a comment to T3353: Make Phriction Document changes reviewable.
  • Text/Phriction Inline Comments: See T1894 for followup. I'll update this shortly in light of T7643.
Oct 4 2016, 2:14 PM · Restricted Project, Prioritized, Phriction

Sep 23 2016

ReynoldsCahoon updated Q494: Is there a way to query only wiki edits/updates in the past week? from to Is there a way to query only wiki edits/updates in the past week?.
Sep 23 2016, 6:23 PM · Dashboards, Maniphest, Phriction

Sep 11 2016

chad closed T11614: Inconsistency at phriction as Resolved.
Sep 11 2016, 8:53 PM · Phriction, Bug Report
chad closed D16537: Fixed inconsistency at phriction by committing rP9e4bca834510: Fixed inconsistency at phriction (authored by Luke081515.2).
Sep 11 2016, 8:41 PM · Phriction
Luke081515.2 added a comment to D16537: Fixed inconsistency at phriction.

@chad Can you land this revision yourself, or give me the permissions to do so? I'm currently not able too :-/

Sep 11 2016, 7:35 PM · Phriction
chad accepted D16537: Fixed inconsistency at phriction.

thanks!

Sep 11 2016, 6:06 PM · Phriction
Luke081515.2 updated the test plan for D16537: Fixed inconsistency at phriction.
Sep 11 2016, 1:06 PM · Phriction
Luke081515.2 updated the diff for D16537: Fixed inconsistency at phriction.
  • Fixed issue pointed out by @chad
Sep 11 2016, 1:04 PM · Phriction
chad added inline comments to D16537: Fixed inconsistency at phriction.
Sep 11 2016, 1:10 AM · Phriction
Luke081515.2 added a comment to D16537: Fixed inconsistency at phriction.

hm, ok, that was the reason. I don't checked that, sorry. Feel free to comandeer that rev, and upload a better patch.

Sep 11 2016, 1:01 AM · Phriction
chad added a comment to D16537: Fixed inconsistency at phriction.

Did you click "Submit" and verify the tag you specified was on the document?

Sep 11 2016, 12:53 AM · Phriction
Luke081515.2 added a comment to D16537: Fixed inconsistency at phriction.

At least it did what I wanted, and it worked without an error:
Before:

before.PNG (551×288 px, 9 KB)

After:
after.PNG (492×236 px, 6 KB)

Sep 11 2016, 12:39 AM · Phriction
chad requested changes to D16537: Fixed inconsistency at phriction.

This shouldn't work, since your changing the variable name as well below, but not above to write the changes. I'd expect this to not record the tag.

Sep 11 2016, 12:36 AM · Phriction
avivey added a comment to D16537: Fixed inconsistency at phriction.

Did you try to actually set a project tag with this change? I'm pretty sure it wouldn't work.

Sep 11 2016, 12:08 AM · Phriction

Sep 10 2016

chad added a comment to D16537: Fixed inconsistency at phriction.

This works?

Sep 10 2016, 10:42 PM · Phriction
Luke081515.2 retitled D16537: Fixed inconsistency at phriction from to Fixed inconsistency at phriction.
Sep 10 2016, 10:15 PM · Phriction
Luke081515.2 added a revision to T11614: Inconsistency at phriction: D16537: Fixed inconsistency at phriction.
Sep 10 2016, 10:15 PM · Phriction, Bug Report
Luke081515.2 added a comment to T11614: Inconsistency at phriction.

Going to upload a fix myself.

Sep 10 2016, 9:49 PM · Phriction, Bug Report
Luke081515.2 created T11614: Inconsistency at phriction.
Sep 10 2016, 9:48 PM · Phriction, Bug Report

Sep 9 2016

chad closed T9294: Phriction document-created email notifications do not include Edit Notes as Resolved by committing rPb056b7f174b5: Add edit notes to Phriction emails.
Sep 9 2016, 2:18 AM · Phriction
chad closed T10131: Wiki pages are not completely print friendly as Resolved by committing rPd7bc58253073: Printable pages for PHUIDocumentViewPro.
Sep 9 2016, 2:14 AM · Feature Request, Phriction
chad added a revision to T9294: Phriction document-created email notifications do not include Edit Notes: D16526: Add edit notes to Phriction emails.
Sep 9 2016, 2:13 AM · Phriction
chad closed T9622: Allow Phriction pages to have Project tags, a subtask of T9379: Build Phriction v3, as Resolved.
Sep 9 2016, 1:50 AM · Phriction
chad closed T9622: Allow Phriction pages to have Project tags as Resolved.
Sep 9 2016, 1:50 AM · Projects, Phriction, Restricted Project
chad added a revision to T10131: Wiki pages are not completely print friendly: D16524: Printable pages for PHUIDocumentViewPro.
Sep 9 2016, 1:48 AM · Feature Request, Phriction

Sep 5 2016

wohthan added a comment to T10149: Export of Phriction document.

How about subpages? It would be really useful to be able to print out / export an entire hierarchy with one click.

Sep 5 2016, 8:43 AM · Phriction, Feature Request

Aug 17 2016

chad added a revision to T11478: Build PHUICMSView: D16414: Rough in Guides Application.
Aug 17 2016, 4:36 PM · Design, PHUI, Phriction

Aug 15 2016

chad created T11478: Build PHUICMSView.
Aug 15 2016, 7:55 PM · Design, PHUI, Phriction
chad added a comment to T11475: Allow users to bulk-change visibility and editability policies for Phriction documents.

I'm vaguely assuming this should work reading the code for PhrictionDocument.

Aug 15 2016, 5:37 PM · Phriction, Feature Request
chad added a project to T11475: Allow users to bulk-change visibility and editability policies for Phriction documents: Phriction.

See T4675#57776 for a local workaround for now.

Aug 15 2016, 5:32 PM · Phriction, Feature Request

Aug 10 2016

epriestley merged T11455: Facing Problem with Index into T8552: Increase user control over document hierarchy in Phriction.
Aug 10 2016, 1:09 PM · Phriction, Restricted Project

Aug 8 2016

chad added a comment to T1894: Support commenting on Phriction documents.

There's a separate task floating around for making Phirction changes reviewable. I think that should be separate from this task to keep things lightweight.

Aug 8 2016, 11:00 PM · Restricted Project, Restricted Project, Phriction
isfs added a comment to T1894: Support commenting on Phriction documents.

No! I hadn't noticed it, sorry. I've had a look now and will endeavour to give some specific comments over there later. I don't think the 'addressing comments in multiple updates' will be a problem, though.

Aug 8 2016, 10:36 PM · Restricted Project, Restricted Project, Phriction
chad added a comment to T1894: Support commenting on Phriction documents.

Did you check out the mock in Pholio?

Aug 8 2016, 10:01 PM · Restricted Project, Restricted Project, Phriction
isfs added a comment to T1894: Support commenting on Phriction documents.

It's vaguely possible we could use a bunch of Javascript to try to capture the path that an edit takes and then submit it alongside the new text to track inlines, like Docs/Word do, but without implementing WYSIWYG. I suspect this would still be very complicated.

Aug 8 2016, 9:42 PM · Restricted Project, Restricted Project, Phriction
chad added 1 mock(s) for T1894: Support commenting on Phriction documents: M1466: Phriction v3.
Aug 8 2016, 9:21 PM · Restricted Project, Restricted Project, Phriction
chad added a comment to T1894: Support commenting on Phriction documents.

I've taken a pass at this in the design on Phriction v3, and it's top level comments only. The comment pane by default is hidden, but expandable. You can see comments on previous versions, and pull them up separately. I think this is a reasonable place to start over inline commenting and trying to recreate Dropbox/Quip/Google Docs, etc.

Aug 8 2016, 9:21 PM · Restricted Project, Restricted Project, Phriction
chad renamed T1894: Support commenting on Phriction documents from Support commenting (top-level and/or inline) on Phriction documents to Support commenting on Phriction documents.
Aug 8 2016, 9:19 PM · Restricted Project, Restricted Project, Phriction
chad added a parent task for T1894: Support commenting on Phriction documents: T9379: Build Phriction v3.
Aug 8 2016, 9:19 PM · Restricted Project, Restricted Project, Phriction
chad added a subtask for T9379: Build Phriction v3: T1894: Support commenting on Phriction documents.
Aug 8 2016, 9:19 PM · Phriction
chad moved T1894: Support commenting on Phriction documents from Backlog to Next on the Phriction board.
Aug 8 2016, 9:18 PM · Restricted Project, Restricted Project, Phriction
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

Ok, I'll mock it out.

Aug 8 2016, 5:37 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

When you click the pencil icon next to the "Hierarchy" item, you get to a page like this one:

Aug 8 2016, 5:33 PM · Phriction, Restricted Project
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

Where is that checkbox?

Aug 8 2016, 5:30 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

(I'm hoping there's no real use case for "show some other arbitrary page's navigation", although who knows.)

Aug 8 2016, 5:30 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

I'm hoping to get away with two options, e.g. a checkbox like this:

Aug 8 2016, 5:29 PM · Phriction, Restricted Project
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

Can I select which page I pull my hierarchy from? I think that works for cases where you want the navigation to be persistent among the children, to just always pull from parent hierarchy.

Aug 8 2016, 5:23 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

Yeah -- the specific change I'd expect is basically that this:

Aug 8 2016, 4:43 PM · Phriction, Restricted Project
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

So just to understand your point, instead of having pre-selectable layouts, we ship just 1 level by default and anything else is custom?

Aug 8 2016, 4:42 PM · Phriction, Restricted Project
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

My intent was to basically port over a customizeable nav list like we already use in AphrontNav everywhere, label, item, spacer, and have that basically editable and re-usable. I want to take a pass at something similar for /home/ so we're looking at all the use cases before building anything.

Aug 8 2016, 4:38 PM · Phriction, Restricted Project
epriestley closed T7783: phriction diffs don't default to remarkup as Wontfix.

These use the prose algorithm now, and I don't plan to try to implement syntax highlighting for prose diffs.

Aug 8 2016, 4:36 PM · Remarkup, Phriction