Paths

Table of Contentst

Add edit notes to Phriction emails
ClosedPublic
Actions

Authored by chad on Sep 9 2016, 2:13 AM.

Tags

None

Referenced Files

	F15465589: D16526.id.diff
	Wed, Apr 2, 8:59 PM

	F15462365: D16526.diff
	Tue, Apr 1, 2:32 PM

	F15412338: D16526.id39769.diff
	Wed, Mar 19, 12:31 PM

	F15407533: D16526.id39771.diff
	Tue, Mar 18, 6:09 PM

	F15391542: D16526.id39769.diff
	Sat, Mar 15, 10:26 AM

	F15333471: D16526.id39771.diff
	Sat, Mar 8, 2:30 AM

	F15317703: D16526.diff
	Thu, Mar 6, 7:46 PM

	Unknown Object (File)
	Feb 18 2025, 11:43 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T9294: Phriction document-created email notifications do not include Edit Notes

Commits

rPb056b7f174b5: Add edit notes to Phriction emails

Summary

Fixes T9294. Adds edit notes.

Test Plan

Edit a document, see notes in email.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39769.Sep 9 2016, 2:13 AM

chad retitled this revision from to Add edit notes to Phriction emails.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9294: Phriction document-created email notifications do not include Edit Notes.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2016, 2:13 AM

epriestley accepted this revision.Sep 9 2016, 2:15 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/phriction/editor/PhrictionTransactionEditor.php
433	Prefer `if(strlen($description))` so the common and informative description "0" works correctly.

This revision is now accepted and ready to land.Sep 9 2016, 2:15 AM

Closed by commit rPb056b7f174b5: Add edit notes to Phriction emails (authored by chad, committed by chad). · Explain WhySep 9 2016, 2:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

7 lines

Diff 39771

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Add edit notes to Phriction emailsClosedPublicActions