Page MenuHomePhabricator

Add edit notes to Phriction emails
ClosedPublic

Authored by chad on Sep 9 2016, 2:13 AM.
Tags
None
Referenced Files
F12840744: D16526.id39771.diff
Thu, Mar 28, 8:42 PM
Unknown Object (File)
Wed, Mar 20, 4:53 PM
Unknown Object (File)
Feb 18 2024, 2:12 PM
Unknown Object (File)
Feb 7 2024, 10:32 PM
Unknown Object (File)
Feb 3 2024, 11:53 AM
Unknown Object (File)
Jan 24 2024, 2:59 AM
Unknown Object (File)
Dec 17 2023, 5:19 AM
Unknown Object (File)
Dec 16 2023, 4:11 PM
Subscribers

Details

Summary

Fixes T9294. Adds edit notes.

Test Plan

Edit a document, see notes in email.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add edit notes to Phriction emails.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phriction/editor/PhrictionTransactionEditor.php
433

Prefer if(strlen($description)) so the common and informative description "0" works correctly.

This revision is now accepted and ready to land.Sep 9 2016, 2:15 AM
This revision was automatically updated to reflect the committed changes.