Page MenuHomePhabricator

Fixed inconsistency at phriction
ClosedPublic

Authored by Luke081515.2 on Sep 10 2016, 10:15 PM.

Details

Summary
  • All Applications are useing the description "Tags", Phriction actually uses "Projects"
  • Changed "Projects" to "Tags" for phriction

Ref T11614

Test Plan
  • Edited a document, took a look at the description for that input line
  • Added a project to a page and saved it

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Luke081515.2 retitled this revision from to Fixed inconsistency at phriction.
Luke081515.2 updated this object.
Luke081515.2 edited the test plan for this revision. (Show Details)
Luke081515.2 added a project: Phriction.

Did you try to actually set a project tag with this change? I'm pretty sure it wouldn't work.

chad requested changes to this revision.Sep 11 2016, 12:36 AM
chad added a reviewer: chad.

This shouldn't work, since your changing the variable name as well below, but not above to write the changes. I'd expect this to not record the tag.

This revision now requires changes to proceed.Sep 11 2016, 12:36 AM

At least it did what I wanted, and it worked without an error:
Before:

before.PNG (551×288 px, 9 KB)

After:
after.PNG (492×236 px, 6 KB)

Did you click "Submit" and verify the tag you specified was on the document?

hm, ok, that was the reason. I don't checked that, sorry. Feel free to comandeer that rev, and upload a better patch.

src/applications/phriction/controller/PhrictionEditController.php
252

just change setName back to projects and it should work again. this field isn't visible to users.

Luke081515.2 edited edge metadata.
  • Fixed issue pointed out by @chad
Luke081515.2 edited edge metadata.
Luke081515.2 marked an inline comment as done.
chad edited edge metadata.

thanks!

This revision is now accepted and ready to land.Sep 11 2016, 6:06 PM

@chad Can you land this revision yourself, or give me the permissions to do so? I'm currently not able too :-/

This revision was automatically updated to reflect the committed changes.