Support bulk editing object policies and other fields with complex UI controls
Open, WishlistPublic
Actions

Assigned To

None

Authored By

	shadowhand
	Mar 25 2014, 6:19 PM

Description

The bulk editor currently does not support adjusting object policies, so you can't use it to (for example) change the visibility of a large number of tasks.

After T10973, the bulk editor side of this is fairly easy. The UI side -- where we need to render a policy selector control dynamically in pure Javascript -- is not.

In the meantime, a possible workaround is that all modern *.edit API methods do support policy editing, so you may be able to use the API, rather than the bulk editor, to make sweeping policy changes.

The bulk editor doesn't support setting custom date field values. This is also a control problem, but this can be supported with a simple variation of the control (just a text field) until the fancy version (with the calendar picker) gets built.

See PHI2070.

Originally

The action menu in the bulk editor has no option for "Change Policy" / "Change Visibility" / etc

Screenshot_2014-03-25_13.18.15.png (191×179 px, 18 KB)

Revisions and Commits

rP Phabricator
	Abandoned	D8677 Halp - how get policy control into batch editor?

Related Objects
Search...

		Status	Assigned	Task
		Resolved	None	T10005 Implement an ApplicationEditor-based Bulk Editor
		Open	None	T4675 Support bulk editing object policies and other fields with complex UI controls

Event Timeline

shadowhand created this task.Mar 25 2014, 6:19 PM

shadowhand raised the priority of this task from to Needs Triage.

shadowhand updated the task description. (Show Details)

shadowhand added a project: Maniphest.

shadowhand added a subscriber: shadowhand.

We should add "Change view policy" and "Change edit policy" actions here. I think these are straightforward.

btrahan edited this Maniphest Task.Apr 2 2014, 6:37 PM

I found the tricky part.... :) See D8677

Aside from being a bit of a corner / long tail case, implementing this is tricky business - see D8677. As such, putting to low priority and will circle back eventually.

In D8677, @epriestley mentioned a 5 line script to bulk adjust policies - any chance of this being made available and/or made part of the command line tools? I'm planning on making my phab install a bit more public, but would like to make most of the old tasks/revisions only visible within the core team.

You should be able to do something like this:

<?php

require_once 'scripts/__init_script__.php';

foreach (id(new LiskMigrationIterator(new ManiphestTask()) as $task) {
  $id = $task->getID();
  echo "Updating task {$id}...\n";

  $task->setViewPolicy(/* Policy Goes Here */);

  // uncomment this when satisfied with the script behavior, to persist changes
  // $task->save();
}

Drop that in phabricator/ and run it with php -f script.php.

To figure out what the policy value should be, set some task to the desired policy, then examine the row in the database: SELECT viewPolicy FROM phabricator_maniphest.maniphest_task WHERE id = 123456

Gracias!

<?php

require_once 'scripts/__init_script__.php';

foreach (id(new LiskMigrationIterator(new ManiphestTask())) as $task) {
  $id = $task->getID();
  echo "Updating task {$id}...\n";

  $task->setViewPolicy(/* Policy Goes Here */);

  // uncomment this when satisfied with the script behavior, to persist changes
  // $task->save();
}

Slight syntax correction, for the record.

◀ Merged tasks: T5898.

michaeloa awarded a token.Aug 18 2014, 4:54 PM

btrahan removed btrahan as the assignee of this task.Sep 12 2014, 8:02 PM

btrahan added a subscriber: btrahan.

• supervacuo added a subscriber: • supervacuo.Oct 24 2014, 12:14 PM

Hanni87 added a subscriber: Hanni87.Jan 30 2015, 3:06 PM

• porcoesphino added a subscriber: • porcoesphino.Mar 5 2015, 6:30 AM

zacchiro added a subscriber: zacchiro.Oct 29 2015, 3:25 PM

chad mentioned this in T9645: Allow Herald to change task policys and spaces.Oct 29 2015, 4:03 PM

chad merged a task: T9731: Support setting view and edit policies in the batch editor.Nov 8 2015, 5:28 AM

chad added a subscriber: hach-que.

epriestley added a parent task: T10005: Implement an ApplicationEditor-based Bulk Editor.Dec 16 2015, 9:45 PM

Kwisatz added a subscriber: Kwisatz.Mar 27 2016, 3:35 PM

Herald added a subscriber: eadler. · View Herald TranscriptMar 27 2016, 3:35 PM

Sam2304 added a subscriber: Sam2304.May 10 2016, 1:41 PM

chad mentioned this in T11475: Allow users to bulk-change visibility and editability policies for Phriction documents.Aug 15 2016, 5:32 PM

• tomekj2ee awarded a token.May 25 2017, 8:17 PM

• tomekj2ee added a subscriber: • tomekj2ee.

tbrown_SFC added a subscriber: tbrown_SFC.Oct 3 2017, 4:07 PM

spawnlt awarded a token.Oct 6 2017, 10:10 AM

spawnlt added a subscriber: spawnlt.

epriestley mentioned this in T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support.Nov 28 2017, 5:14 PM

epriestley renamed this task from Maniphest batch editor does not allow bulk modification of visibility to Support bulk editing object policies.Jan 19 2018, 11:03 PM

epriestley lowered the priority of this task from Low to Wishlist.

epriestley updated the task description. (Show Details)

epriestley edited projects, added ApplicationEditor; removed Maniphest.

timor awarded a token.Sep 4 2018, 12:10 PM

timor added a subscriber: timor.

hskiba added a subscriber: hskiba.Jun 4 2019, 1:21 AM

Herald added a subscriber: amckinley. · View Herald TranscriptJun 4 2019, 1:21 AM

Kwisatz awarded a token.Apr 22 2020, 6:02 PM

epriestley renamed this task from Support bulk editing object policies to Support bulk editing object policies and other fields with complex UI controls.Apr 30 2021, 3:35 PM