Page MenuHomePhabricator
Feed Advanced Search

Dec 28 2016

epriestley merged T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url into T10517: Make Harbormaster build variables extensible.
Dec 28 2016, 4:30 PM · Harbormaster, Restricted Project, Feature Request
epriestley merged task T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url into T10517: Make Harbormaster build variables extensible.
Dec 28 2016, 4:30 PM · Harbormaster, Feature Request
epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

I'm going to merge this into T10517 which discusses making build variables extensible. See that task for some more discussion of similar issues.

Dec 28 2016, 4:30 PM · Harbormaster, Feature Request
epriestley closed T12044: Upgrading phabricator resulted in excess tables/table data as Resolved.

Yes, this is consistent with running bin/storage upgrade from master, then switching to stable.

Dec 28 2016, 4:27 PM · Bug Report (Needs Information)
epriestley added a comment to T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].

From a cursory read of CVE-2016-10045, it seems like PHP may be written in such a way that mail() can not be invoked safely. Silly PHP!

Dec 28 2016, 8:11 AM · Mail, Security

Dec 27 2016

epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

If this was available as a variable, wouldn't you have to make all those changes to Harbormaster build plans anyway? Why is it impossible to change the plans to use a constant, but possible to change them to use a variable?

Dec 27 2016, 8:02 PM · Harbormaster, Feature Request
epriestley edited the content of 2016 Week 52 (Very Late December).
Dec 27 2016, 7:54 PM
epriestley edited the content of 2016 Week 52 (Very Late December).
Dec 27 2016, 7:54 PM
epriestley created 2016 Week 52 (Very Late December).
Dec 27 2016, 6:42 PM
epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

Why does this need to be a variable? That is, why can't you just hard-code the value in place of having a variable?

Dec 27 2016, 5:56 PM · Harbormaster, Feature Request

Dec 26 2016

epriestley lowered the priority of T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045] from High to Low.

This appears to be the fix:

Dec 26 2016, 4:51 PM · Mail, Security
epriestley added a comment to T1837: Implement correct send-as-user behavior..

Note that there is a Sender-related RCE in PHPMailer until Dec 2016, see T12046 for discussion.

Dec 26 2016, 4:37 PM · llvm, Restricted Project, Mail
epriestley created T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].
Dec 26 2016, 4:14 PM · Mail, Security
epriestley closed T12045: Commandeered revisions do not show original author as "Authored By" as Wontfix.

Although this wording is a little unclear, commandeering makes you the author. A more precise wording would be something like "The current author for this revision is X. It was created on Y." but that's clunky and only smooths out this particular case.

Dec 26 2016, 4:08 PM · Bug Report

Dec 24 2016

epriestley added a comment to T12044: Upgrading phabricator resulted in excess tables/table data.

Can you show us the output of these commands?

Dec 24 2016, 6:13 PM · Bug Report (Needs Information)

Dec 23 2016

epriestley renamed T12038: Harbormaster scheduling should be more predictable from Harbourmaster scheduling should be more predictable. to Harbormaster scheduling should be more predictable.
Dec 23 2016, 10:19 PM · Harbormaster, Haskell.org, Feature Request
epriestley added a comment to T12038: Harbormaster scheduling should be more predictable.

See some discussion starting here:

Dec 23 2016, 10:19 PM · Harbormaster, Haskell.org, Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

Yes. I think we had a similar element at some point, but removed it in a design update some time ago because it felt visually busy/redundant, particularly across other object types. If you do a lot of copy/pasting into Google Docs, the utility might overwhelm the visual repetition, though.

Dec 23 2016, 10:07 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

This will link both:

Dec 23 2016, 9:59 PM · Feature Request
epriestley closed T12043: Link task number and title for easier referencing via copy & paste as Wontfix.

Concretely, since this is presumably about the WMF install and you already maintain patches, this is the one-line edit required to make the change you're asking for:

Dec 23 2016, 9:45 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

One vague idea is that it may be possible to use a Google Docs plugin. The "Google Apps Script" development environment was a bit of a test in patience the last time I used it, but basically you can write "Add-Ons" and publish them to the "Google Apps Store", and then users can install them. This is sort of the starting point:

Dec 23 2016, 9:19 PM · Feature Request
epriestley closed T12039: Emails from Diffusion contain space or new line character in link making them not clickable as Resolved.

After D17103, at HEAD of master:

Dec 23 2016, 7:57 PM · Bug Report
epriestley closed T12040: Make version reporting more clear when running a fork as Resolved by committing Restricted Diffusion Commit.
Dec 23 2016, 7:42 PM · Support, Documentation
epriestley closed T12040: Make version reporting more clear when running a fork, a subtask of T12039: Emails from Diffusion contain space or new line character in link making them not clickable, as Resolved.
Dec 23 2016, 7:42 PM · Bug Report
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

I think the scenario is:

Dec 23 2016, 7:37 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

Oh, and D15263 was specifically to improve double-click behavior, although that was just me rather than external users (I double-click to select frequently).

Dec 23 2016, 7:34 PM · Feature Request
epriestley updated subscribers of T12043: Link task number and title for easier referencing via copy & paste.

@chad, you may have thoughts on this or remember related product stuff better than I do.

Dec 23 2016, 7:31 PM · Feature Request
epriestley added a revision to T12040: Make version reporting more clear when running a fork: Unknown Object (Differential Revision).
Dec 23 2016, 4:34 PM · Support, Documentation
epriestley merged T12042: Allow requiring signing of the latest legalpad version into T5505: Plan Legalpad v2.
Dec 23 2016, 3:02 PM · Restricted Project, Restricted Project
epriestley merged task T12042: Allow requiring signing of the latest legalpad version into T5505: Plan Legalpad v2.
Dec 23 2016, 3:02 PM · Restricted Project, Feature Request
epriestley added a comment to T12042: Allow requiring signing of the latest legalpad version.

Yeah, I'm just going to merge this into T5505 since I think it's a subset of the first feature discussed there. This will probably be the major feature in the next iteration of Legalpad, since I think it's the most obvious thing we're missing:

Dec 23 2016, 3:02 PM · Restricted Project, Feature Request
epriestley updated subscribers of T11989: Wage an endless war against HP Printer Fax Support.

Users @techhelpuk and @antivirussupportuk each created one new Calendar event this morning, offering help with anti-virus software instead of printers and encouraging users to call new numbers.

Dec 23 2016, 2:49 PM · Abuse

Dec 22 2016

epriestley created T12040: Make version reporting more clear when running a fork.
Dec 22 2016, 5:31 PM · Support, Documentation
epriestley added a comment to T12039: Emails from Diffusion contain space or new line character in link making them not clickable.

Hmm, I don't see that one in the upstream either. Maybe your origin is also a fork?

Dec 22 2016, 5:26 PM · Bug Report
epriestley added a comment to T12039: Emails from Diffusion contain space or new line character in link making them not clickable.

What does this show, when run in your local working copy?

Dec 22 2016, 4:27 PM · Bug Report
epriestley added a project to T12032: Make sure Chrome 55 anchor issue does not impact Differential: Bug Report (Needs Information).
Dec 22 2016, 2:04 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley edited projects for T12033: Large diffs can still repeatedly fail to insert, added: Bug Report, Differential, Diffusion, Mail; removed Bug Report (Needs Information).
Dec 22 2016, 2:01 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report

Dec 21 2016

epriestley added a subtask for T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion: T12033: Large diffs can still repeatedly fail to insert.
Dec 21 2016, 10:03 PM · Diffusion (v3), Differential, Mail
epriestley added a parent task for T12033: Large diffs can still repeatedly fail to insert: T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Dec 21 2016, 10:03 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Also, is metamta.email-body-limit set to something crazy? I think that only means main-body (not body + attachments) right now, but it should probably mean body + attachments + headers.

Dec 21 2016, 9:57 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Oh, never mind, that's the Differential patch responding to the commit, so metamta.diffusion.byte-limit isn't relevant.

Dec 21 2016, 9:49 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Thanks, I'll take a more in-depth look at this.

Dec 21 2016, 9:47 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T11114: Move Differential to EditEngine.

JIRA actually seems fine: arc, web UI, and both the integrations (link / post) work properly for me at HEAD of master.

Dec 21 2016, 9:25 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley updated the task description for T11114: Move Differential to EditEngine.
Dec 21 2016, 9:24 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
pouyana awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Dec 21 2016, 4:40 PM · Conpherence (v4)
epriestley closed T12037: reboot after SD card is removed as Invalid.
Dec 21 2016, 2:19 PM · Bug Report

Dec 20 2016

avivey awarded T11114: Move Differential to EditEngine a Dat Boi token.
Dec 20 2016, 9:47 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12035: Diffusion URI without trailing slash redirects to login page as Resolved by committing Restricted Diffusion Commit.
Dec 20 2016, 3:48 PM · Diffusion, Bug Report
epriestley added a comment to T12035: Diffusion URI without trailing slash redirects to login page.

Thanks, I think D17097 should fix this. It isn't intended, and is just a curious artifact of some other behaviors.

Dec 20 2016, 1:54 PM · Diffusion, Bug Report
epriestley claimed T12035: Diffusion URI without trailing slash redirects to login page.
Dec 20 2016, 1:54 PM · Diffusion, Bug Report
epriestley added a revision to T12035: Diffusion URI without trailing slash redirects to login page: Unknown Object (Differential Revision).
Dec 20 2016, 1:43 PM · Diffusion, Bug Report
epriestley edited projects for T12033: Large diffs can still repeatedly fail to insert, added: Bug Report (Needs Information); removed Bug Report.

Alright, I'm actually having trouble reproducing this. Here's what I tried:

Dec 20 2016, 1:27 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a project to T12032: Make sure Chrome 55 anchor issue does not impact Differential: Phacility.
Dec 20 2016, 1:00 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley added a comment to T12032: Make sure Chrome 55 anchor issue does not impact Differential.

I wasn't immediately able to reproduce this:

Dec 20 2016, 1:00 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

I strongly suspect this report has enough information to let us replicate the issue locally, so you don't need to take any further action yet. I'll follow up if I have difficulty replicating it and we can figure out what differs between my synthetic test case and your real environment.

Dec 20 2016, 12:42 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley claimed T12033: Large diffs can still repeatedly fail to insert.
Dec 20 2016, 12:40 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
vcrom awarded T4900: Workboards updating in real time a Like token.
Dec 20 2016, 9:48 AM · Workboards (v3), User Delight, Wikimedia

Dec 19 2016

epriestley created T12032: Make sure Chrome 55 anchor issue does not impact Differential.
Dec 19 2016, 9:35 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley closed T12031: PhabricatorProjectWorkboardProfilePanel still defined in legacy database upgrade code as Resolved by committing Restricted Diffusion Commit.
Dec 19 2016, 8:53 PM · Installing & Upgrading, Bug Report
eadler awarded T11114: Move Differential to EditEngine a Mountain of Wealth token.
Dec 19 2016, 7:10 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T10308: Bring back links to task lists on project pages; List name of assignee in workboard cards as Wontfix.

You can create your own link to tasks in a few seconds; the extension above will reduce this further. I don't plan to bring a global, hard-coded "Open Tasks" link to the upstream.

Dec 19 2016, 6:57 PM · Projects (v3), Feature Request
epriestley added a comment to T12031: PhabricatorProjectWorkboardProfilePanel still defined in legacy database upgrade code.

(2) and (3) are correct.

Dec 19 2016, 6:22 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T12030: Make Quick Create Menu configurable via MenuItem.

I think global + personal makes sense -- we'd want to put stuff like "New Bug Report" / "New Feature Request" there on this install, I think.

Dec 19 2016, 5:23 PM · Profile Menu Item

Dec 18 2016

cspeckmim awarded T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist a Hungry Hippo token.
Dec 18 2016, 3:38 AM · Diffusion (v3), Arcanist, Differential

Dec 16 2016

epriestley added a comment to T12029: Analysis workflows for Unit Tests information.

I think these are all reasonable things to want to do.

Dec 16 2016, 9:21 PM · Restricted Project, Harbormaster, Feature Request
epriestley updated the task description for T11114: Move Differential to EditEngine.
Dec 16 2016, 8:41 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 8:33 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

I see cat :)

Dec 16 2016, 7:22 PM · Customer Impact, Diffusion, Bug Report
epriestley edited the content of Changelog.
Dec 16 2016, 6:30 PM
epriestley renamed 2016 Week 51 (Late December) from 2016 Week 51 (Mid December) to 2016 Week 51 (Late December).
Dec 16 2016, 6:30 PM
epriestley created 2016 Week 51 (Late December).
Dec 16 2016, 6:29 PM
epriestley updated the task description for T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist.
Dec 16 2016, 6:20 PM · Diffusion (v3), Arcanist, Differential
epriestley updated the task description for T11114: Move Differential to EditEngine.
Dec 16 2016, 6:07 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 6:07 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 6:01 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
avivey awarded T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision" a 100 token.
Dec 16 2016, 5:54 PM · Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:51 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:49 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:42 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:40 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:32 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:20 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:19 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:15 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 5:12 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley merged T12028: Describe which email preference caused the email into T10448: Modularize mail tags.
Dec 16 2016, 5:10 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T12028: Describe which email preference caused the email into T10448: Modularize mail tags.
Dec 16 2016, 5:10 PM · Feature Request
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 3:27 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 3:25 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision": Unknown Object (Differential Revision).
Dec 16 2016, 3:19 PM · Differential
epriestley created T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".
Dec 16 2016, 3:16 PM · Differential
epriestley updated the task description for T11114: Move Differential to EditEngine.
Dec 16 2016, 3:13 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 3:12 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 3:09 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 2:58 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 2:53 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 2:52 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 16 2016, 2:49 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T12026: Replace "apply patch" Differential advice with comprehensive instructions on "Download Raw Diff": Unknown Object (Differential Revision).
Dec 16 2016, 2:27 PM · Differential
epriestley created T12026: Replace "apply patch" Differential advice with comprehensive instructions on "Download Raw Diff".
Dec 16 2016, 2:25 PM · Differential