Page MenuHomePhabricator
Create Task
Maniphest T12031

PhabricatorProjectWorkboardProfilePanel still defined in legacy database upgrade code
Closed, ResolvedPublic
Actions

Description

How to reproduce?

  1. Take a December 2015 installation, upgrade database schema with bin/storage upgrade
  2. Upgrade will complain PhabricatorProjectWorkboardProfilePanel doesn't exist anymore.

Issues

The file resources/sql/autopatches/20160122.project.1.boarddefault.php contains the following values:

Original variableValue at rP9f56a014e2Proposed new variable
PhabricatorProjectWorkboardProfilePanel::PANELKEYproject.workboardPhabricatorProject::ITEM_WORKBOARD PhabricatorProjectWorkboardProfileMenuItem::MENUITEMKEY
PhabricatorProject::PANEL_WORKBOARDproject.workboardPhabricatorProject::ITEM_WORKBOARD
PhabricatorProfilePanelConfiguration::VISIBILITY_DEFAULTdefaultPhabricatorProfileMenuItemConfiguration::VISIBILITY_DEFAULT

Commit rP8480776cc is the one for the ProfilePanelConfiguration → ProfileMenuItemConfiguration rename.

Revisions and Commits

rP Phabricator
D17094rP178466b82618 Fix 20160122.project.1.boarddefault.php database upgrade patch

Related Objects

Event Timeline

dereckson created this task.Dec 19 2016, 6:03 PM
dereckson added a revision: D17094: Fix 20160122.project.1.boarddefault.php database upgrade patch.
epriestley added a subscriber: epriestley.Dec 19 2016, 6:22 PM

Thanks!

(2) and (3) are correct.

I believe (1) should be PhabricatorProjectWorkboardProfileMenuItem::MENUITEMKEY.

These constants have the same value, so using the "wrong" constant still gets the right result, but PhabricatorProjectWorkboardProfileMenuItem::MENUITEMKEY is the more-correct constant.

epriestley mentioned this in D17094: Fix 20160122.project.1.boarddefault.php database upgrade patch.Dec 19 2016, 6:23 PM
dereckson updated the task description. (Show Details)Dec 19 2016, 8:47 PM
epriestley closed this task as Resolved by committing rP178466b82618: Fix 20160122.project.1.boarddefault.php database upgrade patch.Dec 19 2016, 8:53 PM
epriestley added a commit: rP178466b82618: Fix 20160122.project.1.boarddefault.php database upgrade patch.
Phabricator · Built by Phacility