In T9908#148602, @joshuaspence wrote:It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Dec 31 2015
Dec 31 2015
I'm happy to send a diff over, but my design skills are quite lacking. How would.you think that the project tagd should be displayed? For example, suppose that a task is tagged with project X, Y and Z and is being viewed as a worknoard card for the board of project X. I'd say that we should show either Y or Z (as X is implied), but I'm not sure which should be preferred.
Projects displayed on workboard cards. We usually end up doing "[PROJECT] Title" as a workaround.
Is this available for prioritization?
Dec 29 2015
Dec 29 2015
eklitzke awarded T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings a Mountain of Wealth token.
Dec 28 2015
Dec 28 2015
Dec 25 2015
Dec 25 2015
joshuaspence added a project to T10052: Harbormaster events are not listed in the Feed application: Harbormaster.
Dec 23 2015
Dec 23 2015
joshuaspence added a comment to T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it.
Ah, I figured it out by just pressing each letter of the keyboard sequentially.
joshuaspence closed T9954: Cannot change a fulfiled promise to rejected as Resolved by committing Restricted Diffusion Commit.
joshuaspence added a revision to T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function: Unknown Object (Differential Revision).
joshuaspence added a revision to T9954: Cannot change a fulfiled promise to rejected: Unknown Object (Differential Revision).
Dec 22 2015
Dec 22 2015
joshuaspence awarded T9952: Let "Land Revision" target branches other than master a Like token.
joshuaspence edited projects for T9954: Cannot change a fulfiled promise to rejected, added: libphutil; removed Differential, Bug Report.
I'm going to see if I can make libphutil compatible with this library which might involve some hackery such as in D14523.
Dec 21 2015
Dec 21 2015
joshuaspence added a comment to T10029: PhabricatorRepositoryGitCommitChangeParserWorker is unable to find a commit.
I thought that it should still work because I'm running the repository pull daemon on the worker host?
joshuaspence added a comment to T10029: PhabricatorRepositoryGitCommitChangeParserWorker is unable to find a commit.
Sure, I get that... But the import is failing even on the instance running without the --no-discovery flag.
joshuaspence added a comment to T10029: PhabricatorRepositoryGitCommitChangeParserWorker is unable to find a commit.
I don't think that would fix the deadlock issue, which seems to be the root cause?
joshuaspence added a comment to T10029: PhabricatorRepositoryGitCommitChangeParserWorker is unable to find a commit.
Seeing this on the repository host:
Nevermind, this was my fault... the webserver was running a different version of the codebase than the rest of the cluster.
joshuaspence added a comment to T10026: The objects you have listed include objects which do not exist.
Nevermind, this was my fault... the webserver was running a different version of the codebase than the rest of the cluster.
joshuaspence added a comment to T10026: The objects you have listed include objects which do not exist.
echo '{ids: [29252]}' | arc call-conduit differential.query
{ "error": null, "errorMessage": null, "response": [ { "activeDiffPHID": "PHID-DIFF-jljg7seerlxdwpqmctef", "authorPHID": "PHID-USER-abzwhc667osh5mwd4gk7", "auxiliary": { "jira.issues": [], "phabricator:depends-on": [ "PHID-DREV-2qrid2heomsyqknvz6ig" ], "phabricator:projects": [] }, "branch": "master", "ccs": [], "commits": [], "dateCreated": "1450064608", "dateModified": "1450349113", "diffs": [ "590952", "590180", "589937" ], "hashes": [ [ "gtcm", "77b01130662887c1a7b5b15a6c04ddf0aa63820d" ], [ "gttr", "bb2e97dcd67904e02fea4ac9643b6467f48aa6af" ] ], "id": "29252", "lineCount": "567", "phid": "PHID-DREV-7cs76mhttnhp7homxd4l", "repositoryPHID": "PHID-REPO-e7qvu3z7a3uhk7akjy7y", "reviewers": [ "PHID-PROJ-cbz6xwpsmzwa4oqodzqg", "PHID-USER-5vh6hvh4jprplkbupz7g" ], "sourcePath": "/home/josh/workspace/REDACTED/", "status": "0", "statusName": "Needs Review", "summary": "REDACTED", "testPlan": "`arc lint --everything`", "title": "REDACTED", "uri": "https://phabricator.redacted.com/D29252" } ] }
joshuaspence added a comment to T10026: The objects you have listed include objects which do not exist.
> arc amend --trace libphutil loaded from '/usr/src/libphutil/src'. arcanist loaded from '/usr/src/arcanist/src'. Config: Reading user configuration file "/home/josh/.arcrc"... Config: Did not find system configuration at "/etc/arcconfig". Working Copy: Reading .arcconfig from "/home/josh/workspace/REDACTED/.arcconfig". Working Copy: Path "/home/josh/workspace/REDACTED" is part of `git` working copy "/home/josh/workspace/REDACTED". Working Copy: Project root is at "/home/josh/workspace/REDACTED". Config: Did not find local configuration at "/home/josh/workspace/REDACTED/.git/arc/config". Loading phutil library from '/home/josh/workspace/REDACTED/support/flarc/src'... >>> [0] <conduit> user.whoami() <bytes = 117> >>> [1] <http> https://phabricator.redacted.com/api/user.whoami <<< [1] <http> 2,570,538 us <<< [0] <conduit> 2,572,524 us >>> [2] <exec> $ git diff --no-ext-diff --no-textconv --raw 'HEAD' -- >>> [3] <exec> $ git ls-files --others --exclude-standard <<< [2] <exec> 309,152 us <<< [3] <exec> 442,695 us >>> [4] <exec> $ git diff-files --name-only <<< [4] <exec> 161,257 us >>> [5] <exec> $ git rev-parse --verify HEAD^ <<< [5] <exec> 17,530 us >>> [6] <exec> $ git rev-parse 'HEAD' <<< [6] <exec> 22,073 us >>> [7] <exec> $ git log --first-parent --format=medium 'HEAD^'..'d83b73a78e5ffea324c3948866988112837f342b' <<< [7] <exec> 5,918 us >>> [8] <conduit> differential.query() <bytes = 177> >>> [9] <http> https://phabricator.redacted.com/api/differential.query <<< [9] <http> 623,208 us <<< [8] <conduit> 623,581 us >>> [10] <conduit> differential.getcommitmessage() <bytes = 166> >>> [11] <http> https://phabricator.redacted.com/api/differential.getcommitmessage <<< [11] <http> 727,894 us <<< [10] <conduit> 728,127 us >>> [12] <conduit> differential.query() <bytes = 143> >>> [13] <http> https://phabricator.redacted.com/api/differential.query <<< [13] <http> 578,351 us <<< [12] <conduit> 578,568 us Amending commit message to reflect revision D29252: REDACTED. >>> [14] <exec> $ git commit --amend --allow-empty -F '/tmp/e8ccn3ifj3wc8cko/13791-sHgYHg' <<< [14] <exec> 203,644 us
joshuaspence added a comment to T10026: The objects you have listed include objects which do not exist.
The exception is correct in that the reviewers field contains garbage:
Dec 19 2015
Dec 19 2015
joshuaspence added a project to T10009: phabricator and maniphest should recognize links to themselves: Maniphest.
Dec 18 2015
Dec 18 2015
Thanks for the quick fix.
Dec 17 2015
Dec 17 2015
joshuaspence updated the task description for T10005: Implement an ApplicationEditor-based Bulk Editor.
Dec 16 2015
Dec 16 2015
joshuaspence awarded T10000: Consider restoring Clowncopterize a Pterodactyl token.
Not sure if trolling...
Dec 15 2015
Dec 15 2015
Can you provide steps on how to reproduce this bug, it's not clear from your report. See Contributing Bug Reports.
I don't understand the request. In any case, see Describing Root Problems.
joshuaspence added a project to T9987: Diffs in a task should be sorted by the dependency tree: Maniphest.
Dec 13 2015
Dec 13 2015
In T9908#148901, @chad wrote:I can reproduce it on Windows 10 / Chrome, but not Mac / Chrome.
In T9908#148885, @chad wrote:Doesn't reproduce for me on Mac at least, should I be testing something more specific?
In T9908#148607, @epriestley wrote:It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.
I can't reproduce this. Does it reproduce for you on this install?
In T9908#148608, @chad wrote:A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?
This doesn't reproduce for me, can you provide more details? It just goes down the select list (and I have to hit <enter> to make it trigger)
joshuaspence updated the task description for T9861: Daemon PhabricatorTaskmasterDaemon throws alot of exceptions.
Dec 12 2015
Dec 12 2015
I've often told people that they can use arc land --hold to inspect the changes before they are pushed (mostly for people who were not completely trusting of arc land. Whilst this is still technically true, I suspect that many people would not know what git push origin HEAD:master does (I personally had never seen this command before this task). It might be useful to output some sort of "Next Step" text when using arc land --hold.
joshuaspence renamed T9973: `arc land` detached head state with `--hold` from `arc lan`d detached head state with `--hold` to `arc land` detached head state with `--hold`.
joshuaspence renamed T9973: `arc land` detached head state with `--hold` from arc land detached head state with --hold to `arc lan`d detached head state with `--hold`.
In T9908#148607, @epriestley wrote:It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.
I can't reproduce this. Does it reproduce for you on this install?
In T9908#148608, @chad wrote:A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?
This doesn't reproduce for me, can you provide more details? It just goes down the select list (and I have to hit <enter> to make it trigger)
I noticed a few minor issues after deploying this on our install.
Dec 10 2015
Dec 10 2015
I don't know how exactly, but this error is related to T1116. Basically, adding this code fixes the described issue:
Hmm, actually... I think this is the fault of a custom extension I am using to upload files to S3.
joshuaspence updated the task description for T9945: Unable to delete owner packages, it does not implement PhabricatorDestructibleInterface.
joshuaspence added a project to T9946: Not adding archived owner packages as auditors on audits: Owners.
Dec 9 2015
Dec 9 2015
joshuaspence added projects to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff: Arcanist, Harbormaster.
Dec 9 2015, 10:07 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
Dec 7 2015
Dec 7 2015
Dec 6 2015
Dec 6 2015
For what it's worth, I think that this is a reasonable request. I think that the only way to implement this would be to use a custom message which would be specified in the .arclint file. For example:
joshuaspence awarded T8707: Task descriptions with leading newlines are not preserved correctly across edits a Heartbreak token.
joshuaspence added a comment to T8707: Task descriptions with leading newlines are not preserved correctly across edits.
Nice.
Dec 4 2015
Dec 4 2015
Dec 3 2015
Dec 3 2015
joshuaspence added a comment to T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.
I'll see if I can come up with a reproduction case.
Dec 2 2015
Dec 2 2015
greggrossmeier awarded T6549: Backup codes for multi-factor authentication a Love token.
See also T9640 for tracking PHP7 compatibility.
Dec 1 2015
Dec 1 2015
joshuaspence closed T9715: Prevent upgrade scripts from being run multiple times simultaneously as Resolved by committing Restricted Diffusion Commit.
joshuaspence renamed T9876: Arcanist filename linter's regex should be configurable from Arcanist filename linter's regex should be configurable. to Arcanist filename linter's regex should be configurable.
joshuaspence added a project to T9876: Arcanist filename linter's regex should be configurable: Lint.
Nov 29 2015
Nov 29 2015
joshuaspence closed T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function as Resolved by committing Restricted Diffusion Commit.
joshuaspence renamed T9871: Some PHUI form controls do not have identifiable "disabled" states from Some PHUI form controls do not have identifiable "disabled'" states to Some PHUI form controls do not have identifiable "disabled" states.
Nov 28 2015
Nov 28 2015
In T9848#145894, @OCram wrote:Hmm strange, I do not use any md5 function. I simply copied the ArcanistTextLinter and changed it to work with files containing \r\n line ends. Thats the reason why I do not know where the md5 function all or the variables come from ^^
Nov 27 2015
Nov 27 2015
Nov 26 2015
Nov 26 2015