Page MenuHomePhabricator
Create Task
Maniphest T9871

Some PHUI form controls do not have identifiable "disabled" states
Closed, ResolvedPublic
Actions

Description

With ApplicationEditor/EditEngine, form controls may be locked (causing them to render disabled) and form controls are rendered as disabled in the form preview in the "edit an edit form" UI.

Some controls like the policy controls, tokenizers, and remarkup control do not have an identifiable "disabled" state: they don't appear visually disabled, and in some cases still support interactions.

They should not: all controls should visually appear disabled, and be nonresponsive in their disabled states.

Revisions and Commits

rP Phabricator
D14814rPa07a06ab0895 Give custom controls passable disabled states

Related Objects
Search...

StatusAssignedTask
 OpenNoneT9303 Improve Phacility Onboarding/NUX
 ResolvedepriestleyT7673 Make "Log Out" on Phacility instances behave in a way better aligned with user expectation
 OpenNoneT7303 Provide OAuth access to Conduit
 OpenNoneT13201 Develop a more comprehensive approach for previews/drafts on edit screens
 OpenepriestleyT4768 Phabricator silently overwrites concurrent changes (no conflict detection)
 ResolvedepriestleyT6226 Conduit-created task always results in [Reopened] tag in the email subject
 WontfixepriestleyT1394 Support creating audits with inline comments through the API
 ResolvedbtrahanT6262 Create a new Phriction document via Conduit interface
 ResolvedepriestleyT6501 Expose project icons and other metadata through project.query
 ResolvedepriestleyT10512 Implement `user.search` Conduit API method
 ResolvedepriestleyT5873 Update Conduit for ApplicationTransactions, CustomFields and Edges
 DuplicateNoneT7794 Differential revision list "draft notification" bubble should ignore deleted drafts
 ResolvedNoneT5031 Draft Comment Persists After Submission
 ResolvedepriestleyT10034 Plan the future of Maniphest task relationships
 ResolvedNoneT7820 Add "Closed, Duplicate" option to Status Action in Maniphest
 ResolvedepriestleyT8434 Accommodate the "Security" workflow
 OpenNoneT4316 Allow a comment to be added on the Maniphest edit interface
 InvalidNoneT9238 Field-level policy controls are not made clear in the UI
 ResolvedNoneT9527 Confusing "... shifted this object from the S1 Public space to..."
 ResolvedepriestleyT9132 Build an ApplicationEditor abstraction
 ResolvedNoneT9871 Some PHUI form controls do not have identifiable "disabled" states

Event Timeline

epriestley created this task.Nov 29 2015, 5:40 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: ApplicationEditor.
epriestley added a subscriber: epriestley.
joshuaspence renamed this task from Some PHUI form controls do not have identifiable "disabled'" states to Some PHUI form controls do not have identifiable "disabled" states.Nov 29 2015, 8:18 PM
joshuaspence added a subscriber: joshuaspence.
epriestley moved this task from Backlog to v1 on the ApplicationEditor board.Dec 16 2015, 9:41 PM
epriestley mentioned this in T10004: ApplicationEditor Errata.
epriestley added a revision: D14814: Give custom controls passable disabled states.Dec 17 2015, 9:32 PM
epriestley closed this task as Resolved by committing rPa07a06ab0895: Give custom controls passable disabled states.Dec 17 2015, 11:13 PM
epriestley added a commit: rPa07a06ab0895: Give custom controls passable disabled states.
• GoogleLegacy added a subscriber: • GoogleLegacy.Sep 10 2018, 9:34 AM
Phabricator · Built by Phacility