I think that the issue was that the timestamp on parser.yacc.hpp was older than the timestamp on parser.y. I'm not really sure how git handles timestamps but likely they aren't preserved.

I guess git doesn't preserve timestamps... I just worked around this by running rm support/xhpast/* && git reset --hard HEAD && ./scripts/build_xhpast.php.

(Happy to implement this if it is desirable for the upstream)

I'm going to merge this into T5155 because I imagine that will be the way in which this is resolved.

Lol

I applied a patch locally in an attempt to troubleshoot this issue:

I applied the following change locally. I'm not convinced that it is the most correct solution, but it seems to have worked for our install:

I guess the issue is knowing which test engine to run... Okay so a file in __tests__/ changes, do I need to invoke the PHP tests or the JS tests? Given the repository structure of this project we could probably just change the regex from \\.php$ to ^src/. Longer term, I wanted a way to map files to tests in a much more flexible way, such as mapping ^src/lint/linter/__tests__/xml/ to src/lint/linter/__tests__/ArcanistXmlLinterTestCase.php.

How about something like this?

In T9254#133768, @epriestley wrote:

It seems sort-of-nice-to-have to have the raw version, maybe.

Not sure if it would be desirable but perhaps Arcanist would override libphutil's --xprofile and wrap around it to provide the suggested functionality? This is probably too magical. arc --upload-xprofile seems reasonable.

Thanks, good explanation.

Feel free to ignore me if you don't have the time to explain, but what's the difference between an edge and an object. More specifically, why do we want badges to be objects rather than edges?

This task made for a good read.

Yeah I would appreciate a shortcut to downloading files at times. Often I will attach some sort of binary file to a task, and when I want to download it I would see benefit in doing this directly from the task without clicking through to the file.

What does Badge Awarded mean?

Interesting idea, I haven't really considered Arcanist integrations for compiled languages.