Page MenuHomePhabricator

XUnitTestEngine: remove OpenSSL dependency (use uniqid)
Open, Needs TriagePublic

Description

XUnitTestEngine has the following snippet of code:

protected function buildTestFuture($test_assembly) {
    // FIXME: Can't use TempFile here as xUnit doesn't like
    // UNIX-style full paths. It sees the leading / as the
    // start of an option flag, even when quoted.
    $xunit_temp = Filesystem::readRandomCharacters(10).'.results.xml';

Filesystem::readRandomCharacters introduces an annoying extra PHP setup under Window (which is to enable openssl extension).

It seems that could be fixed by using uniqid() or md5(uniqid()) or similar.