Page MenuHomePhabricator

ArcanistUnitConsoleRenderer assumes that any unit test result without a timestamp runs in "<1ms"
Open, LowPublic

Description

If you look in [[ https://github.com/phacility/arcanist/blob/1a3afa44297f8268410797dc5195a51068ceb908/src/unit/renderer/ArcanistUnitConsoleRenderer.php#L76-L92 | ArcanistUnitConsoleRenderer.php ]], you can see that the renderer defaults to ' <1ms' for time, even if no time was provided.

This would look better if it simply returned a blank string if $seconds is null or 0, as some reporters do not have the ability to tell how many seconds a test has been running for.

Event Timeline

Dru89 raised the priority of this task from to Needs Triage.
Dru89 updated the task description. (Show Details)
Dru89 added a project: Arcanist.
Dru89 added a subscriber: Dru89.