Page MenuHomePhabricator
Feed Advanced Search

Jun 19 2015

btrahan awarded D13363: Modularize Celerity postprocessors a Like token.
Jun 19 2015, 10:07 PM
avivey awarded T4139: Add support for desktop notifications a Manufacturing Defect? token.
Jun 19 2015, 9:44 PM · Aphlict
btrahan accepted rP65853817690d: Merge branch 'master' into redesign-2015.
Jun 19 2015, 9:40 PM
btrahan accepted rP7d7e13d79b86: Merge branch 'master' into redesign-2015.
Jun 19 2015, 9:40 PM
btrahan accepted rP65cdfa292f6d: Probably fix Diviner atom collisions.
Jun 19 2015, 9:39 PM
btrahan accepted D13362: Add an "--importing" flag to bin/repository reparse.
Jun 19 2015, 9:28 PM
btrahan updated the diff for D13351: Conpherence - remove room vs message distinction as far as users are concerned.

purge some more isRoom related stuff from the main query class

Jun 19 2015, 9:26 PM
btrahan accepted D13359: Provide general documentation on how to use perfomance tools.
Jun 19 2015, 9:11 PM
btrahan retitled D13351: Conpherence - remove room vs message distinction as far as users are concerned from WIP - Conpherence - remove room vs message distinction to Conpherence - remove room vs message distinction as far as users are concerned.
Jun 19 2015, 9:06 PM
btrahan updated the diff for D13351: Conpherence - remove room vs message distinction as far as users are concerned.

address self-updates to delete / remove modal dialogue vestiges

Jun 19 2015, 9:06 PM
btrahan added inline comments to D13351: Conpherence - remove room vs message distinction as far as users are concerned.
Jun 19 2015, 9:05 PM
btrahan updated D13351: Conpherence - remove room vs message distinction as far as users are concerned.
Jun 19 2015, 9:01 PM
btrahan updated the diff for D13351: Conpherence - remove room vs message distinction as far as users are concerned.

Updated to what's probably a reasonably stopping point. Will update description, etc after this.

Jun 19 2015, 8:59 PM
btrahan awarded D13358: Update the translations document a Doubloon token.
Jun 19 2015, 6:24 PM
btrahan accepted D13358: Update the translations document.

I think these docs are great. :D

Jun 19 2015, 6:24 PM

Jun 18 2015

btrahan added inline comments to D13351: Conpherence - remove room vs message distinction as far as users are concerned.
Jun 18 2015, 11:41 PM
btrahan added a comment to D13351: Conpherence - remove room vs message distinction as far as users are concerned.

These first two basically prove this works if you have no rooms yet:

Jun 18 2015, 11:40 PM
btrahan added tasks to D13351: Conpherence - remove room vs message distinction as far as users are concerned: T8488: Remove "room" vs "message" distinction, T8485: conpherence makes it hard to see all active conversations, T8469: Hard to find New Room workflow.
Jun 18 2015, 11:39 PM
btrahan added a revision to T8469: Hard to find New Room workflow: D13351: Conpherence - remove room vs message distinction as far as users are concerned.
Jun 18 2015, 11:39 PM · Conpherence
btrahan added a revision to T8485: conpherence makes it hard to see all active conversations: D13351: Conpherence - remove room vs message distinction as far as users are concerned.
Jun 18 2015, 11:39 PM · Conpherence
btrahan added a revision to T8488: Remove "room" vs "message" distinction: D13351: Conpherence - remove room vs message distinction as far as users are concerned.
Jun 18 2015, 11:39 PM · Conpherence
btrahan claimed T8488: Remove "room" vs "message" distinction.
Jun 18 2015, 11:29 PM · Conpherence
btrahan accepted D13349: Make owners typeahead mostly reasonable.
Jun 18 2015, 10:53 PM
btrahan abandoned D13343: stash.
Jun 18 2015, 9:57 PM
btrahan accepted D13348: Reduce badness in viewing large files in the Diffusion web UI.
Jun 18 2015, 7:55 PM
btrahan accepted D13347: Truncate large strings in DarkConsole.
Jun 18 2015, 7:54 PM
btrahan accepted D13345: Add "Autoplans" to Harbormaster.
Jun 18 2015, 7:53 PM
btrahan added a comment to T8594: Develop system for dumping/backing up Phriction documents.

I think Diviner is meant for these scenarios. Basically because

Jun 18 2015, 7:50 PM · Phriction, Restricted Project
btrahan accepted D13344: Modernize some Harbormaster Controller/Policy infrastructure.

I dunno, this was pretty exciting... :D

Jun 18 2015, 7:39 PM
btrahan added a comment to D13332: [Redesign] PhabricatorApplicationSearchResultView.

A few inline ideas that you are welcome to take or leave in my opinion.

Jun 18 2015, 7:37 PM
btrahan awarded D13332: [Redesign] PhabricatorApplicationSearchResultView a Doubloon token.
Jun 18 2015, 7:33 PM
btrahan accepted D13342: Clarify that 'order' is an optional parameter in Conduit API methods.
Jun 18 2015, 7:33 PM
btrahan accepted rP9109cf62e464: More correct fix - set default value array() for `getParameter` call..

Thanks for the demo. :D

Jun 18 2015, 6:09 PM
btrahan closed T8604: demo task as Invalid.
Jun 18 2015, 5:58 PM
btrahan created T8604: demo task.
Jun 18 2015, 5:53 PM
btrahan added an inline comment to M1421: Projects Touchup.
Jun 18 2015, 5:44 PM · Projects
btrahan raised a concern with rP9109cf62e464: More correct fix - set default value array() for `getParameter` call..

I am demoing making an audit on the fly. Don't worry. :D

Jun 18 2015, 5:32 PM
btrahan moved T8488: Remove "room" vs "message" distinction from Backlog to v3 on the Conpherence board.
Jun 18 2015, 5:27 PM · Conpherence
btrahan moved T8488: Remove "room" vs "message" distinction from v3 to Backlog on the Conpherence board.
Jun 18 2015, 5:27 PM · Conpherence
btrahan added inline comments to D13343: stash.
Jun 18 2015, 5:17 PM
btrahan retitled D13343: stash from to stash.
Jun 18 2015, 5:16 PM

Jun 17 2015

btrahan accepted D13329: Replace Harbormaster "BuildItem" with Lint/Unit messages.
Jun 17 2015, 10:31 PM
btrahan accepted rP29ac80be5c7d: Merge branch 'master' into redesign-2015.
Jun 17 2015, 10:27 PM
btrahan accepted rPe270157fcbd5: Fix a broken class name.
Jun 17 2015, 9:38 PM
btrahan accepted rP7ddaadffab0a: Merge branch 'master' into redesign-2015.
Jun 17 2015, 6:15 PM
btrahan accepted D13328: When showing policy hints, if the Space policy is strictly stronger, show it instead.
Jun 17 2015, 6:07 PM
btrahan accepted D13325: Improve Differential query plans.
Jun 17 2015, 6:06 PM
btrahan accepted D13324: Cache viewer spaces.
Jun 17 2015, 5:33 PM
btrahan accepted D13323: Make loading library maps much cheaper.
Jun 17 2015, 5:30 PM
btrahan accepted rPf1b7fd483e7e: Merge branch 'master' into redesign-2015.
Jun 17 2015, 5:24 PM
btrahan accepted D13331: Probably fix notifications not being properly marked as unread.
Jun 17 2015, 4:42 PM

Jun 16 2015

btrahan awarded D13320: Dramatically limit the range of failures which can cause duplicate mail a Mountain of Wealth token.
Jun 16 2015, 11:25 PM
btrahan accepted D13320: Dramatically limit the range of failures which can cause duplicate mail.
Jun 16 2015, 11:25 PM
btrahan accepted D13319: Fail gracefully on bad API call when building commit mail.
Jun 16 2015, 11:04 PM
btrahan committed rPdb9fc369ca62: Phriction - improve workflow for when user entered slug needs to be normalized. (authored by btrahan).
Phriction - improve workflow for when user entered slug needs to be normalized.
Jun 16 2015, 10:32 PM
btrahan closed D13316: Phriction - improve workflow for when user entered slug needs to be normalized. by committing rPdb9fc369ca62: Phriction - improve workflow for when user entered slug needs to be normalized..
Jun 16 2015, 10:32 PM
btrahan added a comment to T8574: Users receiving many duplicate emails.

If you visit one of the commit pages, do you see the 'somebody accept a commit' message duplicated / other duplicated activity?

Jun 16 2015, 10:29 PM · Phacility Support
btrahan added a comment to T8082: Exception when moving Phriction document into place of old one.

I think fixing this is basically removing the unique constraint on the "slugs" table in Phriction, and then using application logic to make sure that there can be only one active page with a given slug at any time.

Jun 16 2015, 10:22 PM · Restricted Project, Support Impact, Phriction
btrahan retitled D13316: Phriction - improve workflow for when user entered slug needs to be normalized. from to Phriction - improve workflow for when user entered slug needs to be normalized..
Jun 16 2015, 10:05 PM
btrahan added a comment to T8402: Moving Phriction page changes page title.

I can't seem to reproduce this. See this test page here...

Jun 16 2015, 10:04 PM · Phriction, Restricted Project
btrahan committed rPca8adac1eb40: Config - make "No auth providers configured" check use proper hyperlinking… (authored by btrahan).
Config - make "No auth providers configured" check use proper hyperlinking…
Jun 16 2015, 9:49 PM
btrahan closed T8346: Config issues should not use remarkup as Resolved by committing rPca8adac1eb40: Config - make "No auth providers configured" check use proper hyperlinking….
Jun 16 2015, 9:48 PM · Config
btrahan closed D13315: Config - make "No auth providers configured" check use proper hyperlinking technology by committing rPca8adac1eb40: Config - make "No auth providers configured" check use proper hyperlinking….
Jun 16 2015, 9:48 PM
btrahan added a comment to D13315: Config - make "No auth providers configured" check use proper hyperlinking technology.

Hmmm, with the sum of UI changes lately, it feels like a lot of scrolling to get down to the code.

Jun 16 2015, 9:47 PM
btrahan added a task to D13315: Config - make "No auth providers configured" check use proper hyperlinking technology: T8346: Config issues should not use remarkup.
Jun 16 2015, 9:44 PM
btrahan added a revision to T8346: Config issues should not use remarkup: D13315: Config - make "No auth providers configured" check use proper hyperlinking technology.
Jun 16 2015, 9:44 PM · Config
btrahan claimed T8346: Config issues should not use remarkup.
Jun 16 2015, 9:44 PM · Config
btrahan added a comment to T8518: InvalidArgumentException when re-joining a previously left Conpherence room.

Hey @tiguchi - thanks for the report. I think it should be fixed if you update to HEAD. If things still don't work for you please let me know and I'll take another look. Thanks again for the report!

Jun 16 2015, 9:37 PM · Conpherence
btrahan committed rP281082f4d730: Conpherence - fix a bug where users have no events (authored by btrahan).
Conpherence - fix a bug where users have no events
Jun 16 2015, 9:37 PM
btrahan closed D13314: Conpherence - fix a bug where users have no events by committing rP281082f4d730: Conpherence - fix a bug where users have no events.
Jun 16 2015, 9:37 PM
btrahan closed T8518: InvalidArgumentException when re-joining a previously left Conpherence room as Resolved by committing rP281082f4d730: Conpherence - fix a bug where users have no events.
Jun 16 2015, 9:37 PM · Conpherence
btrahan added a revision to T8518: InvalidArgumentException when re-joining a previously left Conpherence room: D13314: Conpherence - fix a bug where users have no events.
Jun 16 2015, 9:36 PM · Conpherence
btrahan added a task to D13314: Conpherence - fix a bug where users have no events: T8518: InvalidArgumentException when re-joining a previously left Conpherence room.
Jun 16 2015, 9:36 PM
btrahan claimed T8518: InvalidArgumentException when re-joining a previously left Conpherence room.
Jun 16 2015, 9:34 PM · Conpherence
btrahan committed rP8965c7ec9b89: Email Preferences - round out options for Projects and Phriction (authored by btrahan).
Email Preferences - round out options for Projects and Phriction
Jun 16 2015, 9:24 PM
btrahan closed T8524: Email preferences doesn't contain an entry for Project Subscriber updates as Resolved by committing rP8965c7ec9b89: Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:24 PM · FreeBSD, Wikimedia, Notifications
btrahan closed T8550: Email preference for Phriction document "changed subscribers" as Resolved by committing rP8965c7ec9b89: Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:24 PM · Phriction
btrahan closed D13313: Email Preferences - round out options for Projects and Phriction by committing rP8965c7ec9b89: Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:24 PM
btrahan claimed T8550: Email preference for Phriction document "changed subscribers".
Jun 16 2015, 9:22 PM · Phriction
btrahan retitled D13313: Email Preferences - round out options for Projects and Phriction from to Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:22 PM
btrahan added a revision to T8524: Email preferences doesn't contain an entry for Project Subscriber updates: D13313: Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:22 PM · FreeBSD, Wikimedia, Notifications
btrahan added a revision to T8550: Email preference for Phriction document "changed subscribers": D13313: Email Preferences - round out options for Projects and Phriction.
Jun 16 2015, 9:22 PM · Phriction
btrahan claimed T8524: Email preferences doesn't contain an entry for Project Subscriber updates.
Jun 16 2015, 9:21 PM · FreeBSD, Wikimedia, Notifications
btrahan added a comment to T8571: Make accepting audits faster/fewer clicks.

Is there any actual review happening in this workflow or is it just about getting the 100+ audits to an accepted state as quickly as possible?

Jun 16 2015, 9:21 PM · Restricted Project
btrahan accepted rPb97d7dddc806: Merge branch 'master' into redesign-2015.
Jun 16 2015, 9:18 PM
btrahan accepted rPc5c5523c1ff8: Add missing $mailer property to PhabricatorMailImplementationPHPMailerAdapter.
Jun 16 2015, 9:18 PM
btrahan closed T8416: Readonly access to users as Invalid.

How come the user shouldn't comment? What is the business value of letting someone read this information, but not interact with it further?

Jun 16 2015, 7:32 PM · Maniphest
btrahan closed T8416: Readonly access to users as Invalid.

...we're really looking for as much information as you can possibly provide about what you're trying to do here. As a simply stated feature, the answer is "wontfix".

Jun 16 2015, 7:20 PM · Maniphest
btrahan closed T8416: Readonly access to users as Invalid.

Please do re-open this if / when you have time to answer @epriestley's questions. Also, check out

Jun 16 2015, 6:38 PM · Maniphest
btrahan closed T8450: Can't invite members as Resolved.

Let us know if you weren't able to resolve this following @epriestley's instructions. Assuming things worked out for now... Thanks!

Jun 16 2015, 6:37 PM · Phacility Support
btrahan added a comment to T8528: Feature Request: Mark certain files as done reviewing.

See T3105#31820 for the reasoning for the "wontfix" status, which remains true today.

Jun 16 2015, 6:34 PM · Differential
btrahan merged task T8528: Feature Request: Mark certain files as done reviewing into Restricted Maniphest Task.
Jun 16 2015, 6:34 PM · Differential
btrahan closed T8542: Can't create new users as Invalid.

Let us know if restarting didn't resolve this. Thanks!

Jun 16 2015, 6:33 PM · Aphront
btrahan raised the priority of T8553: Allow Feed Item Deletion from Wishlist to Needs Triage.

Can you provide more examples of feed stories that you'd like to delete? Generally, I think the goal we want to solve is to make feed useful such that you don't feel the need to X out stories, so more context on what you want to remove is very helpful. In the example given, I would think we might want to aggregate those stories and just show a single one.

Jun 16 2015, 6:21 PM · Feed
btrahan closed T8564: No user images propagate through Azure CDN as Invalid.

I think this problem is with Azure, your configuration with Azure, etc, since if it was a generic issue serving files we'd be hearing more about it.

Jun 16 2015, 4:52 PM · Files

Jun 15 2015

btrahan accepted rP6af1c02f0625: Merge branch 'master' into redesign-2015.
Jun 15 2015, 10:29 PM
btrahan accepted rARC9a7c4d87a850: Fix missing property on ArcanistTestResultParser.
Jun 15 2015, 10:29 PM
btrahan accepted rPc2a2933848b6: Add missing property on PhabricatorBot.
Jun 15 2015, 10:29 PM
btrahan accepted rARC579c0eba1a00: Fix missing property in ArcanistPhpunitTestResultParser.
Jun 15 2015, 10:28 PM
btrahan accepted rP6aa494bd2523: Fix missing property on HarbormasterBuildStepImplementation.
Jun 15 2015, 10:28 PM