Page MenuHomePhabricator
Differential D13315

Config - make "No auth providers configured" check use proper hyperlinking technology
ClosedPublic
Actions

Authored by btrahan on Jun 16 2015, 9:44 PM.
Tags
None
Referenced Files
F15414848: D13315.id.diff
Thu, Mar 20, 2:48 AM
Unknown Object (File)
Feb 8 2025, 11:15 AM
Unknown Object (File)
Feb 8 2025, 11:15 AM
Unknown Object (File)
Feb 8 2025, 11:14 AM
Unknown Object (File)
Feb 8 2025, 11:14 AM
Unknown Object (File)
Jan 26 2025, 11:47 PM
Unknown Object (File)
Jan 24 2025, 6:24 AM
Unknown Object (File)
Jan 24 2025, 6:24 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8346: Config issues should not use remarkup
Commits
Restricted Diffusion Commit
rPca8adac1eb40: Config - make "No auth providers configured" check use proper hyperlinking…
Summary

Fixes T8346. Also gets rid of the air quotes on Auth and uses the "Appname Application" style we use elsewhere.

Test Plan

slapped an "|| true" in the checking logic and verified the link was rendered in a usable fashion just below the error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 32225.Jun 16 2015, 9:44 PM
btrahan added a task: T8346: Config issues should not use remarkup.
btrahan retitled this revision from to Config - make "No auth providers configured" check use proper hyperlinking technology.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2015, 9:44 PM
epriestley accepted this revision.Jun 16 2015, 9:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 9:45 PM
btrahan added a comment.Jun 16 2015, 9:47 PM

Hmmm, with the sum of UI changes lately, it feels like a lot of scrolling to get down to the code.

Closed by commit rPca8adac1eb40: Config - make "No auth providers configured" check use proper hyperlinking… (authored by btrahan, committed by btrahan). · Explain WhyJun 16 2015, 9:48 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Jun 16 2015, 9:55 PM

Yeah, that "Diff" panel is feeling a little big to me, too.

One thing that will help a little is moving a couple of options down (then the top panel won't be as big). Maybe that will be enough on its own.

Also maybe time to look at merging some of the other panels.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
6 lines

Diff 32226

View Options

src/applications/config/check/PhabricatorAuthSetupCheck.php

Loading...
Phabricator · Built by Phacility