Page MenuHomePhabricator

Conpherence - remove room vs message distinction as far as users are concerned
ClosedPublic

Authored by btrahan on Jun 18 2015, 11:39 PM.
Tags
None
Referenced Files
F13083617: D13351.diff
Wed, Apr 24, 10:40 PM
Unknown Object (File)
Wed, Apr 17, 3:28 PM
Unknown Object (File)
Tue, Apr 16, 11:09 PM
Unknown Object (File)
Thu, Apr 11, 5:31 PM
Unknown Object (File)
Fri, Apr 5, 12:33 PM
Unknown Object (File)
Tue, Apr 2, 1:27 AM
Unknown Object (File)
Fri, Mar 29, 9:10 PM
Unknown Object (File)
Wed, Mar 27, 9:57 PM

Details

Summary

Ref T8488, T8469, T8485.

This is done in regards to T8488 as far as users are concerned. There's still some classes, and etc. that should be re-named probably. T8469 and T8485 are basically moot now though.

Rather than having "Send Message" exposed, just expose "Create Room". Users get the full form. One change is "title" is now required.

This diff removes the concept of "isRoom" entirely.

Test Plan

Verifed a user with no conpherences had sensible data in both column view and full conpherence view. Created rooms with various policies and things worked well.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to WIP - Conpherence - remove room vs message distinction.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.

These first two basically prove this works if you have no rooms yet:

Screen Shot 2015-06-18 at 4.29.20 PM.png (1×2 px, 453 KB)

Screen Shot 2015-06-18 at 4.29.24 PM.png (1×2 px, 316 KB)

This one lets you see the wordy text I added in the modal choice between two room types:

Screen Shot 2015-06-18 at 4.29.27 PM.png (1×2 px, 425 KB)

src/applications/conpherence/view/ConpherenceThreadListView.php
5

this just happens to be the amount that fits perfectly in my current macbook pro window size.

I feel like my wordy text is very wordy and maybe its better to just let users set all these policies themselves

Yeah -- with the new "Thread Members" stuff, I'd lean toward just popping the full dialog (with policies defaulted to "Thread Members") and letting users open them up if they want. I think that'll be pretty reasonable/intuitive/clear.

The via profile version could streamline a little bit, maybe, but the modal dialog doesn't feel necessary to me.

(I vaguely wonder if calling the unified object a "Thread" is more clear than a "Room" -- or maybe we should even call them "Channels" -- but don't think that's too important.)

Conpherence Room is the bestest.

btrahan edited edge metadata.

Updated to what's probably a reasonably stopping point. Will update description, etc after this.

btrahan edited the test plan for this revision. (Show Details)
resources/sql/autopatches/20150619.conpherencerooms.1.sql
4–6

Do you want to call it "Room Members" or "Room Participants" ?

This diff changes user-facing strings to be consistently Participants.

src/applications/conpherence/controller/ConpherenceNewRoomController.php
84

will delete

src/applications/conpherence/controller/ConpherenceUpdateController.php
246–251

I couldn't use a re-direct response as I had to disable the notifications listener. this "go-home" thing is only used when removing yourself from a room

332

This isn't really the right check. Is there an easy way to figure out if the user would still be able to see the object if they were removed from participants? I guess I could attach participants array() to a clone of the object and check?

src/applications/conpherence/events/ConpherenceHovercardEventListener.php
34

will remove

src/applications/people/controller/PhabricatorPeopleProfileController.php
141

will remove

btrahan updated this object.

address self-updates to delete / remove modal dialogue vestiges

btrahan retitled this revision from WIP - Conpherence - remove room vs message distinction to Conpherence - remove room vs message distinction as far as users are concerned.Jun 19 2015, 9:06 PM
btrahan updated this object.
btrahan marked an inline comment as done.
btrahan updated this object.

purge some more isRoom related stuff from the main query class

epriestley edited edge metadata.

I don't feel strongly about members vs participants, standardizing seems good.

src/applications/conpherence/controller/ConpherenceUpdateController.php
332

Yeah, I think you basically have to clone and do hasCapability() check. This is more or less what we do in Editor to prevent you from locking yourself out of stuff.

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php
221–222

Does this still have callsites?

src/applications/conpherence/storage/ConpherenceThread.php
200

Maybe "Private Room", since the policy could be "everyone except you".

This revision is now accepted and ready to land.Jun 19 2015, 10:43 PM
btrahan edited edge metadata.

addressed inline feedback and a few text thread ==> room changes

Conpherence Room is the bestest.

This revision was automatically updated to reflect the committed changes.