Page MenuHomePhabricator
Differential D13344

Modernize some Harbormaster Controller/Policy infrastructure
ClosedPublic
Actions

Authored by epriestley on Jun 18 2015, 5:33 PM.
Tags
None
Referenced Files
F14059214: D13344.id32387.diff
Sun, Nov 17, 6:15 PM
F14012903: D13344.id.diff
Fri, Nov 1, 8:43 PM
F13998930: D13344.diff
Thu, Oct 24, 11:54 AM
F13970076: D13344.id32286.diff
Oct 17 2024, 5:34 AM
Unknown Object (File)
Oct 11 2024, 9:22 PM
Unknown Object (File)
Oct 9 2024, 2:10 AM
Unknown Object (File)
Oct 5 2024, 10:57 PM
Unknown Object (File)
Oct 1 2024, 2:20 PM
View All Files
Subscribers
epriestley
Tokens
"Love" token, awarded by hach-que.

Details

Reviewers
btrahan
Maniphest Tasks
T8095: Let Harbormaster own Lint and Unit results
Commits
Restricted Diffusion Commit
rP081300c7f861: Modernize some Harbormaster Controller/Policy infrastructure
Summary

Ref T8095. This is just general groundwork for more exciting changes:

  • Use more modern conventions around controllers, UI elements, and dialogs.
  • Provide real CAN_EDIT policies and policy checks (they just don't do anything yet).
Test Plan
  • Used all affected controllers.
  • Faked CAN_EDIT to POLICY_NOONE and verified everything was greyed out and unselectable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32286.Jun 18 2015, 5:33 PM
epriestley retitled this revision from to Modernize some Harbormaster Controller/Policy infrastructure.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8095: Let Harbormaster own Lint and Unit results.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 18 2015, 5:33 PM
epriestley added a comment.Jun 18 2015, 5:36 PM

Only one UI was materially affected by this change; the build plan UI looks like this now (new box thing):

Screen Shot 2015-06-18 at 10.35.55 AM.png (1×1 px, 190 KB)

hach-que awarded a token.Jun 18 2015, 5:38 PM
btrahan accepted this revision.Jun 18 2015, 7:39 PM
btrahan edited edge metadata.

I dunno, this was pretty exciting... :D

This revision is now accepted and ready to land.Jun 18 2015, 7:39 PM
Closed by commit rP081300c7f861: Modernize some Harbormaster Controller/Policy infrastructure (authored by epriestley, committed by epriestley). · Explain WhyJun 21 2015, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32387

View Options

src/applications/harbormaster/controller/HarbormasterController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanDisableController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanEditController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanRunController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepAddController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepDeleteController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepEditController.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

Loading...
Phabricator · Built by Phacility