Page MenuHomePhabricator

Email Preferences - round out options for Projects and Phriction
ClosedPublic

Authored by btrahan on Jun 16 2015, 9:22 PM.

Details

Summary

Fixes T8524, T8550. These were both missing "subscribers" and Phriction was also the only application with no "other".

Test Plan
  • Project
      • set user A to notify only for project subscriber changes
      • made a project with user A
      • subscribed user B to project
      • verified notification sent to user A
      • used ./bin/mail to make sure no mail was sent to user A because "This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences)."
    • Phriction
      • set user A to notify only for phriction document subscriber changes
      • made a document with user A
      • subscribed user B to document
      • verified notification sent to user A
      • used ./bin/mail to make sure no mail was sent to user A because "This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences)."
      • observed option for "other" in email preferences

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Email Preferences - round out options for Projects and Phriction.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 9:23 PM
This revision was automatically updated to reflect the committed changes.